Message ID | 578CF942.3030900@linux.vnet.ibm.com |
---|---|
State | New |
Headers | show |
On 7/18/16 12:44 PM, Gustavo Romero wrote: > Fix missing verb and typo in comment about AT_HWCAP entry, in the context > of mcontext_t struct definition for PPC64 Linux kernels. > > 2016-07-18 Gustavo Romero <gromero@linux.vnet.ibm.com> > > * sysdeps/unix/sysv/linux/powerpc/sys/ucontext.h: Fix missing verb > and typo in a comment about AT_HWCAP entry. LGTM.
Gustavo Romero <gromero@linux.vnet.ibm.com> writes: > [ text/plain ] > Fix missing verb and typo in comment about AT_HWCAP entry, in the context > of mcontext_t struct definition for PPC64 Linux kernels. > > 2016-07-18 Gustavo Romero <gromero@linux.vnet.ibm.com> > > * sysdeps/unix/sysv/linux/powerpc/sys/ucontext.h: Fix missing verb > and typo in a comment about AT_HWCAP entry. As this is a trivial fix, I pushed it as b898b64. Thanks!
On 07/21/2016 08:23 PM, Tulio Magno Quites Machado Filho wrote: > Gustavo Romero <gromero@linux.vnet.ibm.com> writes: > >> [ text/plain ] >> Fix missing verb and typo in comment about AT_HWCAP entry, in the context >> of mcontext_t struct definition for PPC64 Linux kernels. >> >> 2016-07-18 Gustavo Romero <gromero@linux.vnet.ibm.com> >> >> * sysdeps/unix/sysv/linux/powerpc/sys/ucontext.h: Fix missing verb >> and typo in a comment about AT_HWCAP entry. > > As this is a trivial fix, I pushed it as b898b64. I don't think such changes are appropriate without RM approval during a hard freeze, FWIW. Florian
On 22/07/2016 06:20, Florian Weimer wrote: > On 07/21/2016 08:23 PM, Tulio Magno Quites Machado Filho wrote: >> Gustavo Romero <gromero@linux.vnet.ibm.com> writes: >> >>> [ text/plain ] >>> Fix missing verb and typo in comment about AT_HWCAP entry, in the context >>> of mcontext_t struct definition for PPC64 Linux kernels. >>> >>> 2016-07-18 Gustavo Romero <gromero@linux.vnet.ibm.com> >>> >>> * sysdeps/unix/sysv/linux/powerpc/sys/ucontext.h: Fix missing verb >>> and typo in a comment about AT_HWCAP entry. >> >> As this is a trivial fix, I pushed it as b898b64. > > I don't think such changes are appropriate without RM approval during a hard freeze, FWIW. Tulio contacted me in IRC. I apologize that I did not reply this thread on the list.
diff --git a/sysdeps/unix/sysv/linux/powerpc/sys/ucontext.h b/sysdeps/unix/sysv/linux/powerpc/sys/ucontext.h index 04100a2..2b97bc7 100644 --- a/sysdeps/unix/sysv/linux/powerpc/sys/ucontext.h +++ b/sysdeps/unix/sysv/linux/powerpc/sys/ucontext.h @@ -64,8 +64,8 @@ typedef struct /* For 64-bit kernels with Altivec support, a machine context is exactly * a sigcontext. For older kernel (without Altivec) the sigcontext matches * the mcontext upto but not including the v_regs field. For kernels that - * don't AT_HWCAP or return AT_HWCAP without PPC_FEATURE_HAS_ALTIVEC the - * v_regs field may not exit and should not be referenced. The v_regd field + * don't set AT_HWCAP or return AT_HWCAP without PPC_FEATURE_HAS_ALTIVEC the + * v_regs field may not exist and should not be referenced. The v_regd field * can be refernced safely only after verifying that PPC_FEATURE_HAS_ALTIVEC * is set in AT_HWCAP. */