| Submitter | LEROY Christophe |
|---|---|
| Date | Sept. 16, 2010, 7:04 a.m. |
| Message ID | <20100916070420.95083C7391@messagerie.si.c-s.fr> |
| Download | mbox | patch |
| Permalink | /patch/64941/ |
| State | Accepted |
| Delegated to: | Kumar Gala |
| Headers | show |
Comments
> From: christophe leroy <christophe.leroy@c-s.fr> > To: David Brownell <dbrownell@users.sourceforge.net>, Grant Likely > <grant.likely@secretlab.ca>, spi-devel-general@lists.sourceforge.net, linux- > kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org > Date: 2010/09/16 09:06 > Subject: [PATCH] spi_mpc8xxx: fix writing to adress 0 > Sent by: linuxppc-dev-bounces+joakim.tjernlund=transmode.se@lists.ozlabs.org > > This patch applies to 2.6.34.7 (already included in 2.6.35.4) > It fixes an issue when sending only or receiving only (mspi->tx-dma was reset > as when no tx_buf is defined, tx_dma is 0) > > Signed-off-by: christophe leroy <christophe.leroy@c-s.fr> Acked-by: Joakim Tjernlund <Joakim.Tjernlund@transmode.se>
On Thu, Sep 16, 2010 at 09:39:09AM +0200, Joakim Tjernlund wrote: > > From: christophe leroy <christophe.leroy@c-s.fr> > > To: David Brownell <dbrownell@users.sourceforge.net>, Grant Likely > > <grant.likely@secretlab.ca>, spi-devel-general@lists.sourceforge.net, linux- > > kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org > > Date: 2010/09/16 09:06 > > Subject: [PATCH] spi_mpc8xxx: fix writing to adress 0 > > Sent by: linuxppc-dev-bounces+joakim.tjernlund=transmode.se@lists.ozlabs.org > > > > This patch applies to 2.6.34.7 (already included in 2.6.35.4) > > It fixes an issue when sending only or receiving only (mspi->tx-dma was reset > > as when no tx_buf is defined, tx_dma is 0) > > > > Signed-off-by: christophe leroy <christophe.leroy@c-s.fr> > > Acked-by: Joakim Tjernlund <Joakim.Tjernlund@transmode.se> > You need to send this to the linux-stable list and include the sha1 commit id that fixes it in mainline. Acked-by: Grant Likely <grant.likely@secretlab.ca> g.
Patch
diff -urN a/drivers/spi/spi_mpc8xxx.c b/drivers/spi/spi_mpc8xxx.c --- a/drivers/spi/spi_mpc8xxx.c 2010-09-08 16:42:30.000000000 +0200 +++ b/drivers/spi/spi_mpc8xxx.c 2010-09-08 16:43:50.000000000 +0200 @@ -438,7 +438,7 @@ dev_err(dev, "unable to map tx dma\n"); return -ENOMEM; } - } else { + } else if (t->tx_buf) { mspi->tx_dma = t->tx_dma; } @@ -449,7 +449,7 @@ dev_err(dev, "unable to map rx dma\n"); goto err_rx_dma; } - } else { + } else if (t->rx_buf) { mspi->rx_dma = t->rx_dma; } _______________________________________________
This patch applies to 2.6.34.7 (already included in 2.6.35.4) It fixes an issue when sending only or receiving only (mspi->tx-dma was reset as when no tx_buf is defined, tx_dma is 0) Signed-off-by: christophe leroy <christophe.leroy@c-s.fr> Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev