| Message ID | 1468813627-5365-4-git-send-email-sriram.dash@nxp.com |
|---|---|
| State | Superseded |
| Delegated to: | York Sun |
| Headers | show |
On 07/18/2016 05:47 AM, Sriram Dash wrote: > Apply USB errata A006261 for P2041, P2040. The subject and the commit message say different things. Moreover, the errata is obviously already applied to P2040 and P2041. I am extremely annoyed by such crap patches, so I stop reviewing here. > Signed-off-by: Sriram Dash <sriram.dash@nxp.com> > Signed-off-by: Rajesh Bhagat <rajesh.bhagat@nxp.com> > --- > drivers/usb/common/fsl-errata.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/usb/common/fsl-errata.c b/drivers/usb/common/fsl-errata.c > index 183bf2b..122e17b 100644 > --- a/drivers/usb/common/fsl-errata.c > +++ b/drivers/usb/common/fsl-errata.c > @@ -53,7 +53,8 @@ bool has_erratum_a006261(void) > case SVR_P2041: > case SVR_P2040: > return IS_SVR_REV(svr, 1, 0) || > - IS_SVR_REV(svr, 1, 1) || IS_SVR_REV(svr, 2, 1); > + IS_SVR_REV(svr, 1, 1) || > + IS_SVR_REV(svr, 2, 0) || IS_SVR_REV(svr, 2, 1); > case SVR_P3041: > return IS_SVR_REV(svr, 1, 0) || > IS_SVR_REV(svr, 1, 1) || >
Same comment to the subject. On 07/17/2016 08:47 PM, Sriram Dash wrote: > Apply USB errata A006261 for P2041, P2040. > > Signed-off-by: Sriram Dash <sriram.dash@nxp.com> > Signed-off-by: Rajesh Bhagat <rajesh.bhagat@nxp.com> > --- > drivers/usb/common/fsl-errata.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/usb/common/fsl-errata.c b/drivers/usb/common/fsl-errata.c > index 183bf2b..122e17b 100644 > --- a/drivers/usb/common/fsl-errata.c > +++ b/drivers/usb/common/fsl-errata.c > @@ -53,7 +53,8 @@ bool has_erratum_a006261(void) > case SVR_P2041: > case SVR_P2040: > return IS_SVR_REV(svr, 1, 0) || > - IS_SVR_REV(svr, 1, 1) || IS_SVR_REV(svr, 2, 1); > + IS_SVR_REV(svr, 1, 1) || > + IS_SVR_REV(svr, 2, 0) || IS_SVR_REV(svr, 2, 1); Please explain in the commit message why you replace rev 1.1 with rev 2.0. York > case SVR_P3041: > return IS_SVR_REV(svr, 1, 0) || > IS_SVR_REV(svr, 1, 1) || >
>From: york sun > >Same comment to the subject. > Ok. Will modify patch title and commit message in v3. >On 07/17/2016 08:47 PM, Sriram Dash wrote: >> Apply USB errata A006261 for P2041, P2040. >> >> Signed-off-by: Sriram Dash <sriram.dash@nxp.com> >> Signed-off-by: Rajesh Bhagat <rajesh.bhagat@nxp.com> >> --- >> drivers/usb/common/fsl-errata.c | 3 ++- >> 1 file changed, 2 insertions(+), 1 deletion(-) >> >> diff --git a/drivers/usb/common/fsl-errata.c >> b/drivers/usb/common/fsl-errata.c index 183bf2b..122e17b 100644 >> --- a/drivers/usb/common/fsl-errata.c >> +++ b/drivers/usb/common/fsl-errata.c >> @@ -53,7 +53,8 @@ bool has_erratum_a006261(void) >> case SVR_P2041: >> case SVR_P2040: >> return IS_SVR_REV(svr, 1, 0) || >> - IS_SVR_REV(svr, 1, 1) || IS_SVR_REV(svr, 2, 1); >> + IS_SVR_REV(svr, 1, 1) || >> + IS_SVR_REV(svr, 2, 0) || IS_SVR_REV(svr, 2, 1); > >Please explain in the commit message why you replace rev 1.1 with rev 2.0. > >York > I have not removed the rev 1.1 support, only added the rev 2.0 support. Will modify patch title and commit message in v3. > >> case SVR_P3041: >> return IS_SVR_REV(svr, 1, 0) || >> IS_SVR_REV(svr, 1, 1) || >>
diff --git a/drivers/usb/common/fsl-errata.c b/drivers/usb/common/fsl-errata.c index 183bf2b..122e17b 100644 --- a/drivers/usb/common/fsl-errata.c +++ b/drivers/usb/common/fsl-errata.c @@ -53,7 +53,8 @@ bool has_erratum_a006261(void) case SVR_P2041: case SVR_P2040: return IS_SVR_REV(svr, 1, 0) || - IS_SVR_REV(svr, 1, 1) || IS_SVR_REV(svr, 2, 1); + IS_SVR_REV(svr, 1, 1) || + IS_SVR_REV(svr, 2, 0) || IS_SVR_REV(svr, 2, 1); case SVR_P3041: return IS_SVR_REV(svr, 1, 0) || IS_SVR_REV(svr, 1, 1) ||