Patchwork Bug bootstrap/45680

login
register
mail settings
Submitter reza yazdani
Date Sept. 15, 2010, 8:46 p.m.
Message ID <198094.158.qm@web33001.mail.mud.yahoo.com>
Download mbox | patch
Permalink /patch/64903/
State New
Headers show

Comments

reza yazdani - Sept. 15, 2010, 8:46 p.m.
Function min_insn_size is defined under "#ifdef ASM_OUTPUT_MAX_SKIP_PAD" flag. Dispatch Scheduler called the function after #endif.

In this fix we move dispatch scheduler code under the same #ifdef.

Testing
-------

Self compile ran with “–mdispatch-scheduling -fschedule-insns -fsched-pressure –O2". Dispatch scheduling flag was manually set on in the self compile to exercise the new code. No new test added for this implementation. Make check of i386 tests passes. No difference in the number of failures with and without the dispatch flag.

ChangeLog
---------

2010-09-15  Reza Yazdani  <reza.yazdani@amd.com>

    * i386.c (#ifdef ASM_OUTPUT_MAX_SKIP_PAD): Added.

Is it okay to commit to trunk?

Reza
Richard Henderson - Sept. 15, 2010, 10:07 p.m.
On 09/15/2010 01:46 PM, reza yazdani wrote:
> Function min_insn_size is defined under "#ifdef
> ASM_OUTPUT_MAX_SKIP_PAD" flag. Dispatch Scheduler called the function
> after #endif.
> 
> In this fix we move dispatch scheduler code under the same #ifdef.

That's hardly the correct fix.  If the dispatch scheduler needs
to use that function, then remove the ifdefs around its definition.


r~

Patch

Index: config/i386/i386.c
===================================================================
--- config/i386/i386.c	(revision 164315)
+++ config/i386/i386.c	(working copy)
@@ -31541,6 +31541,7 @@  ix86_enum_va_list (int idx, const char *
 
   return 0;
 }
+#ifdef ASM_OUTPUT_MAX_SKIP_PAD
 
 #undef TARGET_SCHED_DISPATCH
 #define TARGET_SCHED_DISPATCH has_dispatch
@@ -32341,7 +32342,7 @@  has_dispatch (rtx insn, int action)
 
   return false;
 }
-
+#endif
 /* ??? No autovectorization into MMX or 3DNOW until we can reliably
    place emms and femms instructions.  */