| Message ID | 20160714212608.GA10856@mwanda |
|---|---|
| State | Superseded |
| Headers | show |
On Fri, Jul 15, 2016 at 12:26:08AM +0300, Dan Carpenter wrote: > It doesn't affect runtime, but curly braces were obviously intended. > > Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> Thanks, but you're just a tad late ;) http://patchwork.ozlabs.org/patch/648283/ Nice to point out that technically, the behavior doesn't really change though. Brian > diff --git a/drivers/mtd/nand/omap2.c b/drivers/mtd/nand/omap2.c > index a36ad3d..ab7c340 100644 > --- a/drivers/mtd/nand/omap2.c > +++ b/drivers/mtd/nand/omap2.c > @@ -1655,10 +1655,11 @@ static int omap_get_dt_info(struct device *dev, struct omap_nand_info *info) > > /* detect availability of ELM module. Won't be present pre-OMAP4 */ > info->elm_of_node = of_parse_phandle(child, "ti,elm-id", 0); > - if (!info->elm_of_node) > + if (!info->elm_of_node) { > info->elm_of_node = of_parse_phandle(child, "elm_id", 0); > if (!info->elm_of_node) > dev_dbg(dev, "ti,elm-id not in DT\n"); > + } > > /* select ecc-scheme for NAND */ > if (of_property_read_string(child, "ti,nand-ecc-opt", &s)) {
diff --git a/drivers/mtd/nand/omap2.c b/drivers/mtd/nand/omap2.c index a36ad3d..ab7c340 100644 --- a/drivers/mtd/nand/omap2.c +++ b/drivers/mtd/nand/omap2.c @@ -1655,10 +1655,11 @@ static int omap_get_dt_info(struct device *dev, struct omap_nand_info *info) /* detect availability of ELM module. Won't be present pre-OMAP4 */ info->elm_of_node = of_parse_phandle(child, "ti,elm-id", 0); - if (!info->elm_of_node) + if (!info->elm_of_node) { info->elm_of_node = of_parse_phandle(child, "elm_id", 0); if (!info->elm_of_node) dev_dbg(dev, "ti,elm-id not in DT\n"); + } /* select ecc-scheme for NAND */ if (of_property_read_string(child, "ti,nand-ecc-opt", &s)) {
It doesn't affect runtime, but curly braces were obviously intended. Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>