Patch committed: Do not capitalize warning messages

Submitted by Ian Taylor on Sept. 15, 2010, 2:50 p.m.

Details

Message ID mcrpqwfukl2.fsf@google.com
State New
Headers show

Commit Message

Ian Taylor Sept. 15, 2010, 2:50 p.m.
The convention for warning messages in GNU programs is that they not be
capitalized.  I noticed a couple of cases where they were.  Patch
bootstrapped and tested on x86_64-unknown-linux-gnu.  Committed as
obvious.

Ian


2010-09-15  Ian Lance Taylor  <iant@google.com>

	* c-common.c (parse_optimize_options): Do not capitalize warning
	messages.

Comments

Joseph S. Myers Sept. 15, 2010, 3:31 p.m.
On Wed, 15 Sep 2010, Ian Lance Taylor wrote:

> -			     "Bad option %s to optimize attribute.", p);
> +			     "bad option %s to optimize attribute.", p);

There's still an inappropriate trailing "." here....

(Anyone who wishes to clean up such issues generally rather than as they 
come across them should probably regenerate gcc.pot then look there for 
messages beginning with a capital letter or ending with "." - some 
messages in gcc.pot are option help texts etc., but most are diagnostics.)

Patch hide | download patch | download mbox

Index: c-family/c-common.c
===================================================================
--- c-family/c-common.c	(revision 164305)
+++ c-family/c-common.c	(working copy)
@@ -7730,10 +7730,10 @@  parse_optimize_options (tree args, bool 
 		  ret = false;
 		  if (attr_p)
 		    warning (OPT_Wattributes,
-			     "Bad option %s to optimize attribute.", p);
+			     "bad option %s to optimize attribute.", p);
 		  else
 		    warning (OPT_Wpragmas,
-			     "Bad option %s to pragma attribute", p);
+			     "bad option %s to pragma attribute", p);
 		  continue;
 		}