| Message ID | 1468434634-31859-1-git-send-email-moritz.fischer@ettus.com |
|---|---|
| State | Superseded |
| Delegated to: | Jagannadha Sutradharudu Teki |
| Headers | show |
On 14 July 2016 at 00:00, Moritz Fischer <moritz.fischer@ettus.com> wrote: > Signed-off-by: Moritz Fischer <moritz.fischer@ettus.com> > --- > drivers/mtd/spi/sf_params.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/mtd/spi/sf_params.c b/drivers/mtd/spi/sf_params.c > index 4f37e33..8ae4eea 100644 > --- a/drivers/mtd/spi/sf_params.c > +++ b/drivers/mtd/spi/sf_params.c > @@ -83,6 +83,7 @@ const struct spi_flash_params spi_flash_params_table[] = { > {"M25P64", 0x202017, 0x0, 64 * 1024, 128, RD_NORM, 0}, > {"M25P128", 0x202018, 0x0, 256 * 1024, 64, RD_NORM, 0}, > {"M25PX64", 0x207117, 0x0, 64 * 1024, 128, RD_NORM, SECT_4K}, > + {"N25Q016A", 0x20bb15, 0x1000, 64 * 1024, 32, RD_NORM, SECT_4K}, Why would we need this ext_id (0x1000) here? I understand this is true number for this part but it shouldn't require for probe or require somewhere else? thanks!
Jagan, thanks for your review! On Thu, Jul 14, 2016 at 12:01 AM, Jagan Teki <jagannadh.teki@gmail.com> wrote: > On 14 July 2016 at 00:00, Moritz Fischer <moritz.fischer@ettus.com> wrote: >> Signed-off-by: Moritz Fischer <moritz.fischer@ettus.com> >> --- >> drivers/mtd/spi/sf_params.c | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/drivers/mtd/spi/sf_params.c b/drivers/mtd/spi/sf_params.c >> index 4f37e33..8ae4eea 100644 >> --- a/drivers/mtd/spi/sf_params.c >> +++ b/drivers/mtd/spi/sf_params.c >> @@ -83,6 +83,7 @@ const struct spi_flash_params spi_flash_params_table[] = { >> {"M25P64", 0x202017, 0x0, 64 * 1024, 128, RD_NORM, 0}, >> {"M25P128", 0x202018, 0x0, 256 * 1024, 64, RD_NORM, 0}, >> {"M25PX64", 0x207117, 0x0, 64 * 1024, 128, RD_NORM, SECT_4K}, >> + {"N25Q016A", 0x20bb15, 0x1000, 64 * 1024, 32, RD_NORM, SECT_4K}, > > Why would we need this ext_id (0x1000) here? I understand this is true > number for this part but it shouldn't require for probe or require > somewhere else? You're right. I just sent v3. Cheers, Moritz
diff --git a/drivers/mtd/spi/sf_params.c b/drivers/mtd/spi/sf_params.c index 4f37e33..8ae4eea 100644 --- a/drivers/mtd/spi/sf_params.c +++ b/drivers/mtd/spi/sf_params.c @@ -83,6 +83,7 @@ const struct spi_flash_params spi_flash_params_table[] = { {"M25P64", 0x202017, 0x0, 64 * 1024, 128, RD_NORM, 0}, {"M25P128", 0x202018, 0x0, 256 * 1024, 64, RD_NORM, 0}, {"M25PX64", 0x207117, 0x0, 64 * 1024, 128, RD_NORM, SECT_4K}, + {"N25Q016A", 0x20bb15, 0x1000, 64 * 1024, 32, RD_NORM, SECT_4K}, {"N25Q32", 0x20ba16, 0x0, 64 * 1024, 64, RD_FULL, WR_QPP | SECT_4K}, {"N25Q32A", 0x20bb16, 0x0, 64 * 1024, 64, RD_FULL, WR_QPP | SECT_4K}, {"N25Q64", 0x20ba17, 0x0, 64 * 1024, 128, RD_FULL, WR_QPP | SECT_4K},
Signed-off-by: Moritz Fischer <moritz.fischer@ettus.com> --- drivers/mtd/spi/sf_params.c | 1 + 1 file changed, 1 insertion(+)