Patchwork SPARC32 SMP 2.6.36-rc3 build error

login
register
mail settings
Submitter David Miller
Date Sept. 15, 2010, 4:42 a.m.
Message ID <20100914.214235.183040334.davem@davemloft.net>
Download mbox | patch
Permalink /patch/64773/
State Accepted
Delegated to: David Miller
Headers show

Comments

David Miller - Sept. 15, 2010, 4:42 a.m.
From: Daniel Hellstrom <daniel@gaisler.com>
Date: Tue, 14 Sep 2010 15:30:27 +0200

> I have problems linking Linux SPARC32 when SMP is enabled:
> 
>  LD      vmlinux
>  SYSMAP  System.map
>  SYSMAP  .tmp_System.map
>  BTFIX   arch/sparc/boot/btfix.S
>  AS      arch/sparc/boot/btfix.o
>  LD      arch/sparc/boot/image
> net/built-in.o: In function `net_rps_action_and_irq_enable':
> /home/daniel/linux/linux/linux-2.6/net/core/dev.c:3337: undefined
> reference to `__smp_call_function_single'
> make[1]: *** [arch/sparc/boot/image] Error 1
> make: *** [zImage] Error 2

It's a missing dependency in the networking code, I'll fix this
in the net-2.6 tree as follows:

--------------------
net: RPS needs to depend upon USE_GENERIC_SMP_HELPERS

You cannot invoke __smp_call_function_single() unless the
architecture sets this symbol.

Reported-by: Daniel Hellstrom <daniel@gaisler.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
---
 net/Kconfig |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
Daniel Hellstrom - Sept. 15, 2010, 7:20 a.m.
David Miller wrote:

>From: Daniel Hellstrom <daniel@gaisler.com>
>Date: Tue, 14 Sep 2010 15:30:27 +0200
>
>  
>
>>I have problems linking Linux SPARC32 when SMP is enabled:
>>
>> LD      vmlinux
>> SYSMAP  System.map
>> SYSMAP  .tmp_System.map
>> BTFIX   arch/sparc/boot/btfix.S
>> AS      arch/sparc/boot/btfix.o
>> LD      arch/sparc/boot/image
>>net/built-in.o: In function `net_rps_action_and_irq_enable':
>>/home/daniel/linux/linux/linux-2.6/net/core/dev.c:3337: undefined
>>reference to `__smp_call_function_single'
>>make[1]: *** [arch/sparc/boot/image] Error 1
>>make: *** [zImage] Error 2
>>    
>>
>
>It's a missing dependency in the networking code, I'll fix this
>in the net-2.6 tree as follows:
>
>--------------------
>net: RPS needs to depend upon USE_GENERIC_SMP_HELPERS
>
>You cannot invoke __smp_call_function_single() unless the
>architecture sets this symbol.
>
>Reported-by: Daniel Hellstrom <daniel@gaisler.com>
>Signed-off-by: David S. Miller <davem@davemloft.net>
>---
> net/Kconfig |    2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
>diff --git a/net/Kconfig b/net/Kconfig
>index e330594..e926884 100644
>--- a/net/Kconfig
>+++ b/net/Kconfig
>@@ -217,7 +217,7 @@ source "net/dns_resolver/Kconfig"
> 
> config RPS
> 	boolean
>-	depends on SMP && SYSFS
>+	depends on SMP && SYSFS && USE_GENERIC_SMP_HELPERS
> 	default y
> 
> menu "Network testing"
>  
>

That resolved the problem nicely.

Thank you very much,
Daniel

--
To unsubscribe from this list: send the line "unsubscribe sparclinux" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Patch

diff --git a/net/Kconfig b/net/Kconfig
index e330594..e926884 100644
--- a/net/Kconfig
+++ b/net/Kconfig
@@ -217,7 +217,7 @@  source "net/dns_resolver/Kconfig"
 
 config RPS
 	boolean
-	depends on SMP && SYSFS
+	depends on SMP && SYSFS && USE_GENERIC_SMP_HELPERS
 	default y
 
 menu "Network testing"