| Message ID | 20100915015052.GA6602@mmm.home.ifup.org |
|---|---|
| State | Changes Requested, archived |
| Delegated to: | David Miller |
| Headers | show |
From: Brandon Philips <bphilips@suse.de> Date: Tue, 14 Sep 2010 18:50:53 -0700 > When running a vlan -> bridge -> domU setup I was noticing poor RX > performance. It seems ixgbe and other drivers don't have NETIF_F_GRO set > in vlan_features and thus GRO is off by default for vlans. > > I see no reason why the other drivers shouldn't be fixed. If this is OK > I will go off and fix the rest. > > Signed-off-by: Brandon Philips <bphilips@suse.de> I think it should be set, but why don't we do this another way? This feature is a software feature, essentially, so if it is published in netdev->features we can simply propagate it automatically to netdev->vlan_features at device registry time in the core networking. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On 21:35 Tue 14 Sep 2010, David Miller wrote: > From: Brandon Philips <bphilips@suse.de> > Date: Tue, 14 Sep 2010 18:50:53 -0700 > > > When running a vlan -> bridge -> domU setup I was noticing poor RX > > performance. It seems ixgbe and other drivers don't have NETIF_F_GRO set > > in vlan_features and thus GRO is off by default for vlans. > > > > I see no reason why the other drivers shouldn't be fixed. If this is OK > > I will go off and fix the rest. > > > > Signed-off-by: Brandon Philips <bphilips@suse.de> > > I think it should be set, but why don't we do this another way? > > This feature is a software feature, essentially, so if it is published > in netdev->features we can simply propagate it automatically to > netdev->vlan_features at device registry time in the core networking. Agreed. I will just send a patch to vlan_dev.c then. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/net/ixgbe/ixgbe_main.c b/drivers/net/ixgbe/ixgbe_main.c index d03eef9..0b39757 100644 --- a/drivers/net/ixgbe/ixgbe_main.c +++ b/drivers/net/ixgbe/ixgbe_main.c @@ -6817,6 +6817,7 @@ static int __devinit ixgbe_probe(struct pci_dev *pdev, netdev->vlan_features |= NETIF_F_IP_CSUM; netdev->vlan_features |= NETIF_F_IPV6_CSUM; netdev->vlan_features |= NETIF_F_SG; + netdev->vlan_features |= NETIF_F_GRO; if (adapter->flags & IXGBE_FLAG_SRIOV_ENABLED) adapter->flags &= ~(IXGBE_FLAG_RSS_ENABLED |
When running a vlan -> bridge -> domU setup I was noticing poor RX performance. It seems ixgbe and other drivers don't have NETIF_F_GRO set in vlan_features and thus GRO is off by default for vlans. I see no reason why the other drivers shouldn't be fixed. If this is OK I will go off and fix the rest. Signed-off-by: Brandon Philips <bphilips@suse.de> --- drivers/net/ixgbe/ixgbe_main.c | 1 + 1 files changed, 1 insertions(+), 0 deletions(-)