| Message ID | 1468353217-1451-1-git-send-email-debmc@linux.vnet.ibm.com |
|---|---|
| State | Accepted |
| Headers | show |
On 12/07/16 20:53, Deb McLemore wrote: > When running prd_info the device tree validation may > not succeed due to functional problems or lack of > proper setup and tools. This patch will improve > the usability by suggesting methods to diagnose > the problem. > > Signed-off-by: Deb McLemore <debmc@linux.vnet.ibm.com> > --- > src/opal/prd_info.c | 11 +++++++++-- > 1 file changed, 9 insertions(+), 2 deletions(-) > > diff --git a/src/opal/prd_info.c b/src/opal/prd_info.c > index 537d1ed..bdbfb9d 100644 > --- a/src/opal/prd_info.c > +++ b/src/opal/prd_info.c > @@ -200,8 +200,15 @@ static int prd_info_init(fwts_framework *fw) > } > #endif > } else { > - fwts_log_info(fw, "The OPAL PRD device tree node" > - " is not present so skipping test"); > + fwts_log_info(fw, "The OPAL PRD device tree node is not" > + " able to be detected so skipping the prd_info" > + " test. There may be tools missing such as" > + " libfdt-dev or dtc, check that the packages" > + " are installed and re-build if needed." > + " If this condition persists try running the" > + " dt_base test to further diagnose. If dt_base" > + " test is not available this is probably a" > + " setup problem."); > return FWTS_SKIP; > } > > Acked-by: Colin Ian King <colin.king@canonical.com>
On 2016-07-13 03:53 AM, Deb McLemore wrote: > When running prd_info the device tree validation may > not succeed due to functional problems or lack of > proper setup and tools. This patch will improve > the usability by suggesting methods to diagnose > the problem. > > Signed-off-by: Deb McLemore <debmc@linux.vnet.ibm.com> > --- > src/opal/prd_info.c | 11 +++++++++-- > 1 file changed, 9 insertions(+), 2 deletions(-) > > diff --git a/src/opal/prd_info.c b/src/opal/prd_info.c > index 537d1ed..bdbfb9d 100644 > --- a/src/opal/prd_info.c > +++ b/src/opal/prd_info.c > @@ -200,8 +200,15 @@ static int prd_info_init(fwts_framework *fw) > } > #endif > } else { > - fwts_log_info(fw, "The OPAL PRD device tree node" > - " is not present so skipping test"); > + fwts_log_info(fw, "The OPAL PRD device tree node is not" > + " able to be detected so skipping the prd_info" > + " test. There may be tools missing such as" > + " libfdt-dev or dtc, check that the packages" > + " are installed and re-build if needed." > + " If this condition persists try running the" > + " dt_base test to further diagnose. If dt_base" > + " test is not available this is probably a" > + " setup problem."); > return FWTS_SKIP; > } > > Acked-by: Alex Hung <alex.hung@canonical.com>
diff --git a/src/opal/prd_info.c b/src/opal/prd_info.c index 537d1ed..bdbfb9d 100644 --- a/src/opal/prd_info.c +++ b/src/opal/prd_info.c @@ -200,8 +200,15 @@ static int prd_info_init(fwts_framework *fw) } #endif } else { - fwts_log_info(fw, "The OPAL PRD device tree node" - " is not present so skipping test"); + fwts_log_info(fw, "The OPAL PRD device tree node is not" + " able to be detected so skipping the prd_info" + " test. There may be tools missing such as" + " libfdt-dev or dtc, check that the packages" + " are installed and re-build if needed." + " If this condition persists try running the" + " dt_base test to further diagnose. If dt_base" + " test is not available this is probably a" + " setup problem."); return FWTS_SKIP; }
When running prd_info the device tree validation may not succeed due to functional problems or lack of proper setup and tools. This patch will improve the usability by suggesting methods to diagnose the problem. Signed-off-by: Deb McLemore <debmc@linux.vnet.ibm.com> --- src/opal/prd_info.c | 11 +++++++++-- 1 file changed, 9 insertions(+), 2 deletions(-)