Patchwork Updating frequencies and dominators

login
register
mail settings
Submitter Sebastian Pop
Date Sept. 14, 2010, 3:57 p.m.
Message ID <AANLkTinmA0+9t=2MJ2eWsWaNsvpX+3SqaRom1z-AnM0s@mail.gmail.com>
Download mbox | patch
Permalink /patch/64724/
State New
Headers show

Comments

Sebastian Pop - Sept. 14, 2010, 3:57 p.m.
On Tue, Sep 14, 2010 at 10:48, Richard Guenther
<richard.guenther@gmail.com> wrote:
> if you didn't compute post-dominators they shouldn't be available.

And that makes me think that nobody is using post-dominators
in Graphite...  So, here is a cleanup patch that I will apply later.

Sebastian

Patch

From f87fcafcaeffa6312069d79ec4c2e3937fa428d6 Mon Sep 17 00:00:00 2001
From: Sebastian Pop <sebpop@gmail.com>
Date: Tue, 14 Sep 2010 10:55:58 -0500
Subject: [PATCH] CDI_POST_DOMINATORS are not used in Graphite.

---
 gcc/graphite-clast-to-gimple.c |    1 -
 gcc/sese.h                     |    6 ------
 2 files changed, 0 insertions(+), 7 deletions(-)

diff --git a/gcc/graphite-clast-to-gimple.c b/gcc/graphite-clast-to-gimple.c
index 6899c78..bc75f24 100644
--- a/gcc/graphite-clast-to-gimple.c
+++ b/gcc/graphite-clast-to-gimple.c
@@ -67,7 +67,6 @@  graphite_verify (void)
 #ifdef ENABLE_CHECKING
   verify_loop_structure ();
   verify_dominators (CDI_DOMINATORS);
-  verify_dominators (CDI_POST_DOMINATORS);
   verify_loop_closed_ssa (true);
 #endif
 }
diff --git a/gcc/sese.h b/gcc/sese.h
index f10030c..8277f68 100644
--- a/gcc/sese.h
+++ b/gcc/sese.h
@@ -94,10 +94,6 @@  bb_in_region (basic_block bb, basic_block entry, basic_block exit)
        predecessors of EXIT are dominated by ENTRY.  */
     FOR_EACH_EDGE (e, ei, exit->preds)
       dominated_by_p (CDI_DOMINATORS, e->src, entry);
-
-    /* Check that there are no edges going out of the region: the
-       entry is post-dominated by the exit.  FIXME: This cannot be
-       checked right now as the CDI_POST_DOMINATORS are needed.  */
   }
 #endif
 
@@ -310,9 +306,7 @@  recompute_all_dominators (void)
 {
   mark_irreducible_loops ();
   free_dominance_info (CDI_DOMINATORS);
-  free_dominance_info (CDI_POST_DOMINATORS);
   calculate_dominance_info (CDI_DOMINATORS);
-  calculate_dominance_info (CDI_POST_DOMINATORS);
 }
 
 typedef struct gimple_bb
-- 
1.7.0.4