From patchwork Tue Sep 14 15:52:09 2010 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Joerg Roedel X-Patchwork-Id: 64720 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [199.232.76.165]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id A5C5BB6EDD for ; Wed, 15 Sep 2010 01:53:48 +1000 (EST) Received: from localhost ([127.0.0.1]:46600 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OvXpJ-0001xC-Le for incoming@patchwork.ozlabs.org; Tue, 14 Sep 2010 11:53:45 -0400 Received: from [140.186.70.92] (port=45532 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OvXoB-0001uh-Db for qemu-devel@nongnu.org; Tue, 14 Sep 2010 11:52:36 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1OvXo9-0005LG-K2 for qemu-devel@nongnu.org; Tue, 14 Sep 2010 11:52:35 -0400 Received: from tx2ehsobe003.messaging.microsoft.com ([65.55.88.13]:41246 helo=TX2EHSOBE006.bigfish.com) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OvXo9-0005L6-HH for qemu-devel@nongnu.org; Tue, 14 Sep 2010 11:52:33 -0400 Received: from mail107-tx2-R.bigfish.com (10.9.14.252) by TX2EHSOBE006.bigfish.com (10.9.40.26) with Microsoft SMTP Server id 8.1.340.0; Tue, 14 Sep 2010 15:52:32 +0000 Received: from mail107-tx2 (localhost.localdomain [127.0.0.1]) by mail107-tx2-R.bigfish.com (Postfix) with ESMTP id AC21E568861; Tue, 14 Sep 2010 15:52:32 +0000 (UTC) X-SpamScore: 3 X-BigFish: VS3(zzzz1202hzz8275bh92fbjz32i87h2a8h61h) X-FB-SS: 0, X-FB-DOMAIN-IP-MATCH: fail Received: from mail107-tx2 (localhost.localdomain [127.0.0.1]) by mail107-tx2 (MessageSwitch) id 1284479518482772_13809; Tue, 14 Sep 2010 15:51:58 +0000 (UTC) Received: from TX2EHSMHS044.bigfish.com (unknown [10.9.14.242]) by mail107-tx2.bigfish.com (Postfix) with ESMTP id 3D2A11980056; Tue, 14 Sep 2010 15:51:55 +0000 (UTC) Received: from ausb3extmailp02.amd.com (163.181.251.22) by TX2EHSMHS044.bigfish.com (10.9.99.144) with Microsoft SMTP Server (TLS) id 14.0.482.44; Tue, 14 Sep 2010 15:51:52 +0000 Received: from ausb3twp02.amd.com ([163.181.250.38]) by ausb3extmailp02.amd.com (Switch-3.2.7/Switch-3.2.7) with SMTP id o8EFsSMP004165; Tue, 14 Sep 2010 10:54:42 -0500 X-WSS-ID: 0L8QUPZ-02-APB-02 X-M-MSG: Received: from sausexhtp02.amd.com (sausexhtp02.amd.com [163.181.3.152]) (using TLSv1 with cipher RC4-MD5 (128/128 bits)) (No client certificate requested) by ausb3twp02.amd.com (Tumbleweed MailGate 3.7.2) with ESMTP id 248F8C8A18; Tue, 14 Sep 2010 10:51:35 -0500 (CDT) Received: from storexhtp02.amd.com (172.24.4.4) by sausexhtp02.amd.com (163.181.3.152) with Microsoft SMTP Server (TLS) id 8.3.83.0; Tue, 14 Sep 2010 10:51:40 -0500 Received: from gwo.osrc.amd.com (165.204.16.204) by storexhtp02.amd.com (172.24.4.4) with Microsoft SMTP Server id 8.3.83.0; Tue, 14 Sep 2010 11:51:35 -0400 Received: from lemmy.osrc.amd.com (lemmy.osrc.amd.com [165.204.15.93]) by gwo.osrc.amd.com (Postfix) with ESMTP id EAB7D49C1F9; Tue, 14 Sep 2010 16:51:34 +0100 (BST) Received: by lemmy.osrc.amd.com (Postfix, from userid 1000) id 7A3DBA057A; Tue, 14 Sep 2010 17:52:17 +0200 (CEST) From: Joerg Roedel To: Avi Kivity , Marcelo Tosatti Date: Tue, 14 Sep 2010 17:52:09 +0200 Message-ID: <1284479530-4748-3-git-send-email-joerg.roedel@amd.com> X-Mailer: git-send-email 1.7.0.4 In-Reply-To: <1284479530-4748-1-git-send-email-joerg.roedel@amd.com> References: <1284479530-4748-1-git-send-email-joerg.roedel@amd.com> MIME-Version: 1.0 X-Reverse-DNS: ausb3extmailp02.amd.com X-detected-operating-system: by eggs.gnu.org: Windows 2000 SP4, XP SP1+ Cc: Joerg Roedel , Alexander Graf , kvm@vger.kernel.org, qemu-devel@nongnu.org Subject: [Qemu-devel] [PATCH 2/3] Set cpuid definition to 0 before initializing it X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org This patch cleans the (stack-allocated) cpuid definition to 0 before actually initializing it. Signed-off-by: Joerg Roedel --- target-i386/cpuid.c | 2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/target-i386/cpuid.c b/target-i386/cpuid.c index 04ba8d5..3fcf78f 100644 --- a/target-i386/cpuid.c +++ b/target-i386/cpuid.c @@ -788,6 +788,8 @@ int cpu_x86_register (CPUX86State *env, const char *cpu_model) { x86_def_t def1, *def = &def1; + memset(def, 0, sizeof(*def)); + if (cpu_x86_find_by_name(def, cpu_model) < 0) return -1; if (def->vendor1) {