Patchwork apic: Don't iterate past last used apic

login
register
mail settings
Submitter Alex Williamson
Date Sept. 14, 2010, 3:13 p.m.
Message ID <20100914151230.4223.79925.stgit@s20.home>
Download mbox | patch
Permalink /patch/64716/
State New
Headers show

Comments

Alex Williamson - Sept. 14, 2010, 3:13 p.m.
local_apics are allocated sequentially and never removed, so
we can stop any iterations that go to MAX_APICS as soon as we
hit the first NULL.  Looking at a small guest running a virtio-net
workload with oprofile, this drops apic_get_delivery_bitmask()
from #3 in the profile to down in the noise.

Signed-off-by: Alex Williamson <alex.williamson@redhat.com>
---

 Post 0.13

 hw/apic.c |    4 ++++
 1 files changed, 4 insertions(+), 0 deletions(-)

Patch

diff --git a/hw/apic.c b/hw/apic.c
index d686b51..c07238c 100644
--- a/hw/apic.c
+++ b/hw/apic.c
@@ -449,6 +449,8 @@  static int apic_find_dest(uint8_t dest)
         apic = local_apics[i];
 	if (apic && apic->id == dest)
             return i;
+        if (!apic)
+            break;
     }
 
     return -1;
@@ -484,6 +486,8 @@  static void apic_get_delivery_bitmask(uint32_t *deliver_bitmask,
                         set_bit(deliver_bitmask, i);
                     }
                 }
+            } else {
+                break;
             }
         }
     }