Patchwork [Lucid] (pre-stable) [PATCH] ALSA: hda - Handle pin NID 0x1a, 0x1b and 0x21 on ALC259/269

login
register
mail settings
Submitter David Henningsson
Date Sept. 14, 2010, 2:33 p.m.
Message ID <4C8F87A3.1070503@canonical.com>
Download mbox | patch
Permalink /patch/64704/
State Rejected
Delegated to: Brad Figg
Headers show

Comments

David Henningsson - Sept. 14, 2010, 2:33 p.m.
BugLink: https://launchpad.net/bugs/582199
BugLink: https://launchpad.net/bugs/586418
BugLink: https://launchpad.net/bugs/588031

Backport patches from HEAD in order to enable playback on several 
ALC269. The change went into Maverick over a month ago without any 
regressions so far.

Signed-off-by: David Henningsson <david.henningsson@canonical.com>
Brad Figg - Sept. 16, 2010, 1:16 p.m.
On 09/14/2010 07:33 AM, David Henningsson wrote:
> BugLink: https://launchpad.net/bugs/582199
> BugLink: https://launchpad.net/bugs/586418
> BugLink: https://launchpad.net/bugs/588031
>
> Backport patches from HEAD in order to enable playback on several ALC269. The change went into Maverick over a month ago without any regressions so far.
>
> Signed-off-by: David Henningsson <david.henningsson@canonical.com>
>

Acked-by: Brad Figg <brad.figg@canonical.com>

Very specific and targeted.
Steve Conklin - Sept. 17, 2010, 2:50 p.m.
On Tue, 2010-09-14 at 16:33 +0200, David Henningsson wrote:
> BugLink: https://launchpad.net/bugs/582199
> BugLink: https://launchpad.net/bugs/586418
> BugLink: https://launchpad.net/bugs/588031
> 
> Backport patches from HEAD in order to enable playback on several 
> ALC269. The change went into Maverick over a month ago without any 
> regressions so far.
> 
> Signed-off-by: David Henningsson <david.henningsson@canonical.com>
> 

Ack, contained and sensible
Brad Figg - Sept. 22, 2010, 3:24 p.m.
On 09/14/2010 07:33 AM, David Henningsson wrote:
> BugLink: https://launchpad.net/bugs/582199
> BugLink: https://launchpad.net/bugs/586418
> BugLink: https://launchpad.net/bugs/588031
>
> Backport patches from HEAD in order to enable playback on several ALC269. The change went into Maverick over a month ago without any regressions so far.
>
> Signed-off-by: David Henningsson <david.henningsson@canonical.com>
>

This patch came in via stable and so I took that one instead.

Brad

Patch

From 5c1d0ee246f4a6b8a813b4782817fe754dc032fe Mon Sep 17 00:00:00 2001
From: David Henningsson <david.henningsson@canonical.com>
Date: Mon, 6 Sep 2010 08:36:14 +0200
Subject: [PATCH] ALSA: hda - Handle pin NID 0x1a, 0x1b and 0x21 on ALC259/269

Backport patches from HEAD in order to enable playback on several ALC269.

Signed-off-by: David Henningsson <david.henningsson@canonical.com>
---
 sound/pci/hda/patch_realtek.c |    3 +++
 1 files changed, 3 insertions(+), 0 deletions(-)

diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
index 7b4e74d..4241cc5 100644
--- a/sound/pci/hda/patch_realtek.c
+++ b/sound/pci/hda/patch_realtek.c
@@ -12389,6 +12389,9 @@  static int alc268_new_analog_output(struct alc_spec *spec, hda_nid_t nid,
 		dac = 0x02;
 		break;
 	case 0x15:
+	case 0x1a: /* ALC259/269 only */
+	case 0x1b: /* ALC259/269 only */
+	case 0x21: /* ALC269vb has this pin, too */
 		dac = 0x03;
 		break;
 	default:
-- 
1.7.0.4