Patchwork Fix configure crash (typos)

login
register
mail settings
Submitter Tristan Gingold
Date Sept. 14, 2010, 8:29 a.m.
Message ID <7810EB69-02C1-4D54-B5F2-7BBFC986D863@adacore.com>
Download mbox | patch
Permalink /patch/64679/
State New
Headers show

Comments

Tristan Gingold - Sept. 14, 2010, 8:29 a.m.
Hi,

there are some (obvious ?) typos that make gcc/configure crashes when configuring for a cross-compiler.

Ok to commit ?

Tristan.

2010-09-14  Tristan Gingold  <gingold@adacore.com>

	* configure.ac (plugins): Fix typos.
	* configure: Regenerate.
Tristan Gingold - Sept. 14, 2010, 8:53 a.m.
Matthias,

this looks to be a fallout of your previous patch
( [rfc, patch] PR bootstrap/43847 - fix --enable-plugin for cross builds)

Tristan.

On Sep 14, 2010, at 10:29 AM, Tristan Gingold wrote:

> Hi,
> 
> there are some (obvious ?) typos that make gcc/configure crashes when configuring for a cross-compiler.
> 
> Ok to commit ?
> 
> Tristan.
> 
> 2010-09-14  Tristan Gingold  <gingold@adacore.com>
> 
> 	* configure.ac (plugins): Fix typos.
> 	* configure: Regenerate.
> 
> diff --git a/gcc/configure.ac b/gcc/configure.ac
> index e02dac9..278cc4f 100644
> --- a/gcc/configure.ac
> +++ b/gcc/configure.ac
> @@ -4644,7 +4644,7 @@ case "${host}" in
>   *-*-darwin*)
>     if test x$build = x$host; then
>       export_sym_check="nm${exeext} -g"
> -    elif x$host = x$target; then
> +    elif test x$host = x$target; then
>       export_sym_check="$gcc_cv_nm -g"
>     else
>       export_sym_check=
> @@ -4653,7 +4653,7 @@ case "${host}" in
>   *)
>     if test x$build = x$host; then
>       export_sym_check="objdump${exeext} -T"
> -    elif x$host = x$target; then
> +    elif test x$host = x$target; then
>       export_sym_check="$gcc_cv_objdump -T"
>     else
>       export_sym_check=
>
Matthias Klose - Sept. 14, 2010, 9:07 a.m.
On 14.09.2010 10:53, Tristan Gingold wrote:
> Matthias,
>
> this looks to be a fallout of your previous patch
> ( [rfc, patch] PR bootstrap/43847 - fix --enable-plugin for cross builds)
>
> Tristan.
>
> On Sep 14, 2010, at 10:29 AM, Tristan Gingold wrote:
>
>> Hi,
>>
>> there are some (obvious ?) typos that make gcc/configure crashes when configuring for a cross-compiler.
>>
>> Ok to commit ?

yes, obvious.  Please apply to the 4.5 branch too.

thanks for spotting this, Matthias

Patch

diff --git a/gcc/configure.ac b/gcc/configure.ac
index e02dac9..278cc4f 100644
--- a/gcc/configure.ac
+++ b/gcc/configure.ac
@@ -4644,7 +4644,7 @@  case "${host}" in
   *-*-darwin*)
     if test x$build = x$host; then
       export_sym_check="nm${exeext} -g"
-    elif x$host = x$target; then
+    elif test x$host = x$target; then
       export_sym_check="$gcc_cv_nm -g"
     else
       export_sym_check=
@@ -4653,7 +4653,7 @@  case "${host}" in
   *)
     if test x$build = x$host; then
       export_sym_check="objdump${exeext} -T"
-    elif x$host = x$target; then
+    elif test x$host = x$target; then
       export_sym_check="$gcc_cv_objdump -T"
     else
       export_sym_check=