| Message ID | 1468160051-23957-1-git-send-email-yann.morin.1998@free.fr |
|---|---|
| State | Accepted |
| Headers | show |
Hello Yann, all. On Sun, Jul 10, 2016 at 4:14 PM, Yann E. MORIN <yann.morin.1998@free.fr> wrote: > Fixes: > http://autobuild.buildroot.org/results/d17/d1728c29e90d978405d24bb97f5c8687dc5a6165/ > http://autobuild.buildroot.org/results/2ec/2ecdf0e87a76781b66098d034768fc8de657faaa/ > > Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr> > --- > package/acpica/0001-build-do-not-use-Werror.patch | 62 +++++++++++++++++++++++ > 1 file changed, 62 insertions(+) > create mode 100644 package/acpica/0001-build-do-not-use-Werror.patch > > diff --git a/package/acpica/0001-build-do-not-use-Werror.patch b/package/acpica/0001-build-do-not-use-Werror.patch > new file mode 100644 > index 0000000..4ccb4d4 > --- /dev/null > +++ b/package/acpica/0001-build-do-not-use-Werror.patch > @@ -0,0 +1,62 @@ > +From 9382ae2431d2962c430e7149302c8690f5bc159c Mon Sep 17 00:00:00 2001 > +From: "Yann E. MORIN" <yann.morin.1998@free.fr> > +Date: Sun, 10 Jul 2016 15:06:15 +0200 > +Subject: [PATCH] build: do not use -Werror > + > +Warnings come and go with various compiler versions, so using -Werror is > +prone to cause build failures with various compiler versions, especially > +newer versions that introduce new warnings. > + > +Remove use of -Werror. > + > +Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr> > +--- > + generate/unix/Makefile.config | 1 - > + generate/unix/iasl/Makefile | 12 ++++++------ > + 2 files changed, 6 insertions(+), 7 deletions(-) > + > +diff --git a/generate/unix/Makefile.config b/generate/unix/Makefile.config > +index da0f61d..1476e27 100644 > +--- a/generate/unix/Makefile.config > ++++ b/generate/unix/Makefile.config > +@@ -185,7 +185,6 @@ CWARNINGFLAGS = \ > + -Wall\ > + -Wbad-function-cast\ > + -Wdeclaration-after-statement\ > +- -Werror\ > + -Wformat=2\ > + -Wmissing-declarations\ > + -Wmissing-prototypes\ > +diff --git a/generate/unix/iasl/Makefile b/generate/unix/iasl/Makefile > +index a3759cc..c2dc8f0 100644 > +--- a/generate/unix/iasl/Makefile > ++++ b/generate/unix/iasl/Makefile > +@@ -320,19 +320,19 @@ $(OBJDIR)/prparserparse.c $(OBJDIR)/prparser.y.h : $(ASL_COMPILER)/prparse > + # by the utilities above and they are not necessarily ANSI C, etc. > + # > + $(OBJDIR)/aslcompilerlex.o : $(OBJDIR)/aslcompilerlex.c > +- $(CC) -c $(CFLAGS) -Wall -Werror -o$@ $< > ++ $(CC) -c $(CFLAGS) -Wall -o$@ $< > + > + $(OBJDIR)/aslcompilerparse.o : $(OBJDIR)/aslcompilerparse.c > +- $(CC) -c $(CFLAGS) -Wall -Werror -o$@ $< > ++ $(CC) -c $(CFLAGS) -Wall -o$@ $< > + > + $(OBJDIR)/dtparserlex.o : $(OBJDIR)/dtparserlex.c > +- $(CC) -c $(CFLAGS) -Wall -Werror -o$@ $< > ++ $(CC) -c $(CFLAGS) -Wall -o$@ $< > + > + $(OBJDIR)/dtparserparse.o : $(OBJDIR)/dtparserparse.c > +- $(CC) -c $(CFLAGS) -Wall -Werror -o$@ $< > ++ $(CC) -c $(CFLAGS) -Wall -o$@ $< > + > + $(OBJDIR)/prparserlex.o : $(OBJDIR)/prparserlex.c > +- $(CC) -c $(CFLAGS) -Wall -Werror -o$@ $< > ++ $(CC) -c $(CFLAGS) -Wall -o$@ $< > + > + $(OBJDIR)/prparserparse.o : $(OBJDIR)/prparserparse.c > +- $(CC) -c $(CFLAGS) -Wall -Werror -o$@ $< > ++ $(CC) -c $(CFLAGS) -Wall -o$@ $< > +-- > +2.7.4 > + I was taking a look at this issue before this patch, and it seems that of these errors with acpica are the same as one that has happened before for mips64, as in fixed by: https://patchwork.ozlabs.org/patch/521624/ I'm trying a similar patch to that to fix this error in acpica. In case you can wait a bit for that, maybe fixing it in the same way as micropython would be a patch easier to upstream. Thanks, Érico
Enrico, All, On 2016-07-10 18:37 +0200, Erico Nunes spake thusly: > On Sun, Jul 10, 2016 at 4:14 PM, Yann E. MORIN <yann.morin.1998@free.fr> wrote: > > Fixes: > > http://autobuild.buildroot.org/results/d17/d1728c29e90d978405d24bb97f5c8687dc5a6165/ > > http://autobuild.buildroot.org/results/2ec/2ecdf0e87a76781b66098d034768fc8de657faaa/ > > > > Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr> > > --- > > package/acpica/0001-build-do-not-use-Werror.patch | 62 +++++++++++++++++++++++ > > 1 file changed, 62 insertions(+) > > create mode 100644 package/acpica/0001-build-do-not-use-Werror.patch > > > > diff --git a/package/acpica/0001-build-do-not-use-Werror.patch b/package/acpica/0001-build-do-not-use-Werror.patch > > new file mode 100644 > > index 0000000..4ccb4d4 > > --- /dev/null > > +++ b/package/acpica/0001-build-do-not-use-Werror.patch > > @@ -0,0 +1,62 @@ > > +From 9382ae2431d2962c430e7149302c8690f5bc159c Mon Sep 17 00:00:00 2001 > > +From: "Yann E. MORIN" <yann.morin.1998@free.fr> > > +Date: Sun, 10 Jul 2016 15:06:15 +0200 > > +Subject: [PATCH] build: do not use -Werror > > + > > +Warnings come and go with various compiler versions, so using -Werror is > > +prone to cause build failures with various compiler versions, especially > > +newer versions that introduce new warnings. > > + > > +Remove use of -Werror. > > + > > +Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr> > > +--- [--SNIP--] > I was taking a look at this issue before this patch, and it seems that > of these errors with acpica are the same as one that has happened > before for mips64, as in fixed by: > https://patchwork.ozlabs.org/patch/521624/ > > I'm trying a similar patch to that to fix this error in acpica. -Werror is a *development* opiton; it should not be used in a *release*. Fact is, warnings are added with new versions of the compiler, so when we update to a newer version and keep -Wall -Werror, and the code hits such a new warning, we'd still get build issues for code that might even be correct with an overly pessimistic compiler. > In case you can wait a bit for that, maybe fixing it in the same way > as micropython would be a patch easier to upstream. Even if you manage to fix those very warnings, I still believe this patch to be valid and applied. Granted, we could turn it into something that is acceptable upstream, to only enable (or disable) use of -Werror at will. Regards, Yann E. MORIN.
Hello, On Sun, 10 Jul 2016 16:14:11 +0200, Yann E. MORIN wrote: > Fixes: > http://autobuild.buildroot.org/results/d17/d1728c29e90d978405d24bb97f5c8687dc5a6165/ > http://autobuild.buildroot.org/results/2ec/2ecdf0e87a76781b66098d034768fc8de657faaa/ > > Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr> > --- > package/acpica/0001-build-do-not-use-Werror.patch | 62 +++++++++++++++++++++++ > 1 file changed, 62 insertions(+) > create mode 100644 package/acpica/0001-build-do-not-use-Werror.patch Applied to master, thanks. Thomas
diff --git a/package/acpica/0001-build-do-not-use-Werror.patch b/package/acpica/0001-build-do-not-use-Werror.patch new file mode 100644 index 0000000..4ccb4d4 --- /dev/null +++ b/package/acpica/0001-build-do-not-use-Werror.patch @@ -0,0 +1,62 @@ +From 9382ae2431d2962c430e7149302c8690f5bc159c Mon Sep 17 00:00:00 2001 +From: "Yann E. MORIN" <yann.morin.1998@free.fr> +Date: Sun, 10 Jul 2016 15:06:15 +0200 +Subject: [PATCH] build: do not use -Werror + +Warnings come and go with various compiler versions, so using -Werror is +prone to cause build failures with various compiler versions, especially +newer versions that introduce new warnings. + +Remove use of -Werror. + +Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr> +--- + generate/unix/Makefile.config | 1 - + generate/unix/iasl/Makefile | 12 ++++++------ + 2 files changed, 6 insertions(+), 7 deletions(-) + +diff --git a/generate/unix/Makefile.config b/generate/unix/Makefile.config +index da0f61d..1476e27 100644 +--- a/generate/unix/Makefile.config ++++ b/generate/unix/Makefile.config +@@ -185,7 +185,6 @@ CWARNINGFLAGS = \ + -Wall\ + -Wbad-function-cast\ + -Wdeclaration-after-statement\ +- -Werror\ + -Wformat=2\ + -Wmissing-declarations\ + -Wmissing-prototypes\ +diff --git a/generate/unix/iasl/Makefile b/generate/unix/iasl/Makefile +index a3759cc..c2dc8f0 100644 +--- a/generate/unix/iasl/Makefile ++++ b/generate/unix/iasl/Makefile +@@ -320,19 +320,19 @@ $(OBJDIR)/prparserparse.c $(OBJDIR)/prparser.y.h : $(ASL_COMPILER)/prparse + # by the utilities above and they are not necessarily ANSI C, etc. + # + $(OBJDIR)/aslcompilerlex.o : $(OBJDIR)/aslcompilerlex.c +- $(CC) -c $(CFLAGS) -Wall -Werror -o$@ $< ++ $(CC) -c $(CFLAGS) -Wall -o$@ $< + + $(OBJDIR)/aslcompilerparse.o : $(OBJDIR)/aslcompilerparse.c +- $(CC) -c $(CFLAGS) -Wall -Werror -o$@ $< ++ $(CC) -c $(CFLAGS) -Wall -o$@ $< + + $(OBJDIR)/dtparserlex.o : $(OBJDIR)/dtparserlex.c +- $(CC) -c $(CFLAGS) -Wall -Werror -o$@ $< ++ $(CC) -c $(CFLAGS) -Wall -o$@ $< + + $(OBJDIR)/dtparserparse.o : $(OBJDIR)/dtparserparse.c +- $(CC) -c $(CFLAGS) -Wall -Werror -o$@ $< ++ $(CC) -c $(CFLAGS) -Wall -o$@ $< + + $(OBJDIR)/prparserlex.o : $(OBJDIR)/prparserlex.c +- $(CC) -c $(CFLAGS) -Wall -Werror -o$@ $< ++ $(CC) -c $(CFLAGS) -Wall -o$@ $< + + $(OBJDIR)/prparserparse.o : $(OBJDIR)/prparserparse.c +- $(CC) -c $(CFLAGS) -Wall -Werror -o$@ $< ++ $(CC) -c $(CFLAGS) -Wall -o$@ $< +-- +2.7.4 +
Fixes: http://autobuild.buildroot.org/results/d17/d1728c29e90d978405d24bb97f5c8687dc5a6165/ http://autobuild.buildroot.org/results/2ec/2ecdf0e87a76781b66098d034768fc8de657faaa/ Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr> --- package/acpica/0001-build-do-not-use-Werror.patch | 62 +++++++++++++++++++++++ 1 file changed, 62 insertions(+) create mode 100644 package/acpica/0001-build-do-not-use-Werror.patch