Patchwork linux-user: mmap_reserve() not controlled by RESERVED_VA

login
register
mail settings
Submitter amateur
Date Sept. 14, 2010, 5:22 a.m.
Message ID <20100914052234.GA10008@localdomain>
Download mbox | patch
Permalink /patch/64672/
State New
Headers show

Comments

amateur - Sept. 14, 2010, 5:22 a.m.
mmap_reserve() should be called only when RESERVED_VA is enabled.
Otherwise, unmaped virtual address space will never be reusable. This
bug will exhaust virtual address space in extreme conditions.

Patch

diff --git a/linux-user/mmap.c b/linux-user/mmap.c
index e10a6ef..50748a2 100644
--- a/linux-user/mmap.c
+++ b/linux-user/mmap.c
@@ -697,7 +697,9 @@  abi_long target_mremap(abi_ulong old_addr, abi_ulong old_size,
                                          old_size, new_size,
                                          flags | MREMAP_FIXED,
                                          g2h(mmap_start));
-            mmap_reserve(old_addr, old_size);
+            if ( RESERVED_VA ) {
+                mmap_reserve(old_addr, old_size);
+            }
         }
     } else {
         int prot = 0;