Patchwork PATCH: Fix bootstrap on x86

login
register
mail settings
Submitter H.J. Lu
Date Sept. 13, 2010, 10:34 p.m.
Message ID <AANLkTi=Ptjm5joYSDBFUb7JjSTQX6N3uvuuD965+pdxB@mail.gmail.com>
Download mbox | patch
Permalink /patch/64663/
State New
Headers show

Comments

H.J. Lu - Sept. 13, 2010, 10:34 p.m.
On Mon, Sep 13, 2010 at 3:27 PM, Nathan Froyd <froydnj@codesourcery.com> wrote:
> On Mon, Sep 13, 2010 at 03:16:17PM -0700, H.J. Lu wrote:
>> Here is a patch.  Bootstrapped on Linux/x86-64.  Compiled cc1 for
>> ARM, PowerPC. MIPS and Sparc.  OK to install?
>
> If this patch eliminates all instances of UNITS_PER_SIMD_WORD, you
> should also poison that identifier in system.h.
>

Here is the additional patch.
Nathan Froyd - Sept. 14, 2010, 1:20 p.m.
On Mon, Sep 13, 2010 at 03:34:43PM -0700, H.J. Lu wrote:
> On Mon, Sep 13, 2010 at 3:27 PM, Nathan Froyd <froydnj@codesourcery.com> wrote:
> > If this patch eliminates all instances of UNITS_PER_SIMD_WORD, you
> > should also poison that identifier in system.h.
> 
> Here is the additional patch.

A minor nit, but it'd be nice if the identifier was in the poison pragma
headed by:

/* Old target macros that have moved to the target hooks structure.  */

earlier in the file.

-Nathan

Patch

diff --git a/gcc/system.h b/gcc/system.h
index a5cfaba..023ced4 100644
--- a/gcc/system.h
+++ b/gcc/system.h
@@ -783,7 +783,7 @@  extern void fancy_abort (const char *, int, const
char *) ATTRIBUTE_NORETURN;
   LANG_HOOKS_MISSING_ARGUMENT

 /* Miscellaneous macros that are no longer used.  */
- #pragma GCC poison USE_MAPPED_LOCATION
+ #pragma GCC poison USE_MAPPED_LOCATION UNITS_PER_SIMD_WORD

 /* Libiberty macros that are no longer used in GCC.  */