From patchwork Mon Sep 13 20:02:36 2010 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stefan Weil X-Patchwork-Id: 64643 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [199.232.76.165]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id 15C4FB70A3 for ; Tue, 14 Sep 2010 06:04:13 +1000 (EST) Received: from localhost ([127.0.0.1]:58615 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OvFG6-0003V3-9o for incoming@patchwork.ozlabs.org; Mon, 13 Sep 2010 16:04:10 -0400 Received: from [140.186.70.92] (port=47801 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OvFEl-0003TY-4z for qemu-devel@nongnu.org; Mon, 13 Sep 2010 16:02:48 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1OvFEj-0004b0-Qc for qemu-devel@nongnu.org; Mon, 13 Sep 2010 16:02:46 -0400 Received: from moutng.kundenserver.de ([212.227.126.186]:59587) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OvFEj-0004an-CJ for qemu-devel@nongnu.org; Mon, 13 Sep 2010 16:02:45 -0400 Received: from flocke.weilnetz.de (p54ADB004.dip.t-dialin.net [84.173.176.4]) by mrelayeu.kundenserver.de (node=mrbap2) with ESMTP (Nemesis) id 0M0KWj-1OaZ3f2xGH-00uweQ; Mon, 13 Sep 2010 22:02:42 +0200 Received: from stefan by flocke.weilnetz.de with local (Exim 4.72) (envelope-from ) id 1OvFEf-0004VA-Co; Mon, 13 Sep 2010 22:02:41 +0200 From: Stefan Weil To: QEMU Developers Date: Mon, 13 Sep 2010 22:02:36 +0200 Message-Id: <1284408157-17276-1-git-send-email-weil@mail.berlios.de> X-Mailer: git-send-email 1.7.1 In-Reply-To: <1284187585-20953-2-git-send-email-weil@mail.berlios.de> References: <1284187585-20953-2-git-send-email-weil@mail.berlios.de> X-Provags-ID: V02:K0:4vW+lVgBl2WBQ8CG/4yaXrCSGu3MXzHq/AonjAEpfHO BEmBgCgM2acKBZDgmllshvLjQcZBG7dana+ii5HR+RAoFyNmDG 9OUl3jRBxh8xU0aKIJ4WEW/c/BnACxNAnOcmY0kWZ/jtimyAan 9qrTUABZ4AZFhNCF9K8J8NHV2gvbMNM1sluf+UywiolRx1YJff Q92hl/3wcWN9svEhVQmL2ps9hJ+e4zvjh7xh8SbrIlsrFoZzIh TuOc1DhpRhVFp X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. Cc: Subject: [Qemu-devel] [PATCH 1/2] Add support for gcc format attribute gnu_printf X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Since version 4.4.x, gcc supports additional format attributes. __attribute__ ((format (gnu_printf, 1, 2))) should be used instead of __attribute__ ((format (printf, 1, 2)) because QEMU always uses standard format strings (even with mingw32). For older compilers, we simply define gnu_printf = printf, so they work with the new format attribute, too. Signed-off-by: Stefan Weil --- configure | 11 +++++++++++ 1 files changed, 11 insertions(+), 0 deletions(-) diff --git a/configure b/configure index 4061cb7..1300879 100755 --- a/configure +++ b/configure @@ -148,6 +148,17 @@ for flag in $gcc_flags; do fi done +# Check gnu_printf (supported by gcc >= 4.4.x). +cat > $TMPC << EOF +static void test(const char *format, ...) + __attribute__ ((format (gnu_printf, 1, 2))); +static void test(const char *format, ...) {} +int main(void) { test("\n"); return 0; } +EOF +if ! compile_prog "-Werror" ""; then + QEMU_CFLAGS="-Dgnu_printf=printf $QEMU_CFLAGS" +fi + # check that the C compiler works. cat > $TMPC <