diff mbox

klog: data.json: Add klog checking for errors from drivers/acpi/pci_mcfg.c

Message ID 1467900440-15329-1-git-send-email-colin.king@canonical.com
State Accepted
Headers show

Commit Message

Colin Ian King July 7, 2016, 2:07 p.m. UTC
From: Colin Ian King <colin.king@canonical.com>

Add more klog error message checking for ACPI PCI MCFG tables.

Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
 data/klog.json | 7 +++++++
 1 file changed, 7 insertions(+)

Comments

Alex Hung July 11, 2016, 2:57 a.m. UTC | #1
On 2016-07-07 10:07 PM, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> Add more klog error message checking for ACPI PCI MCFG tables.
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
>   data/klog.json | 7 +++++++
>   1 file changed, 7 insertions(+)
>
> diff --git a/data/klog.json b/data/klog.json
> index ca4d081..90be36f 100644
> --- a/data/klog.json
> +++ b/data/klog.json
> @@ -3,6 +3,13 @@
>    [
>     {
>      "compare_mode": "string",
> +   "log_level": "LOG_LEVEL_CRITICAL",
> +   "pattern": "Failed to parse MCFG",
> +   "advice": "The ACPI MCFG (PCI Express memory mapped configuration space base address Description Table) cannot be parsed (due to an error in the table) and so PCIe memory mapped configuration has failed - expect PCIe devices not to function",
> +   "label": "KlogAcpiMcfgParseFailed"
> +  },
> +  {
> +   "compare_mode": "string",
>      "log_level": "LOG_LEVEL_LOW",
>      "pattern": "no secondary bus range in _CRS",
>      "advice": "ACPI evaluated a _CRS (Current Resource Setting) object to determine the start and end of of a PCI downsteam bus range and did not find the end address, so an end address of 0xff is being assumed",
>


Acked-by: Alex Hung <alex.hung@canonical.com>
Ivan Hu July 12, 2016, 9:06 a.m. UTC | #2
On 2016年07月07日 22:07, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> Add more klog error message checking for ACPI PCI MCFG tables.
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
>   data/klog.json | 7 +++++++
>   1 file changed, 7 insertions(+)
>
> diff --git a/data/klog.json b/data/klog.json
> index ca4d081..90be36f 100644
> --- a/data/klog.json
> +++ b/data/klog.json
> @@ -3,6 +3,13 @@
>    [
>     {
>      "compare_mode": "string",
> +   "log_level": "LOG_LEVEL_CRITICAL",
> +   "pattern": "Failed to parse MCFG",
> +   "advice": "The ACPI MCFG (PCI Express memory mapped configuration space base address Description Table) cannot be parsed (due to an error in the table) and so PCIe memory mapped configuration has failed - expect PCIe devices not to function",
> +   "label": "KlogAcpiMcfgParseFailed"
> +  },
> +  {
> +   "compare_mode": "string",
>      "log_level": "LOG_LEVEL_LOW",
>      "pattern": "no secondary bus range in _CRS",
>      "advice": "ACPI evaluated a _CRS (Current Resource Setting) object to determine the start and end of of a PCI downsteam bus range and did not find the end address, so an end address of 0xff is being assumed",

Acked-by: Ivan Hu <ivan.hu@canonical.com>
diff mbox

Patch

diff --git a/data/klog.json b/data/klog.json
index ca4d081..90be36f 100644
--- a/data/klog.json
+++ b/data/klog.json
@@ -3,6 +3,13 @@ 
  [ 
   {
    "compare_mode": "string",
+   "log_level": "LOG_LEVEL_CRITICAL",
+   "pattern": "Failed to parse MCFG",
+   "advice": "The ACPI MCFG (PCI Express memory mapped configuration space base address Description Table) cannot be parsed (due to an error in the table) and so PCIe memory mapped configuration has failed - expect PCIe devices not to function",
+   "label": "KlogAcpiMcfgParseFailed"
+  },
+  {
+   "compare_mode": "string",
    "log_level": "LOG_LEVEL_LOW",
    "pattern": "no secondary bus range in _CRS",
    "advice": "ACPI evaluated a _CRS (Current Resource Setting) object to determine the start and end of of a PCI downsteam bus range and did not find the end address, so an end address of 0xff is being assumed",