diff mbox

klog: data.json: Add klog checking for errors from drivers/acpi/nfit.c

Message ID 1467897127-12013-1-git-send-email-colin.king@canonical.com
State Accepted
Headers show

Commit Message

Colin Ian King July 7, 2016, 1:12 p.m. UTC
From: Colin Ian King <colin.king@canonical.com>

Add more klog error message checking for ACPI NFIT kernel messages

Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
 data/klog.json | 14 ++++++++++++++
 1 file changed, 14 insertions(+)

Comments

Alex Hung July 11, 2016, 2:56 a.m. UTC | #1
On 2016-07-07 09:12 PM, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> Add more klog error message checking for ACPI NFIT kernel messages
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
>   data/klog.json | 14 ++++++++++++++
>   1 file changed, 14 insertions(+)
>
> diff --git a/data/klog.json b/data/klog.json
> index 28ab84b..ab8a90e 100644
> --- a/data/klog.json
> +++ b/data/klog.json
> @@ -2,6 +2,20 @@
>    "firmware_error_warning_patterns":
>    [
>     {
> +   "compare_mode": "regex",
> +   "log_level": "LOG_LEVEL_HIGH",
> +   "pattern": "found a zero length table .* parsing nfit",
> +   "advice": "An ACPI NVDIMM Firmware Interface Table (NFIT) header indicates a NFIT table has an invalid zero size and has been ignored. This will lead to a NVDIMM not being recognised by the system",
> +   "label": "KlogAcpiNfitZereSize"
> +  },
> +  {
> +   "compare_mode": "regex",
> +   "log_level": "LOG_LEVEL_HIGH",
> +   "pattern": "SPA .* missing DCR",
> +   "advice": "An ACPI NVDIMM Firmware Interface Table (NFIT) Control Region Structure (DCR) is missing a System Physical Address (SPA), NFIT table is incorrect.",
> +   "label": "KlogAcpiNfitDcrSpaError"
> +  },
> +  {
>      "compare_mode": "string",
>      "log_level": "LOG_LEVEL_HIGH",
>      "pattern": "Error installing CMOS-RTC region handler",
>


Acked-by: Alex Hung <alex.hung@canonical.com>
Ivan Hu July 12, 2016, 9:05 a.m. UTC | #2
On 2016年07月07日 21:12, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> Add more klog error message checking for ACPI NFIT kernel messages
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
>   data/klog.json | 14 ++++++++++++++
>   1 file changed, 14 insertions(+)
>
> diff --git a/data/klog.json b/data/klog.json
> index 28ab84b..ab8a90e 100644
> --- a/data/klog.json
> +++ b/data/klog.json
> @@ -2,6 +2,20 @@
>    "firmware_error_warning_patterns":
>    [
>     {
> +   "compare_mode": "regex",
> +   "log_level": "LOG_LEVEL_HIGH",
> +   "pattern": "found a zero length table .* parsing nfit",
> +   "advice": "An ACPI NVDIMM Firmware Interface Table (NFIT) header indicates a NFIT table has an invalid zero size and has been ignored. This will lead to a NVDIMM not being recognised by the system",
> +   "label": "KlogAcpiNfitZereSize"
> +  },
> +  {
> +   "compare_mode": "regex",
> +   "log_level": "LOG_LEVEL_HIGH",
> +   "pattern": "SPA .* missing DCR",
> +   "advice": "An ACPI NVDIMM Firmware Interface Table (NFIT) Control Region Structure (DCR) is missing a System Physical Address (SPA), NFIT table is incorrect.",
> +   "label": "KlogAcpiNfitDcrSpaError"
> +  },
> +  {
>      "compare_mode": "string",
>      "log_level": "LOG_LEVEL_HIGH",
>      "pattern": "Error installing CMOS-RTC region handler",

Acked-by: Ivan Hu <ivan.hu@canonical.com>
diff mbox

Patch

diff --git a/data/klog.json b/data/klog.json
index 28ab84b..ab8a90e 100644
--- a/data/klog.json
+++ b/data/klog.json
@@ -2,6 +2,20 @@ 
  "firmware_error_warning_patterns":
  [ 
   {
+   "compare_mode": "regex",
+   "log_level": "LOG_LEVEL_HIGH",
+   "pattern": "found a zero length table .* parsing nfit",
+   "advice": "An ACPI NVDIMM Firmware Interface Table (NFIT) header indicates a NFIT table has an invalid zero size and has been ignored. This will lead to a NVDIMM not being recognised by the system",
+   "label": "KlogAcpiNfitZereSize"
+  },
+  {
+   "compare_mode": "regex",
+   "log_level": "LOG_LEVEL_HIGH",
+   "pattern": "SPA .* missing DCR",
+   "advice": "An ACPI NVDIMM Firmware Interface Table (NFIT) Control Region Structure (DCR) is missing a System Physical Address (SPA), NFIT table is incorrect.",
+   "label": "KlogAcpiNfitDcrSpaError"
+  },
+  {
    "compare_mode": "string",
    "log_level": "LOG_LEVEL_HIGH",
    "pattern": "Error installing CMOS-RTC region handler",