Patchwork old ubi-utils: drop -Werror

login
register
mail settings
Submitter Mike Frysinger
Date Sept. 12, 2010, 3:48 a.m.
Message ID <1284263293-31064-1-git-send-email-vapier@gentoo.org>
Download mbox | patch
Permalink /patch/64536/
State Accepted, archived
Headers show

Comments

Mike Frysinger - Sept. 12, 2010, 3:48 a.m.
Considering this is marked as "old" which is synonymous with "dead",
having the dir cause build failures because of warnings makes no
sense.  So drop the -Werror usage.

Signed-off-by: Mike Frysinger <vapier@gentoo.org>
---
 ubi-utils/old-utils/Makefile |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
Artem Bityutskiy - Sept. 12, 2010, 8:06 a.m.
On Sat, 2010-09-11 at 23:48 -0400, Mike Frysinger wrote:
> Considering this is marked as "old" which is synonymous with "dead",
> having the dir cause build failures because of warnings makes no
> sense.  So drop the -Werror usage.
> 
> Signed-off-by: Mike Frysinger <vapier@gentoo.org>

I wonder if people still use them and may be we can just remove them?
Added Frank and Andreas who are the potential users of the old
ubi-utils.
Artem Bityutskiy - Sept. 12, 2010, 8:09 a.m.
On Sat, 2010-09-11 at 23:48 -0400, Mike Frysinger wrote:
> Considering this is marked as "old" which is synonymous with "dead",
> having the dir cause build failures because of warnings makes no
> sense.  So drop the -Werror usage.
> 
> Signed-off-by: Mike Frysinger <vapier@gentoo.org>

Pushed, thanks.
Artem Bityutskiy - Sept. 28, 2010, 7:49 a.m.
On Sun, 2010-09-12 at 11:06 +0300, Artem Bityutskiy wrote:
> On Sat, 2010-09-11 at 23:48 -0400, Mike Frysinger wrote:
> > Considering this is marked as "old" which is synonymous with "dead",
> > having the dir cause build failures because of warnings makes no
> > sense.  So drop the -Werror usage.
> > 
> > Signed-off-by: Mike Frysinger <vapier@gentoo.org>
> 
> I wonder if people still use them and may be we can just remove them?
> Added Frank and Andreas who are the potential users of the old
> ubi-utils.

OK, let's remove the old utilities.
Mike Frysinger - Sept. 28, 2010, 7:58 a.m.
On Tue, Sep 28, 2010 at 03:49, Artem Bityutskiy wrote:
> On Sun, 2010-09-12 at 11:06 +0300, Artem Bityutskiy wrote:
>> On Sat, 2010-09-11 at 23:48 -0400, Mike Frysinger wrote:
>> > Considering this is marked as "old" which is synonymous with "dead",
>> > having the dir cause build failures because of warnings makes no
>> > sense.  So drop the -Werror usage.
>> >
>> > Signed-off-by: Mike Frysinger <vapier@gentoo.org>
>>
>> I wonder if people still use them and may be we can just remove them?
>> Added Frank and Andreas who are the potential users of the old
>> ubi-utils.
>
> OK, let's remove the old utilities.

i'm assuming you'll take care of this and dont need me to send a patch
-mike
Artem Bityutskiy - Sept. 28, 2010, 8:04 a.m.
On Tue, 2010-09-28 at 03:58 -0400, Mike Frysinger wrote:
> On Tue, Sep 28, 2010 at 03:49, Artem Bityutskiy wrote:
> > On Sun, 2010-09-12 at 11:06 +0300, Artem Bityutskiy wrote:
> >> On Sat, 2010-09-11 at 23:48 -0400, Mike Frysinger wrote:
> >> > Considering this is marked as "old" which is synonymous with "dead",
> >> > having the dir cause build failures because of warnings makes no
> >> > sense.  So drop the -Werror usage.
> >> >
> >> > Signed-off-by: Mike Frysinger <vapier@gentoo.org>
> >>
> >> I wonder if people still use them and may be we can just remove them?
> >> Added Frank and Andreas who are the potential users of the old
> >> ubi-utils.
> >
> > OK, let's remove the old utilities.
> 
> i'm assuming you'll take care of this and dont need me to send a patch

Right, I've just pushed the changes. That e-mail was about letting
everyone know, sorry for confusing you.

Patch

diff --git a/ubi-utils/old-utils/Makefile b/ubi-utils/old-utils/Makefile
index acdb31a..6df7c06 100644
--- a/ubi-utils/old-utils/Makefile
+++ b/ubi-utils/old-utils/Makefile
@@ -4,7 +4,7 @@ 
 
 KERNELHDR := ../../include
 
-CFLAGS ?= -O2 -g -Werror
+CFLAGS ?= -O2 -g
 CPPFLAGS := -I./inc -I./src -I$(KERNELHDR) \
 	-std=gnu99 -DPACKAGE_VERSION=\"1.0\" $(CPPFLAGS)