Patchwork powerpc: Avoid TLB related log spamming

login
register
mail settings
Submitter Edgar Iglesias
Date Sept. 11, 2010, 12:38 p.m.
Message ID <1284208737-16361-1-git-send-email-edgar.iglesias@gmail.com>
Download mbox | patch
Permalink /patch/64512/
State New
Headers show

Comments

Edgar Iglesias - Sept. 11, 2010, 12:38 p.m.
Invalid TLB entries are normal and should not spam the log.

Signed-off-by: Edgar E. Iglesias <edgar.iglesias@gmail.com>
---
 target-ppc/helper.c |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)
Alexander Graf - Sept. 11, 2010, 1:19 p.m.
On 11.09.2010, at 14:38, Edgar E. Iglesias wrote:

> Invalid TLB entries are normal and should not spam the log.

Thanks, applied to my ppc tree:

  git://repo.or.cz/qemu/agraf.git ppc-next


Alex
Edgar Iglesias - Sept. 11, 2010, 1:25 p.m.
On Sat, Sep 11, 2010 at 03:19:57PM +0200, Alexander Graf wrote:
>    On 11.09.2010, at 14:38, Edgar E. Iglesias wrote:
> 
>    Invalid TLB entries are normal and should not spam the log.
> 
>    Thanks, applied to my ppc tree:
>      [1]git://repo.or.cz/qemu/agraf.git ppc-next
>    Alex

Thanks Alex,

I applied this to upstream as a small obvious patch. The soon to
come MMU patches should definitely go through your tree though.

Cheers,
Edgar

Patch

diff --git a/target-ppc/helper.c b/target-ppc/helper.c
index d342b09..a7ec1f4 100644
--- a/target-ppc/helper.c
+++ b/target-ppc/helper.c
@@ -1050,7 +1050,6 @@  static inline int ppcemb_tlb_check(CPUState *env, ppcemb_tlb_t *tlb,
 
     /* Check valid flag */
     if (!(tlb->prot & PAGE_VALID)) {
-        qemu_log("%s: TLB %d not valid\n", __func__, i);
         return -1;
     }
     mask = ~(tlb->size - 1);