Patchwork [13/15] Use a few more gcc warning flags

login
register
mail settings
Submitter Blue Swirl
Date Sept. 10, 2010, 9 p.m.
Message ID <AANLkTi=T+FTc+Tv0jbqRPJ=ezy+dhf6AnQfVQNTjdjH0@mail.gmail.com>
Download mbox | patch
Permalink /patch/64472/
State New
Headers show

Comments

Blue Swirl - Sept. 10, 2010, 9 p.m.
If the compiler supports the following warning flags, use them:

-Wformat-security -Wformat-y2k -Winit-self -Wignored-qualifiers
-Wmissing-include-dirs -Wclobbered

Currently, these flags don't produce any warnings.

Signed-off-by: Blue Swirl <blauwirbel@gmail.com>
---
 configure |    5 ++++-
 1 files changed, 4 insertions(+), 1 deletions(-)
Blue Swirl - Sept. 20, 2010, 8:45 p.m.
On Fri, Sep 10, 2010 at 9:00 PM, Blue Swirl <blauwirbel@gmail.com> wrote:
> If the compiler supports the following warning flags, use them:
>
> -Wformat-security -Wformat-y2k -Winit-self -Wignored-qualifiers
> -Wmissing-include-dirs -Wclobbered
>
> Currently, these flags don't produce any warnings.

I noticed that in fact -Wclobbered produced warnings, so I removed the
flag before committing. Perhaps those warnings should be investigated
further.

Patch

diff --git a/configure b/configure
index 29d3548..7dc0f77 100755
--- a/configure
+++ b/configure
@@ -138,7 +138,10 @@  QEMU_CFLAGS="-D_FORTIFY_SOURCE=2 $QEMU_CFLAGS"
 QEMU_CFLAGS="-I. -I\$(SRC_PATH) $QEMU_CFLAGS"
 LDFLAGS="-g $LDFLAGS"

-gcc_flags="-Wold-style-declaration -Wold-style-definition
-Wtype-limits -fstack-protector-all"
+gcc_flags="-Wold-style-declaration -Wold-style-definition -Wtype-limits"
+gcc_flags="-Wformat-security -Wformat-y2k -Winit-self
-Wignored-qualifiers $gcc_flags"
+gcc_flags="-Wmissing-include-dirs -Wclobbered $gcc_flags"
+gcc_flags="-fstack-protector-all $gcc_flags"
 cat > $TMPC << EOF
 int main(void) { return 0; }
 EOF