diff mbox

[05/83,v2] package/gpsd: use 'menuconfig' instead of 'config'+'menu'

Message ID 91237ef88ea3f2dab925981525ebe188fd9d44a3.1467624132.git.yann.morin.1998@free.fr
State Accepted
Commit 0d35008fc6ab944b158a77d068b62f69c1b566a6
Headers show

Commit Message

Yann E. MORIN July 4, 2016, 9:24 a.m. UTC 
Since there were multiple sub-menus, their prompts are turned into
comments.

Some option were missing a prompt, so add one; switch integer options to
use the 'int' type instead of 'string'. Add separating lines around
options.

Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
Acked-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
---
 package/gpsd/Config.in | 25 +++++++++++++------------
 1 file changed, 13 insertions(+), 12 deletions(-)

Comments

Peter Korsgaard July 4, 2016, 3:18 p.m. UTC | #1 
>>>>> "Yann" == Yann E MORIN <yann.morin.1998@free.fr> writes:

 > Since there were multiple sub-menus, their prompts are turned into
 > comments.

 > Some option were missing a prompt, so add one; switch integer options to
 > use the 'int' type instead of 'string'. Add separating lines around
 > options.

 > Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
 > Acked-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>

Committed, thanks.
diff mbox

Patch

diff --git a/package/gpsd/Config.in b/package/gpsd/Config.in
index b4008eb..876ab9b 100644
--- a/package/gpsd/Config.in
+++ b/package/gpsd/Config.in
@@ -2,7 +2,7 @@  comment "gpsd needs a toolchain w/ threads, dynamic library"
 	depends on BR2_USE_MMU
 	depends on !BR2_TOOLCHAIN_HAS_THREADS || BR2_STATIC_LIBS
 
-config BR2_PACKAGE_GPSD
+menuconfig BR2_PACKAGE_GPSD
 	bool "gpsd"
 	# Uses fork()
 	depends on BR2_USE_MMU
@@ -25,7 +25,7 @@  config BR2_PACKAGE_GPSD_DEVICES
 	string "Where to look for GPSes"
 	default "/dev/ttyS1"
 
-menu "Features"
+comment "Features"
 
 config BR2_PACKAGE_GPSD_CLIENT_DEBUG
 	bool "client debugging support"
@@ -50,36 +50,41 @@  config BR2_PACKAGE_GPSD_PPS
 
 config BR2_PACKAGE_GPSD_USER
 	bool "GPSD privilege revocation user"
+
 config BR2_PACKAGE_GPSD_USER_VALUE
-	string ""
+	string "user to run as"
 	default "nobody"
 	depends on BR2_PACKAGE_GPSD_USER
 
 config BR2_PACKAGE_GPSD_GROUP
 	bool "GPSD privilege revocation group"
+
 config BR2_PACKAGE_GPSD_GROUP_VALUE
-	string ""
+	string "group to run as"
 	default "nobody"
 	depends on BR2_PACKAGE_GPSD_GROUP
 
 config BR2_PACKAGE_GPSD_FIXED_PORT_SPEED
 	bool "compile with fixed serial port speed"
+
 config BR2_PACKAGE_GPSD_FIXED_PORT_SPEED_VALUE
-	string ""
+	int "serial port speed"
 	default "9600"
 	depends on BR2_PACKAGE_GPSD_FIXED_PORT_SPEED
 
 config BR2_PACKAGE_GPSD_MAX_CLIENT
 	bool "compile with limited maximum clients"
+
 config BR2_PACKAGE_GPSD_MAX_CLIENT_VALUE
-	string "compile with limited maximum clients"
+	int "maximum number of clients"
 	default "10"
 	depends on BR2_PACKAGE_GPSD_MAX_CLIENT
 
 config BR2_PACKAGE_GPSD_MAX_DEV
 	bool "compile with maximum allowed devices"
+
 config BR2_PACKAGE_GPSD_MAX_DEV_VALUE
-	string "compile with maximum allowed devices"
+	int "maximum allowed devices"
 	default "2"
 	depends on BR2_PACKAGE_GPSD_MAX_DEV
 
@@ -94,9 +99,7 @@  config BR2_PACKAGE_GPSD_CONTROLSEND
 config BR2_PACKAGE_GPSD_SQUELCH
 	bool "squelch gpsd_report and gpsd_hexdump to save cpu"
 
-endmenu
-
-menu "Protocols"
+comment "Protocols"
 
 config BR2_PACKAGE_GPSD_AIVDM
 	bool "Aivdm"
@@ -231,6 +234,4 @@  config BR2_PACKAGE_GPSD_UBX
 	help
 	  uBlox UBX binary support
 
-endmenu
-
 endif