diff mbox

[06/83,v2] package/jquery: include external plugins from jquery's Config.in

Message ID 13ca9d4ffea2b013e14e95f6475aa49670f82171.1467624132.git.yann.morin.1998@free.fr
State Rejected
Headers show

Commit Message

Yann E. MORIN July 4, 2016, 9:24 a.m. UTC 
... and make it a menuconfig instead of a 'config'+'menu'.

Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
Acked-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
---
 package/Config.in        | 12 ------------
 package/jquery/Config.in | 17 ++++++++++++++++-
 2 files changed, 16 insertions(+), 13 deletions(-)

Comments

Thomas Petazzoni July 4, 2016, 8:41 p.m. UTC | #1 
Hello,

On Mon,  4 Jul 2016 11:24:17 +0200, Yann E. MORIN wrote:
> ... and make it a menuconfig instead of a 'config'+'menu'.
> 
> Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
> Acked-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>

I very much prefer to have all packages included from the top-level
package/Config.in, as much as possible. So I don't really like this
change and prefer to keep things as they are today.

Thomas
diff mbox

Patch

diff --git a/package/Config.in b/package/Config.in
index 67810b0..d312347 100644
--- a/package/Config.in
+++ b/package/Config.in
@@ -1055,18 +1055,6 @@  menu "Javascript"
 	source "package/explorercanvas/Config.in"
 	source "package/flot/Config.in"
 	source "package/jquery/Config.in"
-if BR2_PACKAGE_JQUERY
-menu "External jQuery plugins"
-	source "package/jquery-datetimepicker/Config.in"
-	source "package/jquery-keyboard/Config.in"
-	source "package/jquery-mobile/Config.in"
-	source "package/jquery-sidebar/Config.in"
-	source "package/jquery-sparkline/Config.in"
-	source "package/jquery-ui/Config.in"
-	source "package/jquery-ui-themes/Config.in"
-	source "package/jquery-validation/Config.in"
-endmenu
-endif
 	source "package/jsmin/Config.in"
 	source "package/json-javascript/Config.in"
 endmenu
diff --git a/package/jquery/Config.in b/package/jquery/Config.in
index 92f5604..3133702 100644
--- a/package/jquery/Config.in
+++ b/package/jquery/Config.in
@@ -1,4 +1,4 @@ 
-config BR2_PACKAGE_JQUERY
+menuconfig BR2_PACKAGE_JQUERY
 	bool "jQuery"
 	help
 	  jQuery is a fast and concise JavaScript Library that
@@ -6,3 +6,18 @@  config BR2_PACKAGE_JQUERY
 	  animating, and Ajax interactions for rapid web development.
 
 	  http://jquery.com
+
+if BR2_PACKAGE_JQUERY
+
+comment "External jQuery plugins"
+
+source "package/jquery-datetimepicker/Config.in"
+source "package/jquery-keyboard/Config.in"
+source "package/jquery-mobile/Config.in"
+source "package/jquery-sidebar/Config.in"
+source "package/jquery-sparkline/Config.in"
+source "package/jquery-ui/Config.in"
+source "package/jquery-ui-themes/Config.in"
+source "package/jquery-validation/Config.in"
+
+endif