diff mbox

[01/83,v2] boot/at91bootstrap: choices must have a type

Message ID e37e8e59300b9a2c1a4b6179a000aa37df8c675f.1467624132.git.yann.morin.1998@free.fr
State Rejected
Headers show

Commit Message

Yann E. MORIN July 4, 2016, 9:24 a.m. UTC 
Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
---
 boot/at91bootstrap/Config.in | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Peter Korsgaard July 4, 2016, 1:13 p.m. UTC | #1 
>>>>> "Yann" == Yann E MORIN <yann.morin.1998@free.fr> writes:

 > Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
 > ---
 >  boot/at91bootstrap/Config.in | 2 +-
 >  1 file changed, 1 insertion(+), 1 deletion(-)

 > diff --git a/boot/at91bootstrap/Config.in b/boot/at91bootstrap/Config.in
 > index 57fdeda..d131a6a 100644
 > --- a/boot/at91bootstrap/Config.in
 > +++ b/boot/at91bootstrap/Config.in
 > @@ -26,7 +26,7 @@ config BR2_TARGET_AT91BOOTSTRAP_BOARD
 >  	  This is used to do a make <board>_config
 
 >  choice
 > -	prompt "Boot Memory"
 > +	bool "Boot Memory"

We use prompts in several other places in Buildroot:

git grep 'prompt "' **/Config.in | wc -l
89

And we have "always" done so without issues, so I don't think we need to
change this now.
diff mbox

Patch

diff --git a/boot/at91bootstrap/Config.in b/boot/at91bootstrap/Config.in
index 57fdeda..d131a6a 100644
--- a/boot/at91bootstrap/Config.in
+++ b/boot/at91bootstrap/Config.in
@@ -26,7 +26,7 @@  config BR2_TARGET_AT91BOOTSTRAP_BOARD
 	  This is used to do a make <board>_config
 
 choice
-	prompt "Boot Memory"
+	bool "Boot Memory"
 	default BR2_TARGET_AT91BOOTSTRAP_DATAFLASH
 	help
 	  Select Chip for which AT91 bootstrap should be built