From patchwork Fri Sep 10 11:56:16 2010 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dan Carpenter X-Patchwork-Id: 64384 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 45776B70FB for ; Fri, 10 Sep 2010 22:03:48 +1000 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753400Ab0IJL4m (ORCPT ); Fri, 10 Sep 2010 07:56:42 -0400 Received: from mail-qy0-f174.google.com ([209.85.216.174]:52076 "EHLO mail-qy0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753261Ab0IJL4l (ORCPT ); Fri, 10 Sep 2010 07:56:41 -0400 Received: by qyk36 with SMTP id 36so7189251qyk.19 for ; Fri, 10 Sep 2010 04:56:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:date:from:to:cc:subject :message-id:mime-version:content-type:content-disposition:user-agent; bh=8Dc8RudqreQSylUyxpSi68ivgoQMJg1ZHI4zGESLpuE=; b=sT9ILuXLKEbMYypsc+23VPZdbHxP+6IMUxdcgGQhk87X5B5tXmDekEbGnJoO+PR8l7 T9BpijcrKNpBHCKs68DK5W219fwZZv4WcIXlw5E2A+4l7YWiOhZHqaSyWZ1TBw0aUCSS A6mXgHu7Lqtj4gWK5dWcvc6Gy0XfwVKTVkElk= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=date:from:to:cc:subject:message-id:mime-version:content-type :content-disposition:user-agent; b=BhmMJVfvQ7F9m+VUWiNRA+4C3nMTjTBra/1qAXzBaWvlCEesvPseB4Fsq9GXgx/i/1 W1vCB1s73WKiB9RpStXqMhCQk7NYHkX8kccWGsghFrKsYBg/jqwFubX3GefarWbwwQ9F CzQR3yQXfEGwztW2vd/B9AI2nE9JscSfUVcIs= Received: by 10.224.28.211 with SMTP id n19mr228060qac.350.1284119800839; Fri, 10 Sep 2010 04:56:40 -0700 (PDT) Received: from bicker ([41.205.146.22]) by mx.google.com with ESMTPS id t18sm2575086qco.32.2010.09.10.04.56.33 (version=TLSv1/SSLv3 cipher=RC4-MD5); Fri, 10 Sep 2010 04:56:40 -0700 (PDT) Date: Fri, 10 Sep 2010 13:56:16 +0200 From: Dan Carpenter To: Arnaldo Carvalho de Melo Cc: "David S. Miller" , Octavian Purdila , Stephen Hemminger , Eric Dumazet , netdev@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: [patch] net/llc: make opt unsigned in llc_ui_setsockopt() Message-ID: <20100910115616.GD5959@bicker> MIME-Version: 1.0 Content-Disposition: inline User-Agent: Mutt/1.5.18 (2008-05-17) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org The members of struct llc_sock are unsigned so if we pass a negative value for "opt" it can cause a sign bug. Also it can cause an integer overflow when we multiply "opt * HZ". CC: stable@kernel.org Signed-off-by: Dan Carpenter --- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/net/llc/af_llc.c b/net/llc/af_llc.c index 023ba82..5826129 100644 --- a/net/llc/af_llc.c +++ b/net/llc/af_llc.c @@ -1024,7 +1024,8 @@ static int llc_ui_setsockopt(struct socket *sock, int level, int optname, { struct sock *sk = sock->sk; struct llc_sock *llc = llc_sk(sk); - int rc = -EINVAL, opt; + unsigned int opt; + int rc = -EINVAL; lock_sock(sk); if (unlikely(level != SOL_LLC || optlen != sizeof(int)))