| Message ID | 1467498098-23731-15-git-send-email-julien.floret@6wind.com |
|---|---|
| State | Accepted |
| Headers | show |
Hello, On Sun, 3 Jul 2016 00:20:43 +0200, Julien Floret wrote: > Signed-off-by: Julien Floret <julien.floret@6wind.com> > --- > package/fwup/fwup.mk | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/package/fwup/fwup.mk b/package/fwup/fwup.mk > index 0a23856048b3..ae8571690d9b 100644 > --- a/package/fwup/fwup.mk > +++ b/package/fwup/fwup.mk > @@ -9,6 +9,7 @@ FWUP_SITE = $(call github,fhunleth,fwup,$(FWUP_VERSION)) > FWUP_LICENSE = Apache-2.0 > FWUP_LICENSE_FILES = LICENSE > FWUP_DEPENDENCIES = libconfuse libarchive libsodium > +HOST_FWUP_DEPENDENCIES = host-libconfuse host-libarchive host-libsodium > FWUP_AUTORECONF = YES > FWUP_CONF_ENV = ac_cv_path_HELP2MAN="" Unrelated to your patch, but I'm wondering why we pass ac_cv_path_HELP2MAN="" for the target variant (which was needed to fix some build failures), and not to the host variant. I'm adding Baruch in Cc since he fixed this problem. I've applied your patch, thanks! Thomas
Hi Thomas, On Sun, Jul 03, 2016 at 08:56:48AM +0200, Thomas Petazzoni wrote: > On Sun, 3 Jul 2016 00:20:43 +0200, Julien Floret wrote: > > FWUP_CONF_ENV = ac_cv_path_HELP2MAN="" > > Unrelated to your patch, but I'm wondering why we pass > ac_cv_path_HELP2MAN="" for the target variant (which was needed to fix > some build failures), and not to the host variant. I'm adding Baruch in > Cc since he fixed this problem. The simple answer is that since help2man works just fine for the host binary of fwup by definition, there is no build breakage. We may add it to the host variant as well to shorten build time somewhat, though I'm not sure it's worth the trouble. Have fun at Toulouse. baruch
Hello, On Sun, 3 Jul 2016 10:05:20 +0300, Baruch Siach wrote: > The simple answer is that since help2man works just fine for the host binary > of fwup by definition, there is no build breakage. We may add it to the host > variant as well to shorten build time somewhat, though I'm not sure it's worth > the trouble. Ah, ok, I should have looked at the build failure. The build failure was not about help2man being unavailable on the host system, but about help2man failing to work building the target variant for some reason. OK, makes sense then. Thanks! Thomas
diff --git a/package/fwup/fwup.mk b/package/fwup/fwup.mk index 0a23856048b3..ae8571690d9b 100644 --- a/package/fwup/fwup.mk +++ b/package/fwup/fwup.mk @@ -9,6 +9,7 @@ FWUP_SITE = $(call github,fhunleth,fwup,$(FWUP_VERSION)) FWUP_LICENSE = Apache-2.0 FWUP_LICENSE_FILES = LICENSE FWUP_DEPENDENCIES = libconfuse libarchive libsodium +HOST_FWUP_DEPENDENCIES = host-libconfuse host-libarchive host-libsodium FWUP_AUTORECONF = YES FWUP_CONF_ENV = ac_cv_path_HELP2MAN=""
Signed-off-by: Julien Floret <julien.floret@6wind.com> --- package/fwup/fwup.mk | 1 + 1 file changed, 1 insertion(+)