Patchwork Update MAINTAINERS

login
register
mail settings
Submitter Anthony Liguori
Date Sept. 9, 2010, 7:54 p.m.
Message ID <1284062053-28066-1-git-send-email-aliguori@us.ibm.com>
Download mbox | patch
Permalink /patch/64332/
State New
Headers show

Comments

Anthony Liguori - Sept. 9, 2010, 7:54 p.m.
The goal of this file is not to establish strict ownership of the code base but
rather to provide a place for people to direct questions to and for names of
people to CC on patches.

I'm basing this update on my observations on how things currently work today.
If you think your name should be on something and it's not, don't read anything
into it and just correct me :-)

Signed-off-by: Anthony Liguori <aliguori@us.ibm.com>
Stefan Weil - Sept. 9, 2010, 8:12 p.m.
Am 09.09.2010 21:54, schrieb Anthony Liguori:
> The goal of this file is not to establish strict ownership of the code base but
> rather to provide a place for people to direct questions to and for names of
> people to CC on patches.
>    

This text should be added to MAINTAINERS.

> I'm basing this update on my observations on how things currently work today.
> If you think your name should be on something and it's not, don't read anything
> into it and just correct me :-)
>
> Signed-off-by: Anthony Liguori<aliguori@us.ibm.com>
>
> diff --git a/MAINTAINERS b/MAINTAINERS
> index e5165fb..ee84f3f 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -4,13 +4,12 @@ QEMU Maintainers
>   Project leaders:
>   ----------------
>
> -Fabrice Bellard
>   Paul Brook
>
> -CPU cores:
> +TCG cores:
>   ----------
>
> -x86                Fabrice Bellard
> +x86                ?
>   ARM                Paul Brook
>   SPARC              Blue Swirl
>   MIPS               ?
> @@ -26,7 +25,7 @@ Machines (sorted by CPU):
>   -------------------------
>
>   x86
> -  pc.c                    Fabrice Bellard (new maintainer needed)
> +  pc.c                    Anthony Liguori
>   ARM
>     integratorcp.c          Paul Brook
>     versatilepb.c           Paul Brook
> @@ -70,19 +69,20 @@ S390
>   Generic Subsystems:
>   -------------------
>
> -Dynamic translator        Fabrice Bellard
> -Main loop                 Fabrice Bellard (new maintainer needed)
> -TCG                       Fabrice Bellard
> -IDE device                ?
> -SCSI device               Paul Brook
> +Main loop                 Anthony Liguori
> +TCG                       ?
> +KVM                       Marcelo Tosatti/Avi Kivity
> +Virtio devices            Anthony Liguori
> +IDE devices               ?
> +SCSI devices              Paul Brook
>   PCI layer                 Michael S. Tsirkin
>   USB layer                 ?
> -Block layer               ?
> -Graphic layer             ?
> +Block layer               Kevin Wolf
> +Graphic layer             Anthony Liguori
>   Audio device layer        Vassili Karpov (malc)
> -Character device layer    ?
> -Network device layer      ?
> +Character device layer    Anthony Liguori
> +Network device layer      Anthony Liguori/Mark McLoughlin
>   GDB stub                  ?
> -Linux user                ?
> -Darwin user               ?
> -SLIRP                     ?
> +Linux user                Riku Voipio
> +Darwin user               Unmaintained (likely to be removed)
> +SLIRP                     Unmaintained
>    

Hello Anthony,

I feel responsible for any file with "Copyright (c) 20xx Stefan Weil" in 
the header.

Maybe a general remark like this would be good:

For individual files, there is usually a copyright owner mentioned in 
the file's header.
In most cases, this person also maintains this file.

(or anything similar)

For people who don't know what "Main loop" (and the other topics) is and 
also
for automated parsing (matching of files to maintainers like it is done 
by the linux kernel)
additional path or filename entries would be helpful in a future version.

Regards
Stefan
Blue Swirl - Sept. 9, 2010, 8:12 p.m.
On Thu, Sep 9, 2010 at 7:54 PM, Anthony Liguori <aliguori@us.ibm.com> wrote:
> The goal of this file is not to establish strict ownership of the code base but
> rather to provide a place for people to direct questions to and for names of
> people to CC on patches.
>
> I'm basing this update on my observations on how things currently work today.
> If you think your name should be on something and it's not, don't read anything
> into it and just correct me :-)
>
> Signed-off-by: Anthony Liguori <aliguori@us.ibm.com>
>
> diff --git a/MAINTAINERS b/MAINTAINERS
> index e5165fb..ee84f3f 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -4,13 +4,12 @@ QEMU Maintainers
>  Project leaders:
>  ----------------
>
> -Fabrice Bellard
>  Paul Brook

+Anthony Liguori

I think that is how things work today.

>
> -CPU cores:
> +TCG cores:

That could be read as TCG host support. How about 'Guest CPU cores
(TCG)' with 'Guest CPU cores (KVM)' added later?

>  ----------
>
> -x86                Fabrice Bellard
> +x86                ?
>  ARM                Paul Brook
>  SPARC              Blue Swirl
>  MIPS               ?
> @@ -26,7 +25,7 @@ Machines (sorted by CPU):
>  -------------------------
>
>  x86
> -  pc.c                    Fabrice Bellard (new maintainer needed)
> +  pc.c                    Anthony Liguori
>  ARM
>   integratorcp.c          Paul Brook
>   versatilepb.c           Paul Brook
> @@ -70,19 +69,20 @@ S390
>  Generic Subsystems:
>  -------------------
>
> -Dynamic translator        Fabrice Bellard
> -Main loop                 Fabrice Bellard (new maintainer needed)
> -TCG                       Fabrice Bellard
> -IDE device                ?
> -SCSI device               Paul Brook
> +Main loop                 Anthony Liguori
> +TCG                       ?
> +KVM                       Marcelo Tosatti/Avi Kivity
> +Virtio devices            Anthony Liguori
> +IDE devices               ?
> +SCSI devices              Paul Brook
>  PCI layer                 Michael S. Tsirkin
>  USB layer                 ?
> -Block layer               ?
> -Graphic layer             ?
> +Block layer               Kevin Wolf
> +Graphic layer             Anthony Liguori
>  Audio device layer        Vassili Karpov (malc)
> -Character device layer    ?
> -Network device layer      ?
> +Character device layer    Anthony Liguori
> +Network device layer      Anthony Liguori/Mark McLoughlin
>  GDB stub                  ?
> -Linux user                ?
> -Darwin user               ?
> -SLIRP                     ?
> +Linux user                Riku Voipio

+BSD user                Blue Swirl

> +Darwin user               Unmaintained (likely to be removed)
> +SLIRP                     Unmaintained
> --
> 1.7.0.4
>
>
>
Anthony Liguori - Sept. 9, 2010, 8:17 p.m.
On 09/09/2010 03:12 PM, Stefan Weil wrote:
> Am 09.09.2010 21:54, schrieb Anthony Liguori:
>> The goal of this file is not to establish strict ownership of the 
>> code base but
>> rather to provide a place for people to direct questions to and for 
>> names of
>> people to CC on patches.
>
> This text should be added to MAINTAINERS.
>
>> I'm basing this update on my observations on how things currently 
>> work today.
>> If you think your name should be on something and it's not, don't 
>> read anything
>> into it and just correct me :-)
>>
>> Signed-off-by: Anthony Liguori<aliguori@us.ibm.com>
>>
>> diff --git a/MAINTAINERS b/MAINTAINERS
>> index e5165fb..ee84f3f 100644
>> --- a/MAINTAINERS
>> +++ b/MAINTAINERS
>> @@ -4,13 +4,12 @@ QEMU Maintainers
>>   Project leaders:
>>   ----------------
>>
>> -Fabrice Bellard
>>   Paul Brook
>>
>> -CPU cores:
>> +TCG cores:
>>   ----------
>>
>> -x86                Fabrice Bellard
>> +x86                ?
>>   ARM                Paul Brook
>>   SPARC              Blue Swirl
>>   MIPS               ?
>> @@ -26,7 +25,7 @@ Machines (sorted by CPU):
>>   -------------------------
>>
>>   x86
>> -  pc.c                    Fabrice Bellard (new maintainer needed)
>> +  pc.c                    Anthony Liguori
>>   ARM
>>     integratorcp.c          Paul Brook
>>     versatilepb.c           Paul Brook
>> @@ -70,19 +69,20 @@ S390
>>   Generic Subsystems:
>>   -------------------
>>
>> -Dynamic translator        Fabrice Bellard
>> -Main loop                 Fabrice Bellard (new maintainer needed)
>> -TCG                       Fabrice Bellard
>> -IDE device                ?
>> -SCSI device               Paul Brook
>> +Main loop                 Anthony Liguori
>> +TCG                       ?
>> +KVM                       Marcelo Tosatti/Avi Kivity
>> +Virtio devices            Anthony Liguori
>> +IDE devices               ?
>> +SCSI devices              Paul Brook
>>   PCI layer                 Michael S. Tsirkin
>>   USB layer                 ?
>> -Block layer               ?
>> -Graphic layer             ?
>> +Block layer               Kevin Wolf
>> +Graphic layer             Anthony Liguori
>>   Audio device layer        Vassili Karpov (malc)
>> -Character device layer    ?
>> -Network device layer      ?
>> +Character device layer    Anthony Liguori
>> +Network device layer      Anthony Liguori/Mark McLoughlin
>>   GDB stub                  ?
>> -Linux user                ?
>> -Darwin user               ?
>> -SLIRP                     ?
>> +Linux user                Riku Voipio
>> +Darwin user               Unmaintained (likely to be removed)
>> +SLIRP                     Unmaintained
>
> Hello Anthony,
>
> I feel responsible for any file with "Copyright (c) 20xx Stefan Weil" 
> in the header.

Yeah, I'm thinking of converting to a Linux style maintainers that's 
more conducive to fine-grain info.  Again, my intention is for people 
who are looking to ask for help or patch review for a particular piece 
of code so having more granularity is a good thing.

> Maybe a general remark like this would be good:
>
> For individual files, there is usually a copyright owner mentioned in 
> the file's header.

It's very often that the original copyright holder is no longer involved 
in the project.  Hence the need for something beyond the copyright 
header in the first place.

> In most cases, this person also maintains this file.
>
> (or anything similar)
>
> For people who don't know what "Main loop" (and the other topics) is 
> and also
> for automated parsing (matching of files to maintainers like it is 
> done by the linux kernel)
> additional path or filename entries would be helpful in a future version.

Yes, hence the desire to move to a Linux style format.

Regards,

Anthony Liguori

>
> Regards
> Stefan
>
>
Anthony Liguori - Sept. 9, 2010, 8:20 p.m.
On 09/09/2010 03:12 PM, Blue Swirl wrote:
>> diff --git a/MAINTAINERS b/MAINTAINERS
>> index e5165fb..ee84f3f 100644
>> --- a/MAINTAINERS
>> +++ b/MAINTAINERS
>> @@ -4,13 +4,12 @@ QEMU Maintainers
>>   Project leaders:
>>   ----------------
>>
>> -Fabrice Bellard
>>   Paul Brook
>>      
> +Anthony Liguori
>
> I think that is how things work today.
>    

I don't object to that :-) But I was also considering just removing the 
section or maybe listing "core maintainers" which are the folks that 
have commit access.

>> -CPU cores:
>> +TCG cores:
>>      
> That could be read as TCG host support. How about 'Guest CPU cores
> (TCG)' with 'Guest CPU cores (KVM)' added later?
>    

That makes sense.

>>   ----------
>>
>> -x86                Fabrice Bellard
>> +x86                ?
>>   ARM                Paul Brook
>>   SPARC              Blue Swirl
>>   MIPS               ?
>> @@ -26,7 +25,7 @@ Machines (sorted by CPU):
>>   -------------------------
>>
>>   x86
>> -  pc.c                    Fabrice Bellard (new maintainer needed)
>> +  pc.c                    Anthony Liguori
>>   ARM
>>    integratorcp.c          Paul Brook
>>    versatilepb.c           Paul Brook
>> @@ -70,19 +69,20 @@ S390
>>   Generic Subsystems:
>>   -------------------
>>
>> -Dynamic translator        Fabrice Bellard
>> -Main loop                 Fabrice Bellard (new maintainer needed)
>> -TCG                       Fabrice Bellard
>> -IDE device                ?
>> -SCSI device               Paul Brook
>> +Main loop                 Anthony Liguori
>> +TCG                       ?
>> +KVM                       Marcelo Tosatti/Avi Kivity
>> +Virtio devices            Anthony Liguori
>> +IDE devices               ?
>> +SCSI devices              Paul Brook
>>   PCI layer                 Michael S. Tsirkin
>>   USB layer                 ?
>> -Block layer               ?
>> -Graphic layer             ?
>> +Block layer               Kevin Wolf
>> +Graphic layer             Anthony Liguori
>>   Audio device layer        Vassili Karpov (malc)
>> -Character device layer    ?
>> -Network device layer      ?
>> +Character device layer    Anthony Liguori
>> +Network device layer      Anthony Liguori/Mark McLoughlin
>>   GDB stub                  ?
>> -Linux user                ?
>> -Darwin user               ?
>> -SLIRP                     ?
>> +Linux user                Riku Voipio
>>      
> +BSD user                Blue Swirl
>    

Indeed.

Regards,

Anthony Liguori

>> +Darwin user               Unmaintained (likely to be removed)
>> +SLIRP                     Unmaintained
>> --
>> 1.7.0.4
>>
>>
>>
>>

Patch

diff --git a/MAINTAINERS b/MAINTAINERS
index e5165fb..ee84f3f 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -4,13 +4,12 @@  QEMU Maintainers
 Project leaders:
 ----------------
 
-Fabrice Bellard
 Paul Brook
 
-CPU cores:
+TCG cores:
 ----------
 
-x86                Fabrice Bellard
+x86                ?
 ARM                Paul Brook
 SPARC              Blue Swirl
 MIPS               ?
@@ -26,7 +25,7 @@  Machines (sorted by CPU):
 -------------------------
 
 x86
-  pc.c                    Fabrice Bellard (new maintainer needed)
+  pc.c                    Anthony Liguori
 ARM
   integratorcp.c          Paul Brook
   versatilepb.c           Paul Brook
@@ -70,19 +69,20 @@  S390
 Generic Subsystems:
 -------------------  
 
-Dynamic translator        Fabrice Bellard
-Main loop                 Fabrice Bellard (new maintainer needed)
-TCG                       Fabrice Bellard
-IDE device                ?
-SCSI device               Paul Brook
+Main loop                 Anthony Liguori
+TCG                       ?
+KVM                       Marcelo Tosatti/Avi Kivity
+Virtio devices            Anthony Liguori
+IDE devices               ?
+SCSI devices              Paul Brook
 PCI layer                 Michael S. Tsirkin
 USB layer                 ?
-Block layer               ?
-Graphic layer             ?
+Block layer               Kevin Wolf
+Graphic layer             Anthony Liguori
 Audio device layer        Vassili Karpov (malc)
-Character device layer    ?
-Network device layer      ?
+Character device layer    Anthony Liguori
+Network device layer      Anthony Liguori/Mark McLoughlin
 GDB stub                  ?
-Linux user                ?
-Darwin user               ?
-SLIRP                     ?
+Linux user                Riku Voipio
+Darwin user               Unmaintained (likely to be removed)
+SLIRP                     Unmaintained