Patchwork : Fix bootstrap failure in dwarf2out for x86_64-*-mingw32

login
register
mail settings
Submitter Kai Tietz
Date Sept. 9, 2010, 7:29 p.m.
Message ID <AANLkTi=f_sBFFpNJ6Vd73HkfdpqwO+Mr82qa3LLSYF84@mail.gmail.com>
Download mbox | patch
Permalink /patch/64320/
State New
Headers show

Comments

Kai Tietz - Sept. 9, 2010, 7:29 p.m.
Hello,

ChangeLog

2010-09-09  Kai Tietz

        * dwarf2out.c (get_ref_die_offset_label): Cast die_offset to
        HWINT.

Tested for x86_64-pc-linux-gnu, i686-pc-mingw32, and
x86_64-w64-mingw32. Ok for apply?

Kai
Ian Taylor - Sept. 11, 2010, 1:17 a.m.
On Thu, Sep 9, 2010 at 12:29 PM, Kai Tietz <ktietz70@googlemail.com> wrote:

> ChangeLog
>
> 2010-09-09  Kai Tietz
>
>        * dwarf2out.c (get_ref_die_offset_label): Cast die_offset to
>        HWINT.

This is OK.

Thanks.

Ian
H.J. Lu - Sept. 11, 2010, 2:09 a.m.
On Fri, Sep 10, 2010 at 6:17 PM, Ian Lance Taylor <iant@google.com> wrote:
> On Thu, Sep 9, 2010 at 12:29 PM, Kai Tietz <ktietz70@googlemail.com> wrote:
>
>> ChangeLog
>>
>> 2010-09-09  Kai Tietz
>>
>>        * dwarf2out.c (get_ref_die_offset_label): Cast die_offset to
>>        HWINT.
>
> This is OK.

Isn't it fixed by

http://gcc.gnu.org/ml/gcc-patches/2010-09/msg00924.html
Kai Tietz - Sept. 11, 2010, 7:10 a.m.
2010/9/11 H.J. Lu <hjl.tools@gmail.com>:
> On Fri, Sep 10, 2010 at 6:17 PM, Ian Lance Taylor <iant@google.com> wrote:
>> On Thu, Sep 9, 2010 at 12:29 PM, Kai Tietz <ktietz70@googlemail.com> wrote:
>>
>>> ChangeLog
>>>
>>> 2010-09-09  Kai Tietz
>>>
>>>        * dwarf2out.c (get_ref_die_offset_label): Cast die_offset to
>>>        HWINT.
>>
>> This is OK.
>
> Isn't it fixed by
>
> http://gcc.gnu.org/ml/gcc-patches/2010-09/msg00924.html
>
>
>
> --
> H.J.
>

It is already fixed by Jakub.

Kai

Patch

Index: dwarf2out.c
===================================================================
--- dwarf2out.c (revision 164107)
+++ dwarf2out.c (working copy)
@@ -6546,7 +6546,7 @@ 
 get_ref_die_offset_label (char *label, dw_die_ref ref)
 {
   sprintf (label, "%s+" HOST_WIDE_INT_PRINT_DEC,
-          debug_info_section_label, ref->die_offset);
+          debug_info_section_label, (HOST_WIDE_INT) ref->die_offset);
 }

 /* Convert a DIE tag into its string name.  */