diff mbox

[1/2] powerpc/85xx: add ngPIXIS FPGA device tree node to the P1022DS board

Message ID 1284057597-17126-1-git-send-email-timur@freescale.com (mailing list archive)
State Accepted, archived
Delegated to: Kumar Gala
Headers show

Commit Message

Timur Tabi Sept. 9, 2010, 6:39 p.m. UTC
The device tree for Freescale's P1022DS reference board is missing the node
for the ngPIXIS FPGA.

Signed-off-by: Timur Tabi <timur@freescale.com>
---
 arch/powerpc/boot/dts/p1022ds.dts |    9 +++++++++
 1 files changed, 9 insertions(+), 0 deletions(-)

Comments

Kumar Gala Oct. 7, 2010, 5:27 a.m. UTC | #1
On Sep 9, 2010, at 1:39 PM, Timur Tabi wrote:

> The device tree for Freescale's P1022DS reference board is missing the node
> for the ngPIXIS FPGA.
> 
> Signed-off-by: Timur Tabi <timur@freescale.com>
> ---
> arch/powerpc/boot/dts/p1022ds.dts |    9 +++++++++
> 1 files changed, 9 insertions(+), 0 deletions(-)
> 
> diff --git a/arch/powerpc/boot/dts/p1022ds.dts b/arch/powerpc/boot/dts/p1022ds.dts
> index 8bcb10b..e61b42d 100644
> --- a/arch/powerpc/boot/dts/p1022ds.dts
> +++ b/arch/powerpc/boot/dts/p1022ds.dts
> @@ -148,6 +148,15 @@
> 				label = "reserved-nand";
> 			};
> 		};
> +
> +		board-control@3,0 {
> +			#address-cells = <1>;
> +			#size-cells = <1>;

these aren't need if we don't have a child node.

> +			compatible = "fsl,fpga-pixis";

lets make this "fsl,p1022ds-pixis"

> +			reg = <3 0 0x30>;
> +			interrupt-parent = <&mpic>;
> +			interrupts = <8 8>;

what do we think about adding a comment about what this interrupt is for

> +		};
> 	};
> 
> 	soc@fffe00000 {
> -- 
> 1.7.2.2
> 
> 
> _______________________________________________
> Linuxppc-dev mailing list
> Linuxppc-dev@lists.ozlabs.org
> https://lists.ozlabs.org/listinfo/linuxppc-dev
diff mbox

Patch

diff --git a/arch/powerpc/boot/dts/p1022ds.dts b/arch/powerpc/boot/dts/p1022ds.dts
index 8bcb10b..e61b42d 100644
--- a/arch/powerpc/boot/dts/p1022ds.dts
+++ b/arch/powerpc/boot/dts/p1022ds.dts
@@ -148,6 +148,15 @@ 
 				label = "reserved-nand";
 			};
 		};
+
+		board-control@3,0 {
+			#address-cells = <1>;
+			#size-cells = <1>;
+			compatible = "fsl,fpga-pixis";
+			reg = <3 0 0x30>;
+			interrupt-parent = <&mpic>;
+			interrupts = <8 8>;
+		};
 	};
 
 	soc@fffe00000 {