| Message ID | 1467310337-3201-1-git-send-email-ehabkost@redhat.com |
|---|---|
| State | New |
| Headers | show |
* Eduardo Habkost (ehabkost@redhat.com) wrote: > Improve the TSC frequency mismatch warning to show the host and > VM TSC frequencies. > > Signed-off-by: Eduardo Habkost <ehabkost@redhat.com> > --- > target-i386/kvm.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/target-i386/kvm.c b/target-i386/kvm.c > index f3698f1..9679415 100644 > --- a/target-i386/kvm.c > +++ b/target-i386/kvm.c > @@ -566,7 +566,9 @@ static int kvm_arch_set_tsc_khz(CPUState *cs) > -ENOTSUP; > if (cur_freq <= 0 || cur_freq != env->tsc_khz) { > error_report("warning: TSC frequency mismatch between " > - "VM and host, and TSC scaling unavailable"); > + "VM (%" PRId64 " kHz) and host (%d kHz), " > + "and TSC scaling unavailable", > + env->tsc_khz, cur_freq); > return r; > } Reviewed-by: Dr. David Alan Gilbert <dgilbert@redhat.com> Yep, it should be interesting to see what the differences are we hit, wacky different values or the one next door that's slightly warmer. Dave > } > -- > 2.5.5 > -- Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK
On Thu, Jun 30, 2016 at 03:12:17PM -0300, Eduardo Habkost wrote: > Improve the TSC frequency mismatch warning to show the host and > VM TSC frequencies. > > Signed-off-by: Eduardo Habkost <ehabkost@redhat.com> > --- > target-i386/kvm.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/target-i386/kvm.c b/target-i386/kvm.c > index f3698f1..9679415 100644 > --- a/target-i386/kvm.c > +++ b/target-i386/kvm.c > @@ -566,7 +566,9 @@ static int kvm_arch_set_tsc_khz(CPUState *cs) > -ENOTSUP; > if (cur_freq <= 0 || cur_freq != env->tsc_khz) { > error_report("warning: TSC frequency mismatch between " > - "VM and host, and TSC scaling unavailable"); > + "VM (%" PRId64 " kHz) and host (%d kHz), " > + "and TSC scaling unavailable", > + env->tsc_khz, cur_freq); > return r; > } > } > -- > 2.5.5 ACK
diff --git a/target-i386/kvm.c b/target-i386/kvm.c index f3698f1..9679415 100644 --- a/target-i386/kvm.c +++ b/target-i386/kvm.c @@ -566,7 +566,9 @@ static int kvm_arch_set_tsc_khz(CPUState *cs) -ENOTSUP; if (cur_freq <= 0 || cur_freq != env->tsc_khz) { error_report("warning: TSC frequency mismatch between " - "VM and host, and TSC scaling unavailable"); + "VM (%" PRId64 " kHz) and host (%d kHz), " + "and TSC scaling unavailable", + env->tsc_khz, cur_freq); return r; } }
Improve the TSC frequency mismatch warning to show the host and VM TSC frequencies. Signed-off-by: Eduardo Habkost <ehabkost@redhat.com> --- target-i386/kvm.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)