diff mbox

[U-Boot,02/14] mkimage: Explain the auto-fit imagefile special case

Message ID 1467305540-13607-3-git-send-email-sjg@chromium.org
State Accepted
Commit 3c23c0feacce0f73d7852409a0c634f275cbecfe
Delegated to: Tom Rini
Headers show

Commit Message

Simon Glass June 30, 2016, 4:52 p.m. UTC
There is a special case in the code when auto-fit is used. Add a comment to
make it easier to understand why this is needed.

Signed-off-by: Simon Glass <sjg@chromium.org>
---

 tools/mkimage.c | 1 +
 1 file changed, 1 insertion(+)

Comments

Joe Hershberger July 6, 2016, 3:08 p.m. UTC | #1
On Thu, Jun 30, 2016 at 11:52 AM, Simon Glass <sjg@chromium.org> wrote:
> There is a special case in the code when auto-fit is used. Add a comment to
> make it easier to understand why this is needed.
>
> Signed-off-by: Simon Glass <sjg@chromium.org>

Acked-by: Joe Hershberger <joe.hershberger@ni.com>
Tom Rini July 16, 2016, 1:48 p.m. UTC | #2
On Thu, Jun 30, 2016 at 10:52:08AM -0600, Simon Glass wrote:

> There is a special case in the code when auto-fit is used. Add a comment to
> make it easier to understand why this is needed.
> 
> Signed-off-by: Simon Glass <sjg@chromium.org>
> Acked-by: Joe Hershberger <joe.hershberger@ni.com>

Applied to u-boot/master, thanks!
diff mbox

Patch

diff --git a/tools/mkimage.c b/tools/mkimage.c
index 53fa8bb..66d29ab 100644
--- a/tools/mkimage.c
+++ b/tools/mkimage.c
@@ -273,6 +273,7 @@  static void process_args(int argc, char **argv)
 	 */
 	if (params.type == IH_TYPE_FLATDT) {
 		params.fit_image_type = type ? type : IH_TYPE_KERNEL;
+		/* For auto_its, datafile is always 'auto' */
 		if (!params.auto_its)
 			params.datafile = datafile;
 	} else if (type != IH_TYPE_INVALID) {