| Message ID | 1467301824-10123-1-git-send-email-clg@kaod.org |
|---|---|
| State | New |
| Headers | show |
On 30 June 2016 at 16:50, Cédric Le Goater <clg@kaod.org> wrote: > These strap registers are complex enough, let's not mix them. > > Signed-off-by: Cédric Le Goater <clg@kaod.org> Was there a cover letter for this patchset? I can't find it in my email... thanks -- PMM
On 06/30/2016 08:24 PM, Peter Maydell wrote: > On 30 June 2016 at 16:50, Cédric Le Goater <clg@kaod.org> wrote: >> These strap registers are complex enough, let's not mix them. >> >> Signed-off-by: Cédric Le Goater <clg@kaod.org> > > Was there a cover letter for this patchset? I can't find > it in my email... Ah :/ No, I didn't send one as the patches were small and self contained. Should we each time ? Thanks, C.
On 07/01/2016 08:11 AM, Cédric Le Goater wrote: > On 06/30/2016 08:24 PM, Peter Maydell wrote: >> On 30 June 2016 at 16:50, Cédric Le Goater <clg@kaod.org> wrote: >>> These strap registers are complex enough, let's not mix them. >>> >>> Signed-off-by: Cédric Le Goater <clg@kaod.org> >> >> Was there a cover letter for this patchset? I can't find >> it in my email... > > Ah :/ No, I didn't send one as the patches were small and self > contained. Should we each time ? Let me rework that if possible. I need to add a few things. Thanks, C.
On 1 July 2016 at 07:11, Cédric Le Goater <clg@kaod.org> wrote: > On 06/30/2016 08:24 PM, Peter Maydell wrote: >> On 30 June 2016 at 16:50, Cédric Le Goater <clg@kaod.org> wrote: >>> These strap registers are complex enough, let's not mix them. >>> >>> Signed-off-by: Cédric Le Goater <clg@kaod.org> >> >> Was there a cover letter for this patchset? I can't find >> it in my email... > > Ah :/ No, I didn't send one as the patches were small and self > contained. Should we each time ? The basic rule is that single standalone patches don't need a cover letter; a series with more than one patch should have a cover letter. Some of our automated tooling gets confused otherwise (also I like to be able to have a single email to mark for attention in my mail client). These confused me a bit because they had the series indicators in the subject (1/2, 2/2) but no cover. thanks -- PMM
On 07/01/2016 10:02 AM, Peter Maydell wrote: > On 1 July 2016 at 07:11, Cédric Le Goater <clg@kaod.org> wrote: >> On 06/30/2016 08:24 PM, Peter Maydell wrote: >>> On 30 June 2016 at 16:50, Cédric Le Goater <clg@kaod.org> wrote: >>>> These strap registers are complex enough, let's not mix them. >>>> >>>> Signed-off-by: Cédric Le Goater <clg@kaod.org> >>> >>> Was there a cover letter for this patchset? I can't find >>> it in my email... >> >> Ah :/ No, I didn't send one as the patches were small and self >> contained. Should we each time ? > > The basic rule is that single standalone patches don't > need a cover letter; a series with more than one patch > should have a cover letter. Some of our automated tooling > gets confused otherwise (also I like to be able to have a > single email to mark for attention in my mail client). > These confused me a bit because they had the series > indicators in the subject (1/2, 2/2) but no cover. Yes, the email threading was a bit confusing in my mail client also. Sorry about that. I will resend with a cover letter. I need to add where the macros are coming from. Thanks, C.
diff --git a/hw/misc/aspeed_scu.c b/hw/misc/aspeed_scu.c index 4f9df581e70a..14b2d75e6049 100644 --- a/hw/misc/aspeed_scu.c +++ b/hw/misc/aspeed_scu.c @@ -254,7 +254,7 @@ static const VMStateDescription vmstate_aspeed_scu = { static Property aspeed_scu_properties[] = { DEFINE_PROP_UINT32("silicon-rev", AspeedSCUState, silicon_rev, 0), DEFINE_PROP_UINT32("hw-strap1", AspeedSCUState, hw_strap1, 0), - DEFINE_PROP_UINT32("hw-strap2", AspeedSCUState, hw_strap1, 0), + DEFINE_PROP_UINT32("hw-strap2", AspeedSCUState, hw_strap2, 0), DEFINE_PROP_END_OF_LIST(), };
These strap registers are complex enough, let's not mix them. Signed-off-by: Cédric Le Goater <clg@kaod.org> --- hw/misc/aspeed_scu.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)