Patchwork atlx: make strings const

login
register
mail settings
Submitter stephen hemminger
Date Sept. 8, 2010, 10:18 p.m.
Message ID <20100908151836.3c40cc81@nehalam>
Download mbox | patch
Permalink /patch/64234/
State Accepted
Delegated to: David Miller
Headers show

Comments

stephen hemminger - Sept. 8, 2010, 10:18 p.m.
Signed-off-by: Stephen Hemminger <shemminger@vyatta.com>
Acked-by: Chris Snook <chris.snook@gmail.com>

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Joe Perches - Sept. 8, 2010, 10:58 p.m.
On Wed, 2010-09-08 at 15:18 -0700, Stephen Hemminger wrote:
> Signed-off-by: Stephen Hemminger <shemminger@vyatta.com>
> Acked-by: Chris Snook <chris.snook@gmail.com>
> 

Shouldn't that be done with all of the global
static char foo[] = "bar"; declarations?



--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
stephen hemminger - Sept. 9, 2010, 1:54 a.m.
On Wed, 08 Sep 2010 15:58:11 -0700
Joe Perches <joe@perches.com> wrote:

> On Wed, 2010-09-08 at 15:18 -0700, Stephen Hemminger wrote:
> > Signed-off-by: Stephen Hemminger <shemminger@vyatta.com>
> > Acked-by: Chris Snook <chris.snook@gmail.com>
> > 
> 
> Shouldn't that be done with all of the global
> static char foo[] = "bar"; declarations?

Yes, that what I was looking at when I found some of these.
Those that are __initdata don't matter as much since they
get dropped (although they could be changed to __initconst).
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
David Miller - Sept. 9, 2010, 4:32 a.m.
From: Stephen Hemminger <shemminger@vyatta.com>
Date: Wed, 8 Sep 2010 15:18:36 -0700

> 
> Signed-off-by: Stephen Hemminger <shemminger@vyatta.com>
> Acked-by: Chris Snook <chris.snook@gmail.com>

Applied, feel free to hit those __initconst cases too.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Patch

--- a/drivers/net/atlx/atl2.c	2010-09-02 10:51:39.529679405 -0700
+++ b/drivers/net/atlx/atl2.c	2010-09-02 10:52:23.904667707 -0700
@@ -51,10 +51,10 @@ 
 
 #define ATL2_DRV_VERSION "2.2.3"
 
-static char atl2_driver_name[] = "atl2";
+static const char atl2_driver_name[] = "atl2";
 static const char atl2_driver_string[] = "Atheros(R) L2 Ethernet Driver";
-static char atl2_copyright[] = "Copyright (c) 2007 Atheros Corporation.";
-static char atl2_driver_version[] = ATL2_DRV_VERSION;
+static const char atl2_copyright[] = "Copyright (c) 2007 Atheros Corporation.";
+static const char atl2_driver_version[] = ATL2_DRV_VERSION;
 
 MODULE_AUTHOR("Atheros Corporation <xiong.huang@atheros.com>, Chris Snook <csnook@redhat.com>");
 MODULE_DESCRIPTION("Atheros Fast Ethernet Network Driver");