From patchwork Wed Sep 8 14:21:25 2010 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: [For,0.13] Disable virtio-balloon memory stats interface Date: Wed, 08 Sep 2010 04:21:25 -0000 From: Adam Litke X-Patchwork-Id: 64164 Message-Id: <1283955685-25152-1-git-send-email-agl@us.ibm.com> To: Amit Shah , Anthony Liguori Cc: Adam Litke , Paolo Bonzini , Luiz Capitulino , qemu list , Markus Armbruster The addition of memory stats reporting to the virtio balloon causes the 'info balloon' command to become asynchronous. This is a regression because in some cases it can hang the user monitor. To fix this regression, the virtio balloon memory stats feature is being disabled in qemu-0.13. Signed-off-by: Adam Litke --- hw/virtio-balloon.c | 12 +++++++++++- 1 files changed, 11 insertions(+), 1 deletions(-) diff --git a/hw/virtio-balloon.c b/hw/virtio-balloon.c index 9fe3886..269bc22 100644 --- a/hw/virtio-balloon.c +++ b/hw/virtio-balloon.c @@ -190,7 +190,17 @@ static void virtio_balloon_set_config(VirtIODevice *vdev, static uint32_t virtio_balloon_get_features(VirtIODevice *vdev, uint32_t f) { - f |= (1 << VIRTIO_BALLOON_F_STATS_VQ); + /* + * The addition of memory stats reporting to the virtio balloon causes + * the 'info balloon' command to become asynchronous. This is a regression + * because in some cases it can hang the user monitor. + * + * To fix this regression, the virtio balloon memory stats feature is being + * disabled in qemu-0.13. + * + * -aglitke + */ + /* f |= (1 << VIRTIO_BALLOON_F_STATS_VQ); */ return f; }