From patchwork Wed Sep 8 13:29:36 2010 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kevin Wolf X-Patchwork-Id: 64156 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [199.232.76.165]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id 96F87B6EFF for ; Thu, 9 Sep 2010 00:34:44 +1000 (EST) Received: from localhost ([127.0.0.1]:47178 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OtLjV-0004I7-Dx for incoming@patchwork.ozlabs.org; Wed, 08 Sep 2010 10:34:41 -0400 Received: from [140.186.70.92] (port=55748 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OtL2U-0004hJ-DO for qemu-devel@nongnu.org; Wed, 08 Sep 2010 09:50:20 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1OtKiq-0005cr-84 for qemu-devel@nongnu.org; Wed, 08 Sep 2010 09:29:57 -0400 Received: from mx1.redhat.com ([209.132.183.28]:40391) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OtKiq-0005ch-0F for qemu-devel@nongnu.org; Wed, 08 Sep 2010 09:29:56 -0400 Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id o88DTmBK009319 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Wed, 8 Sep 2010 09:29:48 -0400 Received: from dhcp-5-188.str.redhat.com (dhcp-5-175.str.redhat.com [10.32.5.175]) by int-mx01.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id o88DTNnX001351; Wed, 8 Sep 2010 09:29:47 -0400 From: Kevin Wolf To: anthony@codemonkey.ws Date: Wed, 8 Sep 2010 15:29:36 +0200 Message-Id: <1283952582-17498-20-git-send-email-kwolf@redhat.com> In-Reply-To: <1283952582-17498-1-git-send-email-kwolf@redhat.com> References: <1283952582-17498-1-git-send-email-kwolf@redhat.com> X-Scanned-By: MIMEDefang 2.67 on 10.5.11.11 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. Cc: kwolf@redhat.com, qemu-devel@nongnu.org Subject: [Qemu-devel] [PATCH 19/25] raw-posix: Don't use file name for host_cdrom detection on Linux X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org On Linux, we have code to detect CD-ROMs using an ioctl. We shouldn't lose anything but false positives by removing the check for a /dev/cd* path. Signed-off-by: Kevin Wolf --- block/raw-posix.c | 3 --- 1 files changed, 0 insertions(+), 3 deletions(-) diff --git a/block/raw-posix.c b/block/raw-posix.c index 72fb8ce..0fce449 100644 --- a/block/raw-posix.c +++ b/block/raw-posix.c @@ -1154,9 +1154,6 @@ static int cdrom_probe_device(const char *filename) int fd, ret; int prio = 0; - if (strstart(filename, "/dev/cd", NULL)) - prio = 50; - fd = open(filename, O_RDONLY | O_NONBLOCK); if (fd < 0) { goto out;