Patchwork [v2] mtd: fix the build warning for fsl_upm.c

login
register
mail settings
Submitter Zang Roy-R61911
Date Sept. 8, 2010, 8:47 a.m.
Message ID <1283935675-14215-1-git-send-email-tie-fei.zang@freescale.com>
Download mbox | patch
Permalink /patch/64120/
State Accepted
Commit 0eecf4b20d63e0662d0a9732e9bd8a84bd3f872c
Headers show

Comments

Zang Roy-R61911 - Sept. 8, 2010, 8:47 a.m.
Fix the build warning:

drivers/mtd/nand/fsl_upm.c: In function 'fun_chip_init':
drivers/mtd/nand/fsl_upm.c:190: warning: format '%x' expects type 'unsigned int', but argument 3 has type 'resource_size_t'

Signed-off-by: Roy Zang <tie-fei.zang@freescale.com>
---
Comparing v1, using u64 instead of u32 for io_res->start.

 drivers/mtd/nand/fsl_upm.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
Artem Bityutskiy - Sept. 8, 2010, 9:59 a.m.
On Wed, 2010-09-08 at 16:47 +0800, Roy Zang wrote:
> Fix the build warning:
> 
> drivers/mtd/nand/fsl_upm.c: In function 'fun_chip_init':
> drivers/mtd/nand/fsl_upm.c:190: warning: format '%x' expects type 'unsigned int', but argument 3 has type 'resource_size_t'
> 
> Signed-off-by: Roy Zang <tie-fei.zang@freescale.com>

Pushed to l2-mtd-2.6.git, thanks.

Patch

diff --git a/drivers/mtd/nand/fsl_upm.c b/drivers/mtd/nand/fsl_upm.c
index 4eff8b2..c8ab156 100644
--- a/drivers/mtd/nand/fsl_upm.c
+++ b/drivers/mtd/nand/fsl_upm.c
@@ -186,7 +186,7 @@  static int __devinit fun_chip_init(struct fsl_upm_nand *fun,
 	if (!flash_np)
 		return -ENODEV;
 
-	fun->mtd.name = kasprintf(GFP_KERNEL, "%x.%s", io_res->start,
+	fun->mtd.name = kasprintf(GFP_KERNEL, "0x%llx.%s", (u64)io_res->start,
 				  flash_np->name);
 	if (!fun->mtd.name) {
 		ret = -ENOMEM;