From patchwork Wed Sep 8 01:55:13 2010 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: Re: [PATCH 4/5] rtc: rtc-s3c: Fix on RTC initialization method Date: Tue, 07 Sep 2010 15:55:13 -0000 From: Wan ZongShun X-Patchwork-Id: 64084 Message-Id: To: Ben Dooks Cc: Kukjin Kim , linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, rtc-linux@googlegroups.com, p_gortmaker@yahoo.com, a.zummo@towertech.it, Changhwan Youn 2010/9/8 Ben Dooks : > On 07/09/10 06:29, Kukjin Kim wrote: >> From: Changhwan Youn >> >> This patch changes RTC initialization method on probe() as >> per Wan ZongShun's suggestion. The 'rtc_valid_tm(tm)' can >> check whether RTC BCD is valid or not. >> Hi Kukjin, I think you misunderstood my meaning. You only need add the ''rtc_valid_tm' checking in s3c_rtc_gettime() function as following patch. --- drivers/rtc/rtc-s3c.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) static int s3c_rtc_settime(struct device *dev, struct rtc_time *tm) diff --git a/drivers/rtc/rtc-s3c.c b/drivers/rtc/rtc-s3c.c index a0d3ec8..270842c 100644 --- a/drivers/rtc/rtc-s3c.c +++ b/drivers/rtc/rtc-s3c.c @@ -185,7 +185,7 @@ static int s3c_rtc_gettime(struct device *dev, struct rtc_time *rtc_tm) rtc_tm->tm_year += 100; rtc_tm->tm_mon -= 1; - return 0; + return rtc_valid_tm(rtc_tm); }