Message ID | 1466980753-667-2-git-send-email-Aduskett@gmail.com |
---|---|
State | Accepted, archived |
Headers | show |
Adam, All, On 2016-06-26 18:39 -0400, Adam Duskett spake thusly: > Signed-off-by: Adam Duskett <Aduskett@gmail.com> Hash verified to be OK. Reviewed-by: "Yann E. MORIN" <yann.morin.1998@free.fr> Regards, Yann E. MORIN. > --- > Changes v4 -> v6: > - Patch series version bump. > > Changes v3 -> v4: > - Updated to 2.6 instead of 2.5.2 > > Changes v2 -> v3: > - Split patch into two patches. One for a version bump, the second for > the ability to build as a host package. > > Changes v1 -> v2: > - Version bump and the ability to build as a host package as a > single patch. > > package/audit/audit.hash | 2 +- > package/audit/audit.mk | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/package/audit/audit.hash b/package/audit/audit.hash > index f234fdb..3712f43 100644 > --- a/package/audit/audit.hash > +++ b/package/audit/audit.hash > @@ -1,2 +1,2 @@ > #Locally computed > -sha256 25f57f465f3230d7b1166b615ffd6748818a3dc225d0e8b396c5b2e951674e23 audit-2.4.4.tar.gz > +sha256 b04dbc16dd877c32c3a05a512ed825abfbd5fabd5d3ecca6b4fcbd6bbac5f94e audit-2.6.tar.gz > diff --git a/package/audit/audit.mk b/package/audit/audit.mk > index 1fbc623..937244d 100644 > --- a/package/audit/audit.mk > +++ b/package/audit/audit.mk > @@ -4,7 +4,7 @@ > # > ################################################################################ > > -AUDIT_VERSION = 2.4.4 > +AUDIT_VERSION = 2.6 > AUDIT_SITE = http://people.redhat.com/sgrubb/audit > AUDIT_LICENSE = GPLv2 > AUDIT_LICENSE_FILES = COPYING > -- > 2.7.4 > > _______________________________________________ > buildroot mailing list > buildroot@busybox.net > http://lists.busybox.net/mailman/listinfo/buildroot
Hello, On Sun, 26 Jun 2016 18:39:08 -0400, Adam Duskett wrote: > Signed-off-by: Adam Duskett <Aduskett@gmail.com> > --- > Changes v4 -> v6: > - Patch series version bump. Applied to master, thanks. Thomas
Adam, All, On 2016-06-26 18:39 -0400, Adam Duskett spake thusly: > Signed-off-by: Adam Duskett <Aduskett@gmail.com> > --- [--SNIP--] > diff --git a/package/audit/audit.mk b/package/audit/audit.mk > index 1fbc623..937244d 100644 > --- a/package/audit/audit.mk > +++ b/package/audit/audit.mk > @@ -4,7 +4,7 @@ > # > ################################################################################ > > -AUDIT_VERSION = 2.4.4 > +AUDIT_VERSION = 2.6 This is causing a bunch of autobuilder failures: http://autobuild.buildroot.org/?reason=audit-2.6.2 Care to have a look at it, please? Regards, Yann E. MORIN. > AUDIT_SITE = http://people.redhat.com/sgrubb/audit > AUDIT_LICENSE = GPLv2 > AUDIT_LICENSE_FILES = COPYING > -- > 2.7.4 > > _______________________________________________ > buildroot mailing list > buildroot@busybox.net > http://lists.busybox.net/mailman/listinfo/buildroot
Hey! Sorry about not getting back to you sooner; I will look into this right away! On Tue, Jul 5, 2016 at 1:16 PM, Yann E. MORIN <yann.morin.1998@free.fr> wrote: > Adam, All, > > On 2016-06-26 18:39 -0400, Adam Duskett spake thusly: >> Signed-off-by: Adam Duskett <Aduskett@gmail.com> >> --- > [--SNIP--] >> diff --git a/package/audit/audit.mk b/package/audit/audit.mk >> index 1fbc623..937244d 100644 >> --- a/package/audit/audit.mk >> +++ b/package/audit/audit.mk >> @@ -4,7 +4,7 @@ >> # >> ################################################################################ >> >> -AUDIT_VERSION = 2.4.4 >> +AUDIT_VERSION = 2.6 > > This is causing a bunch of autobuilder failures: > http://autobuild.buildroot.org/?reason=audit-2.6.2 > > Care to have a look at it, please? > > Regards, > Yann E. MORIN. > >> AUDIT_SITE = http://people.redhat.com/sgrubb/audit >> AUDIT_LICENSE = GPLv2 >> AUDIT_LICENSE_FILES = COPYING >> -- >> 2.7.4 >> >> _______________________________________________ >> buildroot mailing list >> buildroot@busybox.net >> http://lists.busybox.net/mailman/listinfo/buildroot > > -- > .-----------------.--------------------.------------------.--------------------. > | Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: | > | +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ | > | +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no | > | http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. | > '------------------------------^-------^------------------^--------------------'
All; I think this is a bug in Audit actually. Audit 2.6.x checks for AUDIT_FEATURE_VERSION to be defined in include/linux/audit.h (this define was introduced in kernel version 3.13) and then blindly assumes that struct audit_status has feature_bitmap. However this looks like a problem as feature_bitmap wasn't introduced until kernel 3.19, even though the requirements for audit state > 2.6.30 (http://people.redhat.com/sgrubb/audit/) This causes a compile error when attempting to compile audit 2.6.x against kernel headers younger than 3.19. For the mean time i could add a conditional to require header versions > 3.19, although I am going to submit a bug report to the audit team as well. Thoughts? Adam On Wed, Jul 6, 2016 at 9:47 AM, Adam Duskett <aduskett@gmail.com> wrote: > Hey! Sorry about not getting back to you sooner; I will look into this > right away! > > On Tue, Jul 5, 2016 at 1:16 PM, Yann E. MORIN <yann.morin.1998@free.fr> wrote: >> Adam, All, >> >> On 2016-06-26 18:39 -0400, Adam Duskett spake thusly: >>> Signed-off-by: Adam Duskett <Aduskett@gmail.com> >>> --- >> [--SNIP--] >>> diff --git a/package/audit/audit.mk b/package/audit/audit.mk >>> index 1fbc623..937244d 100644 >>> --- a/package/audit/audit.mk >>> +++ b/package/audit/audit.mk >>> @@ -4,7 +4,7 @@ >>> # >>> ################################################################################ >>> >>> -AUDIT_VERSION = 2.4.4 >>> +AUDIT_VERSION = 2.6 >> >> This is causing a bunch of autobuilder failures: >> http://autobuild.buildroot.org/?reason=audit-2.6.2 >> >> Care to have a look at it, please? >> >> Regards, >> Yann E. MORIN. >> >>> AUDIT_SITE = http://people.redhat.com/sgrubb/audit >>> AUDIT_LICENSE = GPLv2 >>> AUDIT_LICENSE_FILES = COPYING >>> -- >>> 2.7.4 >>> >>> _______________________________________________ >>> buildroot mailing list >>> buildroot@busybox.net >>> http://lists.busybox.net/mailman/listinfo/buildroot >> >> -- >> .-----------------.--------------------.------------------.--------------------. >> | Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: | >> | +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ | >> | +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no | >> | http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. | >> '------------------------------^-------^------------------^--------------------'
Adam, All, On 2016-07-06 10:42 -0400, Adam Duskett spake thusly: > I think this is a bug in Audit actually. > > Audit 2.6.x checks for AUDIT_FEATURE_VERSION to be defined in > include/linux/audit.h (this define was introduced in kernel version > 3.13) and then blindly assumes that struct audit_status has > feature_bitmap. > However this looks like a problem as feature_bitmap wasn't introduced > until kernel 3.19, even though the requirements for audit state > > 2.6.30 (http://people.redhat.com/sgrubb/audit/) > > This causes a compile error when attempting to compile audit 2.6.x > against kernel headers younger than 3.19. Thanks for investigating and explaining! :-) > For the mean time i could add a conditional to require header versions > > 3.19, although I am going to submit a bug report to the audit team > as well. I was gonna reply with a "depend on linux >= 3.19" but Thomas already sent a patch to fix it. Regards, Yann E. MORIN.
diff --git a/package/audit/audit.hash b/package/audit/audit.hash index f234fdb..3712f43 100644 --- a/package/audit/audit.hash +++ b/package/audit/audit.hash @@ -1,2 +1,2 @@ #Locally computed -sha256 25f57f465f3230d7b1166b615ffd6748818a3dc225d0e8b396c5b2e951674e23 audit-2.4.4.tar.gz +sha256 b04dbc16dd877c32c3a05a512ed825abfbd5fabd5d3ecca6b4fcbd6bbac5f94e audit-2.6.tar.gz diff --git a/package/audit/audit.mk b/package/audit/audit.mk index 1fbc623..937244d 100644 --- a/package/audit/audit.mk +++ b/package/audit/audit.mk @@ -4,7 +4,7 @@ # ################################################################################ -AUDIT_VERSION = 2.4.4 +AUDIT_VERSION = 2.6 AUDIT_SITE = http://people.redhat.com/sgrubb/audit AUDIT_LICENSE = GPLv2 AUDIT_LICENSE_FILES = COPYING
Signed-off-by: Adam Duskett <Aduskett@gmail.com> --- Changes v4 -> v6: - Patch series version bump. Changes v3 -> v4: - Updated to 2.6 instead of 2.5.2 Changes v2 -> v3: - Split patch into two patches. One for a version bump, the second for the ability to build as a host package. Changes v1 -> v2: - Version bump and the ability to build as a host package as a single patch. package/audit/audit.hash | 2 +- package/audit/audit.mk | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-)