| Message ID | 1466970307-2411-5-git-send-email-vidya@cumulusnetworks.com |
|---|---|
| State | Not Applicable, archived |
| Delegated to: | David Miller |
| Headers | show |
On Sun, Jun 26, 2016 at 12:45 PM, Vidya Sagar Ravipati <vidya@cumulusnetworks.com> wrote: > From: Vidya Sagar Ravipati <vidya@cumulusnetworks.com> > > Enhancing link mode bits to support 25G/50G/100G > for supported and advertised speed mode bits > > Signed-off-by: Vidya Sagar Ravipati <vidya@cumulusnetworks.com> > --- > ethtool.c | 27 +++++++++++++++++++++++++++ > 1 file changed, 27 insertions(+) > > diff --git a/ethtool.c b/ethtool.c > index 1d6564e..5c3c765 100644 > --- a/ethtool.c > +++ b/ethtool.c > @@ -512,6 +512,15 @@ static void init_global_link_mode_masks(void) > ETHTOOL_LINK_MODE_56000baseCR4_Full_BIT, > ETHTOOL_LINK_MODE_56000baseSR4_Full_BIT, > ETHTOOL_LINK_MODE_56000baseLR4_Full_BIT, > + ETHTOOL_LINK_MODE_25000baseCR_Full_BIT, > + ETHTOOL_LINK_MODE_25000baseKR_Full_BIT, > + ETHTOOL_LINK_MODE_25000baseSR_Full_BIT, > + ETHTOOL_LINK_MODE_50000baseCR2_Full_BIT, > + ETHTOOL_LINK_MODE_50000baseKR2_Full_BIT, > + ETHTOOL_LINK_MODE_100000baseKR4_Full_BIT, > + ETHTOOL_LINK_MODE_100000baseSR4_Full_BIT, > + ETHTOOL_LINK_MODE_100000baseCR4_Full_BIT, > + ETHTOOL_LINK_MODE_100000baseLR4_ER4_Full_BIT, > }; > static const enum ethtool_link_mode_bit_indices > additional_advertised_flags_bits[] = { > @@ -632,6 +641,24 @@ static void dump_link_caps(const char *prefix, const char *an_prefix, > "56000baseSR4/Full" }, > { 0, ETHTOOL_LINK_MODE_56000baseLR4_Full_BIT, > "56000baseLR4/Full" }, > + { 0, ETHTOOL_LINK_MODE_25000baseCR_Full_BIT, > + "25000baseCR/Full" }, > + { 0, ETHTOOL_LINK_MODE_25000baseKR_Full_BIT, > + "25000baseKR/Full" }, > + { 0, ETHTOOL_LINK_MODE_25000baseSR_Full_BIT, > + "25000baseSR/Full" }, > + { 0, ETHTOOL_LINK_MODE_50000baseCR2_Full_BIT, > + "50000baseCR2/Full" }, > + { 0, ETHTOOL_LINK_MODE_50000baseKR2_Full_BIT, > + "50000baseKR2/Full" }, > + { 0, ETHTOOL_LINK_MODE_100000baseKR4_Full_BIT, > + "100000baseKR4/Full" }, > + { 0, ETHTOOL_LINK_MODE_100000baseSR4_Full_BIT, > + "100000baseSR4/Full" }, > + { 0, ETHTOOL_LINK_MODE_100000baseCR4_Full_BIT, > + "100000baseCR4/Full" }, > + { 0, ETHTOOL_LINK_MODE_100000baseLR4_ER4_Full_BIT, > + "100000baseLR4_ER4/Full" }, > }; > int indent; > int did1, new_line_pend, i; > -- > 2.1.4 > Acked-By: David Decotigny <decot@googlers.com>
> Enhancing link mode bits to support 25G/50G/100G for supported and > advertised speed mode bits > > Signed-off-by: Vidya Sagar Ravipati <vidya@cumulusnetworks.com> > --- > ethtool.c | 27 +++++++++++++++++++++++++++ > 1 file changed, 27 insertions(+) Hi Vidya, Are you re-trying your series one anytime soon? If not, can we simply push this [and ethtool-copy.h], as those are needed for querying/setting the recently added new speeds.
Yuval,
I will try to resubmit the patches this week with updated comments
Thanks
Vidya Sagar
On Sat, Jul 23, 2016 at 10:57 PM, Yuval Mintz <Yuval.Mintz@qlogic.com> wrote:
>> Enhancing link mode bits to support 25G/50G/100G for supported and
>> advertised speed mode bits
>>
>> Signed-off-by: Vidya Sagar Ravipati <vidya@cumulusnetworks.com>
>> ---
>> ethtool.c | 27 +++++++++++++++++++++++++++
>> 1 file changed, 27 insertions(+)
>
> Hi Vidya,
>
> Are you re-trying your series one anytime soon?
>
> If not, can we simply push this [and ethtool-copy.h], as those are needed
> for querying/setting the recently added new speeds.
>
Are these revised patches still on their way? John On Sun, Jul 24, 2016 at 01:57:14AM -0700, Vidya Sagar Ravipati wrote: > Yuval, > I will try to resubmit the patches this week with updated comments > > Thanks > Vidya Sagar > > On Sat, Jul 23, 2016 at 10:57 PM, Yuval Mintz <Yuval.Mintz@qlogic.com> > wrote: > > > > Enhancing link mode bits to support 25G/50G/100G for supported and > > > advertised speed mode bits > > > > > > Signed-off-by: Vidya Sagar Ravipati <vidya@cumulusnetworks.com> > > > --- > > > ethtool.c | 27 +++++++++++++++++++++++++++ > > > 1 file changed, 27 insertions(+) > > > > Hi Vidya, > > > > Are you re-trying your series one anytime soon? > > > > If not, can we simply push this [and ethtool-copy.h], as those are needed > > for querying/setting the recently added new speeds. > > > >
Ping? On Tue, Aug 02, 2016 at 03:49:57PM -0400, John W. Linville wrote: > Are these revised patches still on their way? > > John > > On Sun, Jul 24, 2016 at 01:57:14AM -0700, Vidya Sagar Ravipati wrote: > > Yuval, > > I will try to resubmit the patches this week with updated comments > > > > Thanks > > Vidya Sagar > > > > On Sat, Jul 23, 2016 at 10:57 PM, Yuval Mintz <Yuval.Mintz@qlogic.com> > > wrote: > > > > > > Enhancing link mode bits to support 25G/50G/100G for supported and > > > > advertised speed mode bits > > > > > > > > Signed-off-by: Vidya Sagar Ravipati <vidya@cumulusnetworks.com> > > > > --- > > > > ethtool.c | 27 +++++++++++++++++++++++++++ > > > > 1 file changed, 27 insertions(+) > > > > > > Hi Vidya, > > > > > > Are you re-trying your series one anytime soon? > > > > > > If not, can we simply push this [and ethtool-copy.h], as those are needed > > > for querying/setting the recently added new speeds. > > > > > > > > -- > John W. Linville Someday the world will need a hero, and you > linville@tuxdriver.com might be all we have. Be ready. >
> Ping? > > On Tue, Aug 02, 2016 at 03:49:57PM -0400, John W. Linville wrote: > > Are these revised patches still on their way? > > > > John > > > > On Sun, Jul 24, 2016 at 01:57:14AM -0700, Vidya Sagar Ravipati wrote: > > > Yuval, > > > I will try to resubmit the patches this week with updated > > > comments > > > > > > Thanks > > > Vidya Sagar I can pick this up; But I'd need someone to fill me on which of the newer speeds could support autoneg [if any].
On Sun, Aug 21, 2016 at 7:44 AM, Yuval Mintz <Yuval.Mintz@qlogic.com> wrote: >> Ping? >> >> On Tue, Aug 02, 2016 at 03:49:57PM -0400, John W. Linville wrote: >> > Are these revised patches still on their way? >> > >> > John >> > >> > On Sun, Jul 24, 2016 at 01:57:14AM -0700, Vidya Sagar Ravipati wrote: >> > > Yuval, >> > > I will try to resubmit the patches this week with updated >> > > comments >> > > >> > > Thanks >> > > Vidya Sagar > > I can pick this up; But I'd need someone to fill me on which of the newer > speeds could support autoneg [if any]. All of the new speeds support autoneg as far as I know.
diff --git a/ethtool.c b/ethtool.c index 1d6564e..5c3c765 100644 --- a/ethtool.c +++ b/ethtool.c @@ -512,6 +512,15 @@ static void init_global_link_mode_masks(void) ETHTOOL_LINK_MODE_56000baseCR4_Full_BIT, ETHTOOL_LINK_MODE_56000baseSR4_Full_BIT, ETHTOOL_LINK_MODE_56000baseLR4_Full_BIT, + ETHTOOL_LINK_MODE_25000baseCR_Full_BIT, + ETHTOOL_LINK_MODE_25000baseKR_Full_BIT, + ETHTOOL_LINK_MODE_25000baseSR_Full_BIT, + ETHTOOL_LINK_MODE_50000baseCR2_Full_BIT, + ETHTOOL_LINK_MODE_50000baseKR2_Full_BIT, + ETHTOOL_LINK_MODE_100000baseKR4_Full_BIT, + ETHTOOL_LINK_MODE_100000baseSR4_Full_BIT, + ETHTOOL_LINK_MODE_100000baseCR4_Full_BIT, + ETHTOOL_LINK_MODE_100000baseLR4_ER4_Full_BIT, }; static const enum ethtool_link_mode_bit_indices additional_advertised_flags_bits[] = { @@ -632,6 +641,24 @@ static void dump_link_caps(const char *prefix, const char *an_prefix, "56000baseSR4/Full" }, { 0, ETHTOOL_LINK_MODE_56000baseLR4_Full_BIT, "56000baseLR4/Full" }, + { 0, ETHTOOL_LINK_MODE_25000baseCR_Full_BIT, + "25000baseCR/Full" }, + { 0, ETHTOOL_LINK_MODE_25000baseKR_Full_BIT, + "25000baseKR/Full" }, + { 0, ETHTOOL_LINK_MODE_25000baseSR_Full_BIT, + "25000baseSR/Full" }, + { 0, ETHTOOL_LINK_MODE_50000baseCR2_Full_BIT, + "50000baseCR2/Full" }, + { 0, ETHTOOL_LINK_MODE_50000baseKR2_Full_BIT, + "50000baseKR2/Full" }, + { 0, ETHTOOL_LINK_MODE_100000baseKR4_Full_BIT, + "100000baseKR4/Full" }, + { 0, ETHTOOL_LINK_MODE_100000baseSR4_Full_BIT, + "100000baseSR4/Full" }, + { 0, ETHTOOL_LINK_MODE_100000baseCR4_Full_BIT, + "100000baseCR4/Full" }, + { 0, ETHTOOL_LINK_MODE_100000baseLR4_ER4_Full_BIT, + "100000baseLR4_ER4/Full" }, }; int indent; int did1, new_line_pend, i;