| Message ID | 1466777957-5126-4-git-send-email-armbru@redhat.com |
|---|---|
| State | New |
| Headers | show |
On 06/24/2016 08:19 AM, Markus Armbruster wrote: > Forgotten in commit b8c6f29. Umm, really? That commit starts with: tests/Makefile -.PHONY: check + +.PHONY: check check-block Rather, I think it was b93b63f5 that accidentally lost it during an overhaul. > > Signed-off-by: Markus Armbruster <armbru@redhat.com> > --- > tests/Makefile.include | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tests/Makefile.include b/tests/Makefile.include > index 7b0446b..233cb9c 100644 > --- a/tests/Makefile.include > +++ b/tests/Makefile.include > @@ -752,7 +752,7 @@ tests/headers/%.c: tests/header-test-template.c > > # Consolidated targets > > -.PHONY: check-qapi-schema check-qtest check-unit check check-source check-clean > +.PHONY: check-qapi-schema check-qtest check-unit check check-block check-source check-clean Long line; worth splitting? With commit message improved, Reviewed-by: Eric Blake <eblake@redhat.com>
Eric Blake <eblake@redhat.com> writes: > On 06/24/2016 08:19 AM, Markus Armbruster wrote: >> Forgotten in commit b8c6f29. > > Umm, really? That commit starts with: > > tests/Makefile > -.PHONY: check > + > +.PHONY: check check-block > > Rather, I think it was b93b63f5 that accidentally lost it during an > overhaul. Oops. Will fix. >> Signed-off-by: Markus Armbruster <armbru@redhat.com> >> --- >> tests/Makefile.include | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/tests/Makefile.include b/tests/Makefile.include >> index 7b0446b..233cb9c 100644 >> --- a/tests/Makefile.include >> +++ b/tests/Makefile.include >> @@ -752,7 +752,7 @@ tests/headers/%.c: tests/header-test-template.c >> >> # Consolidated targets >> >> -.PHONY: check-qapi-schema check-qtest check-unit check check-source check-clean >> +.PHONY: check-qapi-schema check-qtest check-unit check check-block check-source check-clean > > Long line; worth splitting? Yes. > With commit message improved, > Reviewed-by: Eric Blake <eblake@redhat.com> Thanks!
diff --git a/tests/Makefile.include b/tests/Makefile.include index 7b0446b..233cb9c 100644 --- a/tests/Makefile.include +++ b/tests/Makefile.include @@ -752,7 +752,7 @@ tests/headers/%.c: tests/header-test-template.c # Consolidated targets -.PHONY: check-qapi-schema check-qtest check-unit check check-source check-clean +.PHONY: check-qapi-schema check-qtest check-unit check check-block check-source check-clean check-qapi-schema: $(patsubst %,check-%, $(check-qapi-schema-y)) check-qtest: $(patsubst %,check-qtest-%, $(QTEST_TARGETS)) check-unit: $(patsubst %,check-%, $(check-unit-y))
Forgotten in commit b8c6f29. Signed-off-by: Markus Armbruster <armbru@redhat.com> --- tests/Makefile.include | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)