Patchwork [5/5] rtc: rtc-s3c: Fix debug message format on RTC

login
register
mail settings
Submitter Kukjin Kim
Date Sept. 7, 2010, 5:29 a.m.
Message ID <1283837381-9575-6-git-send-email-kgene.kim@samsung.com>
Download mbox | patch
Permalink /patch/63970/
State New
Headers show

Comments

Kukjin Kim - Sept. 7, 2010, 5:29 a.m.
This patch fixes debug message format on rtc-s3c.

Signed-off-by: Kukjin Kim <kgene.kim@samsung.com>
Cc: Ben Dooks <ben-linux@fluff.org>
---
 drivers/rtc/rtc-s3c.c |   18 +++++++++---------
 1 files changed, 9 insertions(+), 9 deletions(-)
Ben Dooks - Sept. 7, 2010, 11:29 p.m.
On 07/09/10 06:29, Kukjin Kim wrote:
> This patch fixes debug message format on rtc-s3c.
> 
> Signed-off-by: Kukjin Kim <kgene.kim@samsung.com>
> Cc: Ben Dooks <ben-linux@fluff.org>
> ---
>  drivers/rtc/rtc-s3c.c |   18 +++++++++---------
>  1 files changed, 9 insertions(+), 9 deletions(-)
> 

how long has this lot been broken for?

Acked-by: Ben Dooks <ben-linux@fluff.org>
Kukjin Kim - Sept. 9, 2010, 1:11 a.m.
Ben Dooks wrote:
> 
> On 07/09/10 06:29, Kukjin Kim wrote:
> > This patch fixes debug message format on rtc-s3c.
> >
> > Signed-off-by: Kukjin Kim <kgene.kim@samsung.com>
> > Cc: Ben Dooks <ben-linux@fluff.org>
> > ---
> >  drivers/rtc/rtc-s3c.c |   18 +++++++++---------
> >  1 files changed, 9 insertions(+), 9 deletions(-)
> >
> 
> how long has this lot been broken for?
> 
Haha...we don't know :-)

> Acked-by: Ben Dooks <ben-linux@fluff.org>

Thanks for your ack...so...

Hi Alessandro Zummo,
Is it possible to send this to upstream through your tree?
Or which tree is better to care this.

Thanks.

Best regards,
Kgene.
--
Kukjin Kim <kgene.kim@samsung.com>, Senior Engineer,
SW Solution Development Team, Samsung Electronics Co., Ltd.
Wan ZongShun - Sept. 10, 2010, 9:05 a.m.
2010/9/9 Kukjin Kim <kgene.kim@samsung.com>:
> Ben Dooks wrote:
>>
>> On 07/09/10 06:29, Kukjin Kim wrote:
>> > This patch fixes debug message format on rtc-s3c.
>> >
>> > Signed-off-by: Kukjin Kim <kgene.kim@samsung.com>
>> > Cc: Ben Dooks <ben-linux@fluff.org>
>> > ---
>> >  drivers/rtc/rtc-s3c.c |   18 +++++++++---------
>> >  1 files changed, 9 insertions(+), 9 deletions(-)
>> >
>>
>> how long has this lot been broken for?
>>
> Haha...we don't know :-)
>
>> Acked-by: Ben Dooks <ben-linux@fluff.org>
>
> Thanks for your ack...so...
>
> Hi Alessandro Zummo,
> Is it possible to send this to upstream through your tree?
> Or which tree is better to care this.


Please get help from Andrew.

>
> Thanks.
>
> Best regards,
> Kgene.
> --
> Kukjin Kim <kgene.kim@samsung.com>, Senior Engineer,
> SW Solution Development Team, Samsung Electronics Co., Ltd.
>
> --
> You received this message because you are subscribed to "rtc-linux".
> Membership options at http://groups.google.com/group/rtc-linux .
> Please read http://groups.google.com/group/rtc-linux/web/checklist
> before submitting a driver.
Kukjin Kim - Sept. 10, 2010, 11:38 a.m.
Wan ZongShun wrote:
> 
> 2010/9/9 Kukjin Kim <kgene.kim@samsung.com>:
> > Ben Dooks wrote:
> >>
> >> On 07/09/10 06:29, Kukjin Kim wrote:
> >> > This patch fixes debug message format on rtc-s3c.
> >> >
> >> > Signed-off-by: Kukjin Kim <kgene.kim@samsung.com>
> >> > Cc: Ben Dooks <ben-linux@fluff.org>
> >> > ---
> >> >  drivers/rtc/rtc-s3c.c |   18 +++++++++---------
> >> >  1 files changed, 9 insertions(+), 9 deletions(-)
> >> >
> >>
> >> how long has this lot been broken for?
> >>
> > Haha...we don't know :-)
> >
> >> Acked-by: Ben Dooks <ben-linux@fluff.org>
> >
> > Thanks for your ack...so...
> >
> > Hi Alessandro Zummo,
> > Is it possible to send this to upstream through your tree?
> > Or which tree is better to care this.
> 
> 
> Please get help from Andrew.
> 
Ok ;-)

Hello Andrew,

Could you please handle following items which have been got Ben's ack?

http://lists.infradead.org/pipermail/linux-arm-kernel/2010-September/025387.html
http://lists.infradead.org/pipermail/linux-arm-kernel/2010-September/025388.html
http://lists.infradead.org/pipermail/linux-arm-kernel/2010-September/025391.html

And it's available in the git repository at:
   git://git.kernel.org/pub/scm/linux/kernel/git/kgene/linux-samsung.git next-rtc-s3c

If any problems, please let me know.

Thanks.

Best regards,
Kgene.
--
Kukjin Kim <kgene.kim@samsung.com>, Senior Engineer,
SW Solution Development Team, Samsung Electronics Co., Ltd.
Andrew Morton - Sept. 10, 2010, 11:23 p.m.
On Fri, 10 Sep 2010 20:38:39 +0900
Kukjin Kim <kgene.kim@samsung.com> wrote:

> Wan ZongShun wrote:
> > 
> > 2010/9/9 Kukjin Kim <kgene.kim@samsung.com>:
> > > Ben Dooks wrote:
> > >>
> > >> On 07/09/10 06:29, Kukjin Kim wrote:
> > >> > This patch fixes debug message format on rtc-s3c.
> > >> >
> > >> > Signed-off-by: Kukjin Kim <kgene.kim@samsung.com>
> > >> > Cc: Ben Dooks <ben-linux@fluff.org>
> > >> > ---
> > >> >  drivers/rtc/rtc-s3c.c |   18 +++++++++---------
> > >> >  1 files changed, 9 insertions(+), 9 deletions(-)
> > >> >
> > >>
> > >> how long has this lot been broken for?
> > >>
> > > Haha...we don't know :-)
> > >
> > >> Acked-by: Ben Dooks <ben-linux@fluff.org>
> > >
> > > Thanks for your ack...so...
> > >
> > > Hi Alessandro Zummo,
> > > Is it possible to send this to upstream through your tree?
> > > Or which tree is better to care this.
> > 
> > 
> > Please get help from Andrew.
> > 
> Ok ;-)
> 
> Hello Andrew,
> 
> Could you please handle following items which have been got Ben's ack?
> 
> http://lists.infradead.org/pipermail/linux-arm-kernel/2010-September/025387.html
> http://lists.infradead.org/pipermail/linux-arm-kernel/2010-September/025388.html
> http://lists.infradead.org/pipermail/linux-arm-kernel/2010-September/025391.html
> 
> And it's available in the git repository at:
>    git://git.kernel.org/pub/scm/linux/kernel/git/kgene/linux-samsung.git next-rtc-s3c
> 
> If any problems, please let me know.
> 

I'd prefer to handle the whole series rather than cherrypick a subset
of it.

Patch 1/5 has a question from Ben which hasn't been responded to yet.

Patch 4/5 is due to be updated.

So please let's fix those things up, resend the entire series and cc me
on the emails?
Kukjin Kim - Sept. 10, 2010, 11:35 p.m.
Andrew Morton wrote:
> 
> On Fri, 10 Sep 2010 20:38:39 +0900
> Kukjin Kim <kgene.kim@samsung.com> wrote:
> 
> > Wan ZongShun wrote:
> > >
> > > 2010/9/9 Kukjin Kim <kgene.kim@samsung.com>:
> > > > Ben Dooks wrote:
> > > >>
> > > >> On 07/09/10 06:29, Kukjin Kim wrote:
> > > >> > This patch fixes debug message format on rtc-s3c.
> > > >> >
> > > >> > Signed-off-by: Kukjin Kim <kgene.kim@samsung.com>
> > > >> > Cc: Ben Dooks <ben-linux@fluff.org>
> > > >> > ---
> > > >> >  drivers/rtc/rtc-s3c.c |   18 +++++++++---------
> > > >> >  1 files changed, 9 insertions(+), 9 deletions(-)
> > > >> >
> > > >>
> > > >> how long has this lot been broken for?
> > > >>
> > > > Haha...we don't know :-)
> > > >
> > > >> Acked-by: Ben Dooks <ben-linux@fluff.org>
> > > >
> > > > Thanks for your ack...so...
> > > >
> > > > Hi Alessandro Zummo,
> > > > Is it possible to send this to upstream through your tree?
> > > > Or which tree is better to care this.
> > >
> > >
> > > Please get help from Andrew.
> > >
> > Ok ;-)
> >
> > Hello Andrew,
> >
> > Could you please handle following items which have been got Ben's ack?
> >
> >
http://lists.infradead.org/pipermail/linux-arm-kernel/2010-September/025387.
html
> >
http://lists.infradead.org/pipermail/linux-arm-kernel/2010-September/025388.
html
> >
http://lists.infradead.org/pipermail/linux-arm-kernel/2010-September/025391.
html
> >
> > And it's available in the git repository at:
> >    git://git.kernel.org/pub/scm/linux/kernel/git/kgene/linux-samsung.git
next-rtc-
> s3c
> >
> > If any problems, please let me know.
> >
> 
> I'd prefer to handle the whole series rather than cherrypick a subset
> of it.
> 
> Patch 1/5 has a question from Ben which hasn't been responded to yet.
> 
> Patch 4/5 is due to be updated.
> 
> So please let's fix those things up, resend the entire series and cc me
> on the emails?

Sure, will do it.

Have a nice weekend ;-)

Thanks.

Best regards,
Kgene.
--
Kukjin Kim <kgene.kim@samsung.com>, Senior Engineer,
SW Solution Development Team, Samsung Electronics Co., Ltd.
Kukjin Kim - Oct. 7, 2010, 11:16 p.m.
Andrew Morton wrote:
> 
> On Fri, 10 Sep 2010 20:38:39 +0900
> Kukjin Kim <kgene.kim@samsung.com> wrote:
> 
> > Wan ZongShun wrote:
> > >
> > > 2010/9/9 Kukjin Kim <kgene.kim@samsung.com>:
> > > > Ben Dooks wrote:
> > > >>
> > > >> On 07/09/10 06:29, Kukjin Kim wrote:
> > > >> > This patch fixes debug message format on rtc-s3c.
> > > >> >
> > > >> > Signed-off-by: Kukjin Kim <kgene.kim@samsung.com>
> > > >> > Cc: Ben Dooks <ben-linux@fluff.org>
> > > >> > ---
> > > >> >  drivers/rtc/rtc-s3c.c |   18 +++++++++---------
> > > >> >  1 files changed, 9 insertions(+), 9 deletions(-)
> > > >> >
> > > >>
> > > >> how long has this lot been broken for?
> > > >>
> > > > Haha...we don't know :-)
> > > >
> > > >> Acked-by: Ben Dooks <ben-linux@fluff.org>
> > > >
> > > > Thanks for your ack...so...
> > > >
> > > > Hi Alessandro Zummo,
> > > > Is it possible to send this to upstream through your tree?
> > > > Or which tree is better to care this.
> > >
> > >
> > > Please get help from Andrew.
> > >
> > Ok ;-)
> >
> > Hello Andrew,
> >
> > Could you please handle following items which have been got Ben's ack?
> >
> >
http://lists.infradead.org/pipermail/linux-arm-kernel/2010-September/025387.
html
> >
http://lists.infradead.org/pipermail/linux-arm-kernel/2010-September/025388.
html
> >
http://lists.infradead.org/pipermail/linux-arm-kernel/2010-September/025391.
html
> >
> > And it's available in the git repository at:
> >    git://git.kernel.org/pub/scm/linux/kernel/git/kgene/linux-samsung.git
next-rtc-
> s3c
> >
> > If any problems, please let me know.
> >
> 
> I'd prefer to handle the whole series rather than cherrypick a subset
> of it.
> 
> Patch 1/5 has a question from Ben which hasn't been responded to yet.
> 
> Patch 4/5 is due to be updated.
> 
> So please let's fix those things up, resend the entire series and cc me
> on the emails?

Hi Andrew,

Sorry for late response.

Updated patch 1/5 has been tested on S3C24XX and its working fine.
Its remained issue is that Ben was wondering its working on S3C24XX.

And about the patch 4/5, I did address comments from Ben Dooks and Wan
ZongShun.

So could you please handle this series?
If any problems, please kindly let me know.

They are since commit cb655d0f3d57c23db51b981648e452988c0223f9:
  Linux 2.6.36-rc7 (2010-10-06 13:39:52 -0700)

are available in the git repository at:
  git://git.kernel.org/pub/scm/linux/kernel/git/kgene/linux-samsung.git
next-rtc-s3c

Thanks.

Best regards,
Kgene.
--
Kukjin Kim <kgene.kim@samsung.com>, Senior Engineer,
SW Solution Development Team, Samsung Electronics Co., Ltd.
Andrew Morton - Oct. 7, 2010, 11:28 p.m.
On Fri, 08 Oct 2010 08:16:44 +0900
Kukjin Kim <kgene.kim@samsung.com> wrote:

> Updated patch 1/5 has been tested on S3C24XX and its working fine.
> Its remained issue is that Ben was wondering its working on S3C24XX.
> 
> And about the patch 4/5, I did address comments from Ben Dooks and Wan
> ZongShun.

ok...

> So could you please handle this series?
> If any problems, please kindly let me know.
> 
> They are since commit cb655d0f3d57c23db51b981648e452988c0223f9:
>   Linux 2.6.36-rc7 (2010-10-06 13:39:52 -0700)
> 
> are available in the git repository at:
>   git://git.kernel.org/pub/scm/linux/kernel/git/kgene/linux-samsung.git
> next-rtc-s3c

Can you please email them all out in the old-fashioned way?  Because a)
I don't manage patches with git and b) that way people will actually
look at the code.

Thanks.
Kukjin Kim - Oct. 7, 2010, 11:46 p.m.
Andrew Morton wrote:
> 
> On Fri, 08 Oct 2010 08:16:44 +0900
> Kukjin Kim <kgene.kim@samsung.com> wrote:
> 
> > Updated patch 1/5 has been tested on S3C24XX and its working fine.
> > Its remained issue is that Ben was wondering its working on S3C24XX.
> >
> > And about the patch 4/5, I did address comments from Ben Dooks and Wan
> > ZongShun.
> 
> ok...
> 
> > So could you please handle this series?
> > If any problems, please kindly let me know.
> >
> > They are since commit cb655d0f3d57c23db51b981648e452988c0223f9:
> >   Linux 2.6.36-rc7 (2010-10-06 13:39:52 -0700)
> >
> > are available in the git repository at:
> >   git://git.kernel.org/pub/scm/linux/kernel/git/kgene/linux-samsung.git
> > next-rtc-s3c
> 
> Can you please email them all out in the old-fashioned way?  Because a)
> I don't manage patches with git and b) that way people will actually
> look at the code.
> 
Sure...it's no problem.
You mean...old-fashioned way is re-sending patches to mailinglist including
Cc'ed you?

> Thanks.

Thanks :-)

Best regards,
Kgene.
--
Kukjin Kim <kgene.kim@samsung.com>, Senior Engineer,
SW Solution Development Team, Samsung Electronics Co., Ltd.

Patch

diff --git a/drivers/rtc/rtc-s3c.c b/drivers/rtc/rtc-s3c.c
index 7f15073..3c3ecdf 100644
--- a/drivers/rtc/rtc-s3c.c
+++ b/drivers/rtc/rtc-s3c.c
@@ -171,8 +171,8 @@  static int s3c_rtc_gettime(struct device *dev, struct rtc_time *rtc_tm)
 		goto retry_get_time;
 	}
 
-	pr_debug("read time %02x.%02x.%02x %02x/%02x/%02x\n",
-		 rtc_tm->tm_year, rtc_tm->tm_mon, rtc_tm->tm_mday,
+	pr_debug("read time %04d.%02d.%02d %02d:%02d:%02d\n",
+		 1900 + rtc_tm->tm_year, rtc_tm->tm_mon, rtc_tm->tm_mday,
 		 rtc_tm->tm_hour, rtc_tm->tm_min, rtc_tm->tm_sec);
 
 	rtc_tm->tm_sec = bcd2bin(rtc_tm->tm_sec);
@@ -193,8 +193,8 @@  static int s3c_rtc_settime(struct device *dev, struct rtc_time *tm)
 	void __iomem *base = s3c_rtc_base;
 	int year = tm->tm_year - 100;
 
-	pr_debug("set time %02d.%02d.%02d %02d/%02d/%02d\n",
-		 tm->tm_year, tm->tm_mon, tm->tm_mday,
+	pr_debug("set time %04d.%02d.%02d %02d:%02d:%02d\n",
+		 1900 + tm->tm_year, tm->tm_mon, tm->tm_mday,
 		 tm->tm_hour, tm->tm_min, tm->tm_sec);
 
 	/* we get around y2k by simply not supporting it */
@@ -231,9 +231,9 @@  static int s3c_rtc_getalarm(struct device *dev, struct rtc_wkalrm *alrm)
 
 	alrm->enabled = (alm_en & S3C2410_RTCALM_ALMEN) ? 1 : 0;
 
-	pr_debug("read alarm %02x %02x.%02x.%02x %02x/%02x/%02x\n",
+	pr_debug("read alarm %d, %04d.%02d.%02d %02d:%02d:%02d\n",
 		 alm_en,
-		 alm_tm->tm_year, alm_tm->tm_mon, alm_tm->tm_mday,
+		 1900 + alm_tm->tm_year, alm_tm->tm_mon, alm_tm->tm_mday,
 		 alm_tm->tm_hour, alm_tm->tm_min, alm_tm->tm_sec);
 
 
@@ -280,10 +280,10 @@  static int s3c_rtc_setalarm(struct device *dev, struct rtc_wkalrm *alrm)
 	void __iomem *base = s3c_rtc_base;
 	unsigned int alrm_en;
 
-	pr_debug("s3c_rtc_setalarm: %d, %02x/%02x/%02x %02x.%02x.%02x\n",
+	pr_debug("s3c_rtc_setalarm: %d, %04d.%02d.%02d %02d:%02d:%02d\n",
 		 alrm->enabled,
-		 tm->tm_mday & 0xff, tm->tm_mon & 0xff, tm->tm_year & 0xff,
-		 tm->tm_hour & 0xff, tm->tm_min & 0xff, tm->tm_sec);
+		 1900 + tm->tm_year, tm->tm_mon, tm->tm_mday,
+		 tm->tm_hour, tm->tm_min, tm->tm_sec);
 
 
 	alrm_en = readb(base + S3C2410_RTCALM) & S3C2410_RTCALM_ALMEN;