Message ID | 9303aacab6fc99c113c9ca742beae73abbab47c6.1466622379.git.yann.morin.1998@free.fr |
---|---|
State | Accepted |
Headers | show |
Hi Yann, Le 22/06/2016 à 21:07, Yann E. MORIN a écrit : > The hostname does not look like it serves any useful purpose, except > maybe to set set perladmin email. > > Which is undoubtfully useless on the target. > > A followup commit will make the hostname depend on the default skeleton, > so it won't always be available. We can not rely on it to be set. > > Besides, even today it is not guaranteed to be set; a user may well > leave it empty. > > Use a dummy hostname. > > Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr> Reviewed-by: Romain Naour <romain.naour@gmail.com> Best regards, Romain > --- > package/perl/perl.mk | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/package/perl/perl.mk b/package/perl/perl.mk > index 11b10ff..29af7a4 100644 > --- a/package/perl/perl.mk > +++ b/package/perl/perl.mk > @@ -54,7 +54,7 @@ PERL_CONF_OPTS = \ > -Dccflags="$(TARGET_CFLAGS)" \ > -Dldflags="$(TARGET_LDFLAGS) -lm" \ > -Dmydomain="" \ > - -Dmyhostname="$(BR2_TARGET_GENERIC_HOSTNAME)" \ > + -Dmyhostname="noname" \ > -Dmyuname="Buildroot $(BR2_VERSION_FULL)" \ > -Dosname=linux \ > -Dosvers=$(LINUX_VERSION) \ >
Hello, On Wed, 22 Jun 2016 21:07:32 +0200, Yann E. MORIN wrote: > The hostname does not look like it serves any useful purpose, except > maybe to set set perladmin email. > > Which is undoubtfully useless on the target. > > A followup commit will make the hostname depend on the default skeleton, > so it won't always be available. We can not rely on it to be set. > > Besides, even today it is not guaranteed to be set; a user may well > leave it empty. > > Use a dummy hostname. > > Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr> > --- > package/perl/perl.mk | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Applied to master, thanks. Thomas
diff --git a/package/perl/perl.mk b/package/perl/perl.mk index 11b10ff..29af7a4 100644 --- a/package/perl/perl.mk +++ b/package/perl/perl.mk @@ -54,7 +54,7 @@ PERL_CONF_OPTS = \ -Dccflags="$(TARGET_CFLAGS)" \ -Dldflags="$(TARGET_LDFLAGS) -lm" \ -Dmydomain="" \ - -Dmyhostname="$(BR2_TARGET_GENERIC_HOSTNAME)" \ + -Dmyhostname="noname" \ -Dmyuname="Buildroot $(BR2_VERSION_FULL)" \ -Dosname=linux \ -Dosvers=$(LINUX_VERSION) \
The hostname does not look like it serves any useful purpose, except maybe to set set perladmin email. Which is undoubtfully useless on the target. A followup commit will make the hostname depend on the default skeleton, so it won't always be available. We can not rely on it to be set. Besides, even today it is not guaranteed to be set; a user may well leave it empty. Use a dummy hostname. Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr> --- package/perl/perl.mk | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)