| Message ID | 1466587803-18277-1-git-send-email-bmeng.cn@gmail.com |
|---|---|
| State | Accepted |
| Commit | ff6e1569663eccaf9e582c57cc44568915c2f54b |
| Delegated to: | Bin Meng |
| Headers | show |
Hi Bin, On 22 June 2016 at 03:30, Bin Meng <bmeng.cn@gmail.com> wrote: > There is a dummy pch driver in the coreboot directory. This causes > drivers of its children fail to function due to empty ops. Remove > the whole file since it is no longer needed. > > Signed-off-by: Bin Meng <bmeng.cn@gmail.com> > --- > > arch/x86/cpu/coreboot/Makefile | 1 - > arch/x86/cpu/coreboot/pci.c | 26 -------------------------- > 2 files changed, 27 deletions(-) > delete mode 100644 arch/x86/cpu/coreboot/pci.c That was intended to support a PCH where U-Boot did not have to set it up (when booting from coreboot). Is it not needed now? Regards, Simon
Hi Simon, On Wed, Jun 22, 2016 at 10:36 PM, Simon Glass <sjg@chromium.org> wrote: > Hi Bin, > > On 22 June 2016 at 03:30, Bin Meng <bmeng.cn@gmail.com> wrote: >> There is a dummy pch driver in the coreboot directory. This causes >> drivers of its children fail to function due to empty ops. Remove >> the whole file since it is no longer needed. >> >> Signed-off-by: Bin Meng <bmeng.cn@gmail.com> >> --- >> >> arch/x86/cpu/coreboot/Makefile | 1 - >> arch/x86/cpu/coreboot/pci.c | 26 -------------------------- >> 2 files changed, 27 deletions(-) >> delete mode 100644 arch/x86/cpu/coreboot/pci.c > > That was intended to support a PCH where U-Boot did not have to set it > up (when booting from coreboot). Is it not needed now? > This is not needed now. The pch7 and pch7 driver are built for coreboot too so that they can be used. Regards, Bin
On 22 June 2016 at 17:56, Bin Meng <bmeng.cn@gmail.com> wrote: > Hi Simon, > > On Wed, Jun 22, 2016 at 10:36 PM, Simon Glass <sjg@chromium.org> wrote: >> Hi Bin, >> >> On 22 June 2016 at 03:30, Bin Meng <bmeng.cn@gmail.com> wrote: >>> There is a dummy pch driver in the coreboot directory. This causes >>> drivers of its children fail to function due to empty ops. Remove >>> the whole file since it is no longer needed. >>> >>> Signed-off-by: Bin Meng <bmeng.cn@gmail.com> >>> --- >>> >>> arch/x86/cpu/coreboot/Makefile | 1 - >>> arch/x86/cpu/coreboot/pci.c | 26 -------------------------- >>> 2 files changed, 27 deletions(-) >>> delete mode 100644 arch/x86/cpu/coreboot/pci.c >> >> That was intended to support a PCH where U-Boot did not have to set it >> up (when booting from coreboot). Is it not needed now? >> > > This is not needed now. The pch7 and pch7 driver are built for > coreboot too so that they can be used. > > Regards, > Bin Thanks. Reviewed-by: Simon Glass <sjg@chromium.org>
On Wed, Jun 29, 2016 at 2:43 AM, Simon Glass <sjg@chromium.org> wrote: > On 22 June 2016 at 17:56, Bin Meng <bmeng.cn@gmail.com> wrote: >> Hi Simon, >> >> On Wed, Jun 22, 2016 at 10:36 PM, Simon Glass <sjg@chromium.org> wrote: >>> Hi Bin, >>> >>> On 22 June 2016 at 03:30, Bin Meng <bmeng.cn@gmail.com> wrote: >>>> There is a dummy pch driver in the coreboot directory. This causes >>>> drivers of its children fail to function due to empty ops. Remove >>>> the whole file since it is no longer needed. >>>> >>>> Signed-off-by: Bin Meng <bmeng.cn@gmail.com> >>>> --- >>>> >>>> arch/x86/cpu/coreboot/Makefile | 1 - >>>> arch/x86/cpu/coreboot/pci.c | 26 -------------------------- >>>> 2 files changed, 27 deletions(-) >>>> delete mode 100644 arch/x86/cpu/coreboot/pci.c >>> >>> That was intended to support a PCH where U-Boot did not have to set it >>> up (when booting from coreboot). Is it not needed now? >>> >> >> This is not needed now. The pch7 and pch7 driver are built for >> coreboot too so that they can be used. >> >> Regards, >> Bin > > Thanks. > > Reviewed-by: Simon Glass <sjg@chromium.org> Tom, will you apply this one directly for v2016.07 release? Regards, Bin
On Wed, Jun 29, 2016 at 10:02:55AM +0800, Bin Meng wrote: > On Wed, Jun 29, 2016 at 2:43 AM, Simon Glass <sjg@chromium.org> wrote: > > On 22 June 2016 at 17:56, Bin Meng <bmeng.cn@gmail.com> wrote: > >> Hi Simon, > >> > >> On Wed, Jun 22, 2016 at 10:36 PM, Simon Glass <sjg@chromium.org> wrote: > >>> Hi Bin, > >>> > >>> On 22 June 2016 at 03:30, Bin Meng <bmeng.cn@gmail.com> wrote: > >>>> There is a dummy pch driver in the coreboot directory. This causes > >>>> drivers of its children fail to function due to empty ops. Remove > >>>> the whole file since it is no longer needed. > >>>> > >>>> Signed-off-by: Bin Meng <bmeng.cn@gmail.com> > >>>> --- > >>>> > >>>> arch/x86/cpu/coreboot/Makefile | 1 - > >>>> arch/x86/cpu/coreboot/pci.c | 26 -------------------------- > >>>> 2 files changed, 27 deletions(-) > >>>> delete mode 100644 arch/x86/cpu/coreboot/pci.c > >>> > >>> That was intended to support a PCH where U-Boot did not have to set it > >>> up (when booting from coreboot). Is it not needed now? > >>> > >> > >> This is not needed now. The pch7 and pch7 driver are built for > >> coreboot too so that they can be used. > >> > >> Regards, > >> Bin > > > > Thanks. > > > > Reviewed-by: Simon Glass <sjg@chromium.org> > > Tom, will you apply this one directly for v2016.07 release? Make a PR for me please, thanks!
Hi Tom, On Wed, Jun 29, 2016 at 10:05 AM, Tom Rini <trini@konsulko.com> wrote: > On Wed, Jun 29, 2016 at 10:02:55AM +0800, Bin Meng wrote: >> On Wed, Jun 29, 2016 at 2:43 AM, Simon Glass <sjg@chromium.org> wrote: >> > On 22 June 2016 at 17:56, Bin Meng <bmeng.cn@gmail.com> wrote: >> >> Hi Simon, >> >> >> >> On Wed, Jun 22, 2016 at 10:36 PM, Simon Glass <sjg@chromium.org> wrote: >> >>> Hi Bin, >> >>> >> >>> On 22 June 2016 at 03:30, Bin Meng <bmeng.cn@gmail.com> wrote: >> >>>> There is a dummy pch driver in the coreboot directory. This causes >> >>>> drivers of its children fail to function due to empty ops. Remove >> >>>> the whole file since it is no longer needed. >> >>>> >> >>>> Signed-off-by: Bin Meng <bmeng.cn@gmail.com> >> >>>> --- >> >>>> >> >>>> arch/x86/cpu/coreboot/Makefile | 1 - >> >>>> arch/x86/cpu/coreboot/pci.c | 26 -------------------------- >> >>>> 2 files changed, 27 deletions(-) >> >>>> delete mode 100644 arch/x86/cpu/coreboot/pci.c >> >>> >> >>> That was intended to support a PCH where U-Boot did not have to set it >> >>> up (when booting from coreboot). Is it not needed now? >> >>> >> >> >> >> This is not needed now. The pch7 and pch7 driver are built for >> >> coreboot too so that they can be used. >> >> >> >> Regards, >> >> Bin >> > >> > Thanks. >> > >> > Reviewed-by: Simon Glass <sjg@chromium.org> >> >> Tom, will you apply this one directly for v2016.07 release? > > Make a PR for me please, thanks! > Will do. Regards, Bin
On Wed, Jun 29, 2016 at 2:43 AM, Simon Glass <sjg@chromium.org> wrote: > On 22 June 2016 at 17:56, Bin Meng <bmeng.cn@gmail.com> wrote: >> Hi Simon, >> >> On Wed, Jun 22, 2016 at 10:36 PM, Simon Glass <sjg@chromium.org> wrote: >>> Hi Bin, >>> >>> On 22 June 2016 at 03:30, Bin Meng <bmeng.cn@gmail.com> wrote: >>>> There is a dummy pch driver in the coreboot directory. This causes >>>> drivers of its children fail to function due to empty ops. Remove >>>> the whole file since it is no longer needed. >>>> >>>> Signed-off-by: Bin Meng <bmeng.cn@gmail.com> >>>> --- >>>> >>>> arch/x86/cpu/coreboot/Makefile | 1 - >>>> arch/x86/cpu/coreboot/pci.c | 26 -------------------------- >>>> 2 files changed, 27 deletions(-) >>>> delete mode 100644 arch/x86/cpu/coreboot/pci.c >>> >>> That was intended to support a PCH where U-Boot did not have to set it >>> up (when booting from coreboot). Is it not needed now? >>> >> >> This is not needed now. The pch7 and pch7 driver are built for >> coreboot too so that they can be used. >> >> Regards, >> Bin > > Thanks. > > Reviewed-by: Simon Glass <sjg@chromium.org> applied to u-boot-x86, thanks!
diff --git a/arch/x86/cpu/coreboot/Makefile b/arch/x86/cpu/coreboot/Makefile index b6e870a..d663656 100644 --- a/arch/x86/cpu/coreboot/Makefile +++ b/arch/x86/cpu/coreboot/Makefile @@ -18,4 +18,3 @@ obj-y += coreboot.o obj-y += tables.o obj-y += sdram.o obj-y += timestamp.o -obj-$(CONFIG_PCI) += pci.o diff --git a/arch/x86/cpu/coreboot/pci.c b/arch/x86/cpu/coreboot/pci.c deleted file mode 100644 index 7f5087a..0000000 --- a/arch/x86/cpu/coreboot/pci.c +++ /dev/null @@ -1,26 +0,0 @@ -/* - * Copyright (c) 2011 The Chromium OS Authors. - * (C) Copyright 2008,2009 - * Graeme Russ, <graeme.russ@gmail.com> - * - * (C) Copyright 2002 - * Daniel Engström, Omicron Ceti AB, <daniel@omicron.se> - * - * SPDX-License-Identifier: GPL-2.0+ - */ - -#include <common.h> -#include <dm.h> -#include <pci.h> - -static const struct udevice_id generic_pch_ids[] = { - { .compatible = "intel,pch7" }, - { .compatible = "intel,pch9" }, - { } -}; - -U_BOOT_DRIVER(generic_pch_drv) = { - .name = "pch", - .id = UCLASS_PCH, - .of_match = generic_pch_ids, -};
There is a dummy pch driver in the coreboot directory. This causes drivers of its children fail to function due to empty ops. Remove the whole file since it is no longer needed. Signed-off-by: Bin Meng <bmeng.cn@gmail.com> --- arch/x86/cpu/coreboot/Makefile | 1 - arch/x86/cpu/coreboot/pci.c | 26 -------------------------- 2 files changed, 27 deletions(-) delete mode 100644 arch/x86/cpu/coreboot/pci.c