| Message ID | 1466577742-18824-3-git-send-email-dirk.behme@de.bosch.com |
|---|---|
| State | Not Applicable, archived |
| Headers | show |
On 22/06/2016 at 08:42:20 +0200, Dirk Behme wrote : > From: Oleksij Rempel <fixed-term.Oleksij.Rempel@de.bosch.com> > > ... and Epson RX8900 real time clock > > Signed-off-by: Oleksij Rempel <fixed-term.Oleksij.Rempel@de.bosch.com> > Cc: devicetree@vger.kernel.org > --- > .../devicetree/bindings/rtc/epson,rx8900.txt | 22 ++++++++++++++++++++++ > 1 file changed, 22 insertions(+) > create mode 100644 Documentation/devicetree/bindings/rtc/epson,rx8900.txt > > diff --git a/Documentation/devicetree/bindings/rtc/epson,rx8900.txt b/Documentation/devicetree/bindings/rtc/epson,rx8900.txt > new file mode 100644 > index 0000000..3f61e51 > --- /dev/null > +++ b/Documentation/devicetree/bindings/rtc/epson,rx8900.txt > @@ -0,0 +1,22 @@ > +Real Time Clock driver for: > + - Epson RX8900 > + - Micro Crystal rv8803 > + > +Required properties: > +- compatible: should be: "microcrystal,rv8803" or "epson,rx8900" > +- reg : the I2C address of the device for I2C > + > +Optional properties: > +- epson,vdet-disable : boolean, if present will disable voltage detector. > + Should be set if no backup battery is used. I guess we need to make that one generic. I would use voltage-detection-disable. Andrey, can you use that one instead of dallas,disable-oscillator-stop-flag ?
On Wed, Jun 22, 2016 at 08:42:20AM +0200, Dirk Behme wrote: > From: Oleksij Rempel <fixed-term.Oleksij.Rempel@de.bosch.com> > > ... and Epson RX8900 real time clock > > Signed-off-by: Oleksij Rempel <fixed-term.Oleksij.Rempel@de.bosch.com> > Cc: devicetree@vger.kernel.org > --- > .../devicetree/bindings/rtc/epson,rx8900.txt | 22 ++++++++++++++++++++++ > 1 file changed, 22 insertions(+) > create mode 100644 Documentation/devicetree/bindings/rtc/epson,rx8900.txt Acked-by: Rob Herring <robh@kernel.org> -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Fri, Jun 24, 2016 at 12:48 AM, Alexandre Belloni <alexandre.belloni@free-electrons.com> wrote: > On 22/06/2016 at 08:42:20 +0200, Dirk Behme wrote : >> From: Oleksij Rempel <fixed-term.Oleksij.Rempel@de.bosch.com> >> >> ... and Epson RX8900 real time clock >> >> Signed-off-by: Oleksij Rempel <fixed-term.Oleksij.Rempel@de.bosch.com> >> Cc: devicetree@vger.kernel.org >> --- >> .../devicetree/bindings/rtc/epson,rx8900.txt | 22 ++++++++++++++++++++++ >> 1 file changed, 22 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/rtc/epson,rx8900.txt >> >> diff --git a/Documentation/devicetree/bindings/rtc/epson,rx8900.txt b/Documentation/devicetree/bindings/rtc/epson,rx8900.txt >> new file mode 100644 >> index 0000000..3f61e51 >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/rtc/epson,rx8900.txt >> @@ -0,0 +1,22 @@ >> +Real Time Clock driver for: >> + - Epson RX8900 >> + - Micro Crystal rv8803 >> + >> +Required properties: >> +- compatible: should be: "microcrystal,rv8803" or "epson,rx8900" >> +- reg : the I2C address of the device for I2C >> + >> +Optional properties: >> +- epson,vdet-disable : boolean, if present will disable voltage detector. >> + Should be set if no backup battery is used. > > I guess we need to make that one generic. I would use > voltage-detection-disable. > > Andrey, can you use that one instead of > dallas,disable-oscillator-stop-flag ? > AFAIU from reading RX8900 datasheet, it has two power rails main and a backup one, so setting this property disables circuitry responsible for detecting main power rail failure and switching to a backup one. DS1341 has only one power rail and setting "dallas,disable-oscillator-stop-flag" will disable circuitry responsible for detection of failure of the oscillator ticking its internal clock. IMHO, those functionalities don't have much in common and using the same property would be confusing for users of that binding on DS1341, but it's a boolean so there's not technical reason I couldn't. Thanks, Andrey Smirnov -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On 29/06/2016 at 06:34:58 +0200, fixed-term.Oleksij.Rempel wrote : > > > On 24.06.2016 21:14, Andrey Smirnov wrote: > > On Fri, Jun 24, 2016 at 12:48 AM, Alexandre Belloni > > <alexandre.belloni@free-electrons.com> wrote: > >> On 22/06/2016 at 08:42:20 +0200, Dirk Behme wrote : > >>> From: Oleksij Rempel <fixed-term.Oleksij.Rempel@de.bosch.com> > >>> > >>> ... and Epson RX8900 real time clock > >>> > >>> Signed-off-by: Oleksij Rempel <fixed-term.Oleksij.Rempel@de.bosch.com> > >>> Cc: devicetree@vger.kernel.org > >>> --- > >>> .../devicetree/bindings/rtc/epson,rx8900.txt | 22 ++++++++++++++++++++++ > >>> 1 file changed, 22 insertions(+) > >>> create mode 100644 Documentation/devicetree/bindings/rtc/epson,rx8900.txt > >>> > >>> diff --git a/Documentation/devicetree/bindings/rtc/epson,rx8900.txt b/Documentation/devicetree/bindings/rtc/epson,rx8900.txt > >>> new file mode 100644 > >>> index 0000000..3f61e51 > >>> --- /dev/null > >>> +++ b/Documentation/devicetree/bindings/rtc/epson,rx8900.txt > >>> @@ -0,0 +1,22 @@ > >>> +Real Time Clock driver for: > >>> + - Epson RX8900 > >>> + - Micro Crystal rv8803 > >>> + > >>> +Required properties: > >>> +- compatible: should be: "microcrystal,rv8803" or "epson,rx8900" > >>> +- reg : the I2C address of the device for I2C > >>> + > >>> +Optional properties: > >>> +- epson,vdet-disable : boolean, if present will disable voltage detector. > >>> + Should be set if no backup battery is used. > >> > >> I guess we need to make that one generic. I would use > >> voltage-detection-disable. > >> > >> Andrey, can you use that one instead of > >> dallas,disable-oscillator-stop-flag ? > >> > > > > AFAIU from reading RX8900 datasheet, it has two power rails main and a > > backup one, so setting this property disables circuitry responsible > > for detecting main power rail failure and switching to a backup one. > > > > DS1341 has only one power rail and setting > > "dallas,disable-oscillator-stop-flag" will disable circuitry > > responsible for detection of failure of the oscillator ticking its > > internal clock. > > > > IMHO, those functionalities don't have much in common and using the > > same property would be confusing for users of that binding on DS1341, > > but it's a boolean so there's not technical reason I couldn't. > > Should i still replace epson,vdet-disable to voltage-detection-disable? No, Andrey is right.
diff --git a/Documentation/devicetree/bindings/rtc/epson,rx8900.txt b/Documentation/devicetree/bindings/rtc/epson,rx8900.txt new file mode 100644 index 0000000..3f61e51 --- /dev/null +++ b/Documentation/devicetree/bindings/rtc/epson,rx8900.txt @@ -0,0 +1,22 @@ +Real Time Clock driver for: + - Epson RX8900 + - Micro Crystal rv8803 + +Required properties: +- compatible: should be: "microcrystal,rv8803" or "epson,rx8900" +- reg : the I2C address of the device for I2C + +Optional properties: +- epson,vdet-disable : boolean, if present will disable voltage detector. + Should be set if no backup battery is used. +- trickle-diode-disable : boolean, if present will disable internal trickle + charger diode + +Example: + + rtc: rtc@32 { + compatible = "epson,rx8900" + reg = <0x32>; + epson,vdet-disable; + trickle-diode-disable; + };