[26/27,AARCH64] Change type of __align to long long
diff mbox

Message ID 1466485631-3532-28-git-send-email-ynorov@caviumnetworks.com
State New
Headers show

Commit Message

Yury Norov June 21, 2016, 5:07 a.m. UTC
From: Andrew Pinski <apinski@cavium.com>

So that ILP32 is aligned to 64bits.

Signed-off-by: Yury Norov <ynorov@caviumnetworks.com>
---
 sysdeps/aarch64/nptl/bits/semaphore.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Andreas Schwab June 21, 2016, 8:10 a.m. UTC | #1
Yury Norov <ynorov@caviumnetworks.com> writes:

> From: Andrew Pinski <apinski@cavium.com>
>
> So that ILP32 is aligned to 64bits.
>
> Signed-off-by: Yury Norov <ynorov@caviumnetworks.com>
> ---
>  sysdeps/aarch64/nptl/bits/semaphore.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/sysdeps/aarch64/nptl/bits/semaphore.h b/sysdeps/aarch64/nptl/bits/semaphore.h
> index 3cc5b37..3fe6047 100644
> --- a/sysdeps/aarch64/nptl/bits/semaphore.h
> +++ b/sysdeps/aarch64/nptl/bits/semaphore.h
> @@ -31,5 +31,5 @@
>  typedef union
>  {
>    char __size[__SIZEOF_SEM_T];
> -  long int __align;
> +  long long int __align;
>  } sem_t;

Should __SIZEOF_SEM_T be reduced for ILP32?

Andreas.
Bamvor Jian Zhang June 21, 2016, 10:57 a.m. UTC | #2
Hi, Yury

On 2016/6/21 13:07, Yury Norov wrote:
> From: Andrew Pinski <apinski@cavium.com>
>
> So that ILP32 is aligned to 64bits.
>
> Signed-off-by: Yury Norov <ynorov@caviumnetworks.com>
> ---
>   sysdeps/aarch64/nptl/bits/semaphore.h | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/sysdeps/aarch64/nptl/bits/semaphore.h b/sysdeps/aarch64/nptl/bits/semaphore.h
> index 3cc5b37..3fe6047 100644
> --- a/sysdeps/aarch64/nptl/bits/semaphore.h
> +++ b/sysdeps/aarch64/nptl/bits/semaphore.h
> @@ -31,5 +31,5 @@
>   typedef union
>   {
>     char __size[__SIZEOF_SEM_T];
> -  long int __align;
> +  long long int __align;
Why we need align to 64bit?

Regard

Bamvor
>   } sem_t;
>
Andreas Schwab July 6, 2016, 10:36 a.m. UTC | #3
"Zhangjian (Bamvor)" <bamvor.zhangjian@huawei.com> writes:

> Hi, Yury
>
> On 2016/6/21 13:07, Yury Norov wrote:
>> From: Andrew Pinski <apinski@cavium.com>
>>
>> So that ILP32 is aligned to 64bits.
>>
>> Signed-off-by: Yury Norov <ynorov@caviumnetworks.com>
>> ---
>>   sysdeps/aarch64/nptl/bits/semaphore.h | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/sysdeps/aarch64/nptl/bits/semaphore.h b/sysdeps/aarch64/nptl/bits/semaphore.h
>> index 3cc5b37..3fe6047 100644
>> --- a/sysdeps/aarch64/nptl/bits/semaphore.h
>> +++ b/sysdeps/aarch64/nptl/bits/semaphore.h
>> @@ -31,5 +31,5 @@
>>   typedef union
>>   {
>>     char __size[__SIZEOF_SEM_T];
>> -  long int __align;
>> +  long long int __align;
> Why we need align to 64bit?

Because aarch64 defines __HAVE_64B_ATOMICS.

Andreas.

Patch
diff mbox

diff --git a/sysdeps/aarch64/nptl/bits/semaphore.h b/sysdeps/aarch64/nptl/bits/semaphore.h
index 3cc5b37..3fe6047 100644
--- a/sysdeps/aarch64/nptl/bits/semaphore.h
+++ b/sysdeps/aarch64/nptl/bits/semaphore.h
@@ -31,5 +31,5 @@ 
 typedef union
 {
   char __size[__SIZEOF_SEM_T];
-  long int __align;
+  long long int __align;
 } sem_t;