Patchwork [04/15] linux-user: improve flatload error checking

login
register
mail settings
Submitter Blue Swirl
Date Sept. 5, 2010, 3:05 p.m.
Message ID <AANLkTimtoyeArHCGUc-CJ2A8bTXs-Ue5DXPubRsRfb9v@mail.gmail.com>
Download mbox | patch
Permalink /patch/63835/
State New
Headers show

Comments

Blue Swirl - Sept. 5, 2010, 3:05 p.m.
Because of the use of unsigned type, possible errors during
load were ignored.

Fix by using a signed type.

This also fixes a warning with GCC flag -Wtype-limits.

Signed-off-by: Blue Swirl <blauwirbel@gmail.com>
---
 linux-user/flatload.c |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)

Patch

diff --git a/linux-user/flatload.c b/linux-user/flatload.c
index 8ad130a..8f9f4a5 100644
--- a/linux-user/flatload.c
+++ b/linux-user/flatload.c
@@ -383,7 +383,8 @@  static int load_flat_file(struct linux_binprm * bprm,
 		struct lib_info *libinfo, int id, abi_ulong *extra_stack)
 {
     struct flat_hdr * hdr;
-    abi_ulong textpos = 0, datapos = 0, result;
+    abi_ulong textpos = 0, datapos = 0;
+    abi_long result;
     abi_ulong realdatastart = 0;
     abi_ulong text_len, data_len, bss_len, stack_len, flags;
     abi_ulong memp = 0; /* for finding the brk area */