[tpmdd-devel,4/4,v3] add tpm2 capability test flag to tpm_tis driver
diff mbox

Message ID 1466417229-16734-5-git-send-email-andrew.zamansky@nuvoton.com
State New
Headers show

Commit Message

andrew.zamansky@nuvoton.com June 20, 2016, 10:07 a.m. UTC
Signed-off-by: Andrew Azmansky <andrew.zamansky@nuvoton.com>
---
 drivers/char/tpm/tpm_tis.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Jarkko Sakkinen June 20, 2016, 2:38 p.m. UTC | #1
Isn't tpm2_probe() call now twice in tpm_tis initialization?

On Mon, Jun 20, 2016 at 01:07:09PM +0300, andrew zamansky wrote:
> Signed-off-by: Andrew Azmansky <andrew.zamansky@nuvoton.com>
> ---
>  drivers/char/tpm/tpm_tis.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/char/tpm/tpm_tis.c b/drivers/char/tpm/tpm_tis.c
> index 30aff5b..859fb8c 100644
> --- a/drivers/char/tpm/tpm_tis.c
> +++ b/drivers/char/tpm/tpm_tis.c
> @@ -524,7 +524,7 @@ static bool tpm_tis_req_canceled(struct tpm_chip *chip, u8 status)
>  }
>  
>  static const struct tpm_class_ops tpm_tis = {
> -	.flags = TPM_OPS_AUTO_STARTUP,
> +	.flags = TPM_OPS_AUTO_STARTUP | TPM_OPS_PROBE_TPM2,
>  	.status = tpm_tis_status,
>  	.recv = tpm_tis_recv,
>  	.send = tpm_tis_send,
> -- 
> 1.9.1
> 

------------------------------------------------------------------------------
What NetFlow Analyzer can do for you? Monitors network bandwidth and traffic
patterns at an interface-level. Reveals which users, apps, and protocols are 
consuming the most bandwidth. Provides multi-vendor support for NetFlow, 
J-Flow, sFlow and other flows. Make informed decisions using capacity planning
reports. http://sdm.link/zohomanageengine
Jason Gunthorpe June 20, 2016, 9:09 p.m. UTC | #2
On Mon, Jun 20, 2016 at 05:38:57PM +0300, Jarkko Sakkinen wrote:
> Isn't tpm2_probe() call now twice in tpm_tis initialization?

Yes, this should not be done.

Jason

------------------------------------------------------------------------------
Attend Shape: An AT&T Tech Expo July 15-16. Meet us at AT&T Park in San
Francisco, CA to explore cutting-edge tech and listen to tech luminaries
present their vision of the future. This family event has something for
everyone, including kids. Get more information and register today.
http://sdm.link/attshape

Patch
diff mbox

diff --git a/drivers/char/tpm/tpm_tis.c b/drivers/char/tpm/tpm_tis.c
index 30aff5b..859fb8c 100644
--- a/drivers/char/tpm/tpm_tis.c
+++ b/drivers/char/tpm/tpm_tis.c
@@ -524,7 +524,7 @@  static bool tpm_tis_req_canceled(struct tpm_chip *chip, u8 status)
 }
 
 static const struct tpm_class_ops tpm_tis = {
-	.flags = TPM_OPS_AUTO_STARTUP,
+	.flags = TPM_OPS_AUTO_STARTUP | TPM_OPS_PROBE_TPM2,
 	.status = tpm_tis_status,
 	.recv = tpm_tis_recv,
 	.send = tpm_tis_send,